Bug 1204770 - Review Request: antlr4 - ANother Tool for Language Recognition
Summary: Review Request: antlr4 - ANother Tool for Language Recognition
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-03-23 13:22 UTC by gil cattaneo
Modified: 2015-03-26 10:23 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-03-26 10:22:53 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description gil cattaneo 2015-03-23 13:22:56 UTC
Spec URL: https://gil.fedorapeople.org/antlr4.spec
SRPM URL: https://gil.fedorapeople.org/antlr4-4.4-1.fc20.src.rpm
Description:
ANother Tool for Language Recognition, is a language tool
that provides a framework for constructing recognizers,
interpreters, compilers, and translators from grammatical
descriptions containing actions in a variety of target languages.
Fedora Account System Username: gil

Comment 1 gil cattaneo 2015-03-23 13:36:35 UTC
bundle libraries exception https://fedorahosted.org/fpc/ticket/517

Comment 2 gil cattaneo 2015-03-23 14:56:47 UTC
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=9303304

Comment 3 gil cattaneo 2015-03-26 03:46:45 UTC
(In reply to gil cattaneo from comment #1)
> bundle libraries exception https://fedorahosted.org/fpc/ticket/517
accepted

Comment 4 Mikolaj Izdebski 2015-03-26 05:41:31 UTC
Why version 4.4 is packaged instead of latest 4.5?

Comment 5 gil cattaneo 2015-03-26 05:47:46 UTC
(In reply to Mikolaj Izdebski from comment #4)
> Why version 4.4 is packaged instead of latest 4.5?

I want use this release for build 4.5, latest antlr4 release use a different builder from http://www.bildtool.org

Comment 6 gil cattaneo 2015-03-26 05:48:34 UTC
see https://github.com/antlr/antlr4/blob/master/bild.py

Comment 7 Mikolaj Izdebski 2015-03-26 05:51:35 UTC
I don't understand why 4.5 can't be packaged right away, please explain this.

Comment 8 gil cattaneo 2015-03-26 06:16:25 UTC
because if you read the file bild.py see that to bootstrap serves the same version and our maven tool does not like ... also artifacts antlr4 4.4 are not available in the various sites that you usually use to download these artifacts

Comment 9 Mikolaj Izdebski 2015-03-26 06:18:38 UTC
Are you saying that 4.5 requires 4.4 to build and won't build with itself?

Comment 10 gil cattaneo 2015-03-26 06:33:27 UTC
(In reply to Mikolaj Izdebski from comment #9)
> Are you saying that 4.5 requires 4.4 to build and won't build with itself?
require itself (4.5 requires 4.5) "BOOTSTRAP_VERSION = "4.5""
now if for you is the same i used the previous build (on my system) artifacts (4.4) for bootstrap 4.5

Comment 11 Mikolaj Izdebski 2015-03-26 06:34:31 UTC
Why not use 4.5 to bootstrap and package 4.5 then?

Comment 13 gil cattaneo 2015-03-26 06:53:52 UTC
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=9330078

Comment 14 gil cattaneo 2015-03-26 07:04:30 UTC
(In reply to Mikolaj Izdebski from comment #11)
> Why not use 4.5 to bootstrap and package 4.5 then?
[ERROR] The projects in the reactor contain a cyclic reference: Edge between 'Vertex{label='org.antlr:antlr4-maven-plugin:4.5'}' and 'Vertex{label='org.antlr:antlr4:4.5'}' introduces to cycle in the graph org.antlr:antlr4:4.5 --> org.antlr:antlr4-runtime:4.5 --> org.antlr:antlr4-maven-plugin:4.5 --> org.antlr:antlr4:4.5 -> [Help 1]

Comment 15 Mikolaj Izdebski 2015-03-26 07:08:52 UTC
I don't understand why you insist on bootstrapping with older version...

Besides that the package as-is now has some major problems:
- it doesn't build in non-bootstrap mode
- it is compat package, but it shouldn't

(In reply to gil cattaneo from comment #14)
> (In reply to Mikolaj Izdebski from comment #11)
> > Why not use 4.5 to bootstrap and package 4.5 then?
> [ERROR] The projects in the reactor contain a cyclic reference: Edge between
> 'Vertex{label='org.antlr:antlr4-maven-plugin:4.5'}' and
> 'Vertex{label='org.antlr:antlr4:4.5'}' introduces to cycle in the graph
> org.antlr:antlr4:4.5 --> org.antlr:antlr4-runtime:4.5 -->
> org.antlr:antlr4-maven-plugin:4.5 --> org.antlr:antlr4:4.5 -> [Help 1]

Once this package is built, it will be rebuilt with itself, so this needs to be solved, not worked around by using old version. I already explained you on IRC in detail how to do that.

Comment 16 Mikolaj Izdebski 2015-03-26 09:48:36 UTC
I have packaged antlr4 myself. Review request is in bug #1206080.


Note You need to log in before you can comment on or make changes to this bug.