Bug 1204812 - Review Request: perl-Crypt-DH-GMP - Crypt::DH Using GMP Directly
Summary: Review Request: perl-Crypt-DH-GMP - Crypt::DH Using GMP Directly
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1205121
TreeView+ depends on / blocked
 
Reported: 2015-03-23 14:27 UTC by Jitka Plesnikova
Modified: 2015-03-31 21:43 UTC (History)
2 users (show)

Fixed In Version: perl-Crypt-DH-GMP-0.00012-1.fc22
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-03-31 21:43:42 UTC
Type: ---
Embargoed:
psabata: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Jitka Plesnikova 2015-03-23 14:27:45 UTC
Spec URL: https://jplesnik.fedorapeople.org/perl-Crypt-DH-GMP/perl-Crypt-DH-GMP.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Crypt-DH-GMP/perl-Crypt-DH-GMP-0.00012-1.fc23.src.rpm
Description:
Crypt::DH::GMP is a (somewhat) portable replacement to Crypt::DH,
implemented mostly in C.

Fedora Account System Username: jplesnik

NOTE: Wrong license link mentions in lib/Crypt/DH/GMP.pm was reported to the 
upstream.

Comment 1 Petr Šabata 2015-03-24 10:23:00 UTC
A bunch of missing buildtime deps:
 - Config, inc/Module/Install/Can.pm:5, inc/Module/Install/XSUtil.pm:13
 - constant, inc/Module/Install/XSUtil.pm:18
 - ExtUtils::MM_Unix, inc/Module/Install/Metadata.pm:323, inc/Module/Install/Metadata.pm:332
 - Fcntl, inc/Module/Install/Makefile.pm:7
 - File::Spec, inc/Module/Install/XSUtil.pm:15

Optional bug recommended missing build time deps:
 - Crypt::DH, 03_compat.t:3, 04_compat-results.t:3
 - Math::BigInt::GMP, t/03_compat.t:3, t/04_compat-results.t:3
 - Net::OpenID::Consumer, 02_binhack.t:3 (not yet packaged in Fedora)

Note: Both strict and warnings are also required for build (by Module::Install::*), not just runtime; listing the dependencies under "# Run-time:" could be confusing.

Missing runtime deps:
 - XSLoader (or alternatively DynaLoader; XSLoader is preferred)

Comment 2 Jitka Plesnikova 2015-03-24 11:33:07 UTC
Updated. Links are same.

Comment 3 Petr Šabata 2015-03-24 12:18:29 UTC
Ack.

However, I see you also added a build time dependency on DynaLoader.  This isn't used when XSLoader is present (and it is, you buildrequire it as well).  Drop it before pushing.

Comment 4 Jitka Plesnikova 2015-03-24 12:41:53 UTC
New Package SCM Request
=======================
Package Name: perl-Crypt-DH-GMP
Short Description: Crypt::DH Using GMP Directly
Upstream URL: http://search.cpan.org/dist/Crypt-DH-GMP/
Owners: jplesnik ppisar psabata
Branches: f22
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2015-03-24 14:35:17 UTC
Git done (by process-git-requests).

Comment 6 Jitka Plesnikova 2015-03-24 14:55:37 UTC
Thank you for the review and the repository.

Comment 7 Fedora Update System 2015-03-24 15:27:40 UTC
perl-Crypt-DH-GMP-0.00012-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/perl-Crypt-DH-GMP-0.00012-1.fc22

Comment 8 Fedora Update System 2015-03-26 21:45:28 UTC
Package perl-Crypt-DH-GMP-0.00012-1.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing perl-Crypt-DH-GMP-0.00012-1.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-4568/perl-Crypt-DH-GMP-0.00012-1.fc22
then log in and leave karma (feedback).

Comment 9 Fedora Update System 2015-03-31 21:43:42 UTC
perl-Crypt-DH-GMP-0.00012-1.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.