1204877 – fix "delay" parameter checking

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1204877 - fix "delay" parameter checking

Summary: fix "delay" parameter checking

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	fence-virt
Sub Component:
Version:	7.2
Hardware:	Unspecified
OS:	Unspecified
Priority:	medium
Severity:	low
Target Milestone:	rc
Target Release:	---
Assignee:	Ryan McCabe
QA Contact:	cluster-qe@redhat.com
Docs Contact:
URL:
Whiteboard:
Depends On:	1204873
Blocks:
TreeView+	depends on / blocked

Reported:	2015-03-23 16:38 UTC by Ryan McCabe
Modified:	2019-03-06 01:05 UTC (History)
CC List:	7 users (show)
Fixed In Version:	fence-virt-0.3.2-3.el7
Doc Type:	Bug Fix
Doc Text:
Clone Of:	1204873
Environment:
Last Closed:	2016-11-04 07:37:10 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2016:2492	0	normal	SHIPPED_LIVE	fence-virt bug fix and enhancement update	2016-11-03 14:10:59 UTC

Description Ryan McCabe 2015-03-23 16:38:06 UTC

+++ This bug was initially created as a clone of Bug #1204873 +++

Due to copy-paste mistake, one will not ever receive a diagnostic
feedback about inapropriate value of "delay" parameter.

Patch/pull-request link to follow.

Please clone for RHEL 7 (if applicable).

--- Additional comment from Jan Pokorný on 2015-03-23 12:36:22 EDT ---

https://github.com/ClusterLabs/fence-virt/pull/4

Comment 3 Roman Bednář 2016-05-20 13:36:09 UTC

Adding QA ack. 

Test: pass a value of 0 or lower to delay parameter of fence-virt fence agent.
Expected result: feedback about inappropriate value.

Comment 5 Martin Juricek 2016-08-29 13:35:10 UTC

Marking Verified in version fence-virt-0.3.2-5.el7, invalid value of the "delay" parameter is checked and reported.



1) BEFORE fix - fence-virt-0.3.2-2.el7.x86_64
=============

# time fence_xvm -H virt-159.cluster-qe.lab.eng.brq.redhat.com -o status -w 15
Status: ON

real    0m15.054s
user    0m0.035s
sys     0m0.005s

# time fence_xvm -H virt-159.cluster-qe.lab.eng.brq.redhat.com -o monitor -w 15

real    0m15.043s
user    0m0.038s
sys     0m0.005s

# time fence_xvm -H virt-159.cluster-qe.lab.eng.brq.redhat.com -o reboot -w 15

real    0m17.820s
user    0m0.037s
sys     0m0.004s

# time fence_xvm -H virt-159.cluster-qe.lab.eng.brq.redhat.com -o reboot -w '-15'

real    0m2.833s
user    0m0.035s
sys     0m0.005s



# time fence_virt -D /dev/ttyS1 -H vm1 -o status -w 15
Status: ON

real    0m15.306s
user    0m0.000s
sys     0m0.003s

# time fence_virt -D /dev/ttyS1 -H vm1 -o monitor -w 15

real    0m15.304s
user    0m0.001s
sys     0m0.001s

# time fence_virt -D /dev/ttyS1 -H vm1 -o reboot -w 15

real    0m16.764s
user    0m0.001s
sys     0m0.002s

# time fence_virt -D /dev/ttyS1 -H vm1 -o reboot -w '-15'

real    0m1.774s
user    0m0.001s
sys     0m0.002s




2) AFTER fix - fence-virt-0.3.2-5.el7.x86_64
============

# time fence_xvm -H virt-159.cluster-qe.lab.eng.brq.redhat.com -o status -w 15
Status: ON

real    0m0.046s
user    0m0.034s
sys     0m0.006s

# time fence_xvm -H virt-159.cluster-qe.lab.eng.brq.redhat.com -o monitor -w 15

real    0m0.041s
user    0m0.037s
sys     0m0.003s

# time fence_xvm -H virt-159.cluster-qe.lab.eng.brq.redhat.com -o reboot -w 15 

real    0m17.799s
user    0m0.035s
sys     0m0.005s

# time fence_xvm -H virt-159.cluster-qe.lab.eng.brq.redhat.com -o reboot -w '-15' 
Invalid delay: '-15'
usage: fence_xvm [args]
  -d                    Specify (stdin) or increment (command line) debug level
  -i <family>           IP Family ([auto], ipv4, ipv6)                         
  -a <address>          Multicast address (default=225.0.0.12 / ff05::3:1)     
  -p <port>             TCP, Multicast, or VMChannel IP port (default=1229)    
  -r <retrans>          Multicast retransmit time (in 1/10sec; default=20)     
  -C <auth>             Authentication (none, sha1, [sha256], sha512)          
  -c <hash>             Packet hash strength (none, sha1, [sha256], sha512)    
  -k <file>             Shared key file (default=/etc/cluster/fence_xvm.key)   
  -H <domain>           Virtual Machine (domain name) to fence                 
  -u                    Treat [domain] as UUID instead of domain name. This is 
                        provided for compatibility with older fence_xvmd       
                        installations.                                         
  -o <operation>        Fencing action (null, off, on, [reboot], status, list, 
                        monitor, metadata)                                     
  -t <timeout>          Fencing timeout (in seconds; default=30)               
  -?                    Help (alternate)                                       
  -h                    Help                                                   
  -V                    Display version and exit                               
  -w <delay>            Fencing delay (in seconds; default=0)                  


real    0m0.003s
user    0m0.002s
sys     0m0.002s



# time fence_virt -D /dev/ttyS1 -H vm1 -o status -w 15
Status: ON

real    0m0.306s
user    0m0.001s
sys     0m0.002s

# time fence_virt -D /dev/ttyS1 -H vm1 -o monitor -w 15

real    0m0.304s
user    0m0.000s
sys     0m0.003s

# time fence_virt -D /dev/ttyS1 -H vm1 -o reboot -w 15

real    0m16.769s
user    0m0.000s
sys     0m0.003s

# time fence_virt -D /dev/ttyS1 -H vm1 -o reboot -w '-15'
Invalid delay: '-15'
usage: fence_virt [args]
  -d                    Specify (stdin) or increment (command line) debug level
  -D <device>           Serial device (default=/dev/ttyS1)                     
  -P <param>            Serial Parameters (default=115200,8N1)                 
  -A <address>          VM Channel IP address (default=10.0.2.179)             
  -p <port>             TCP, Multicast, or VMChannel IP port (default=1229)    
  -H <domain>           Virtual Machine (domain name) to fence                 
  -o <operation>        Fencing action (null, off, on, [reboot], status, list, 
                        monitor, metadata)                                     
  -t <timeout>          Fencing timeout (in seconds; default=30)               
  -?                    Help (alternate)                                       
  -h                    Help                                                   
  -V                    Display version and exit                               
  -T <address>          IP address to connect to in TCP mode (default=127.0.0.1
                        / ::1)                                                 
  -C <auth>             Authentication (none, sha1, [sha256], sha512)          
  -c <hash>             Packet hash strength (none, sha1, [sha256], sha512)    
  -k <file>             Shared key file (default=/etc/cluster/fence_xvm.key)   
  -w <delay>            Fencing delay (in seconds; default=0)                  


real    0m0.002s
user    0m0.001s
sys     0m0.001s

Comment 7 errata-xmlrpc 2016-11-04 07:37:10 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-2492.html

Note You need to log in before you can comment on or make changes to this bug.