Bug 1204880 – pcs: stonith level value checking

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1204880 - pcs: stonith level value checking

Summary:	pcs: stonith level value checking

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	pcs (Show other bugs)
Sub Component:
Version:	7.1
Hardware:	Unspecified Unspecified

Priority	medium Severity unspecified
Target Milestone:	rc
Target Release:	---
Assigned To:	Tomas Jelinek
QA Contact:	cluster-qe@redhat.com
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2015-03-23 12:42 EDT by Radek Steiger
Modified:	2015-11-19 04:36 EST (History)
CC List:	2 users (show)

See Also:
Fixed In Version:	pcs-0.9.140-1.el7
Doc Type:	Bug Fix
Doc Text:	Cause: User adds a fence level and specifies a non-numerical value of the level. Consequence: Pcs creates an invalid CIB, dumps it to a terminal and does not add the fence level. Fix: Verify that the fence level value is a positive integer greater than 0 as required by pacemaker. Result: An explanatory error message is displayed stating the fence level value must be a positive integer.
Story Points:	---
Clone Of:
Environment:
Last Closed:	2015-11-19 04:36:21 EST
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
proposed fix (3.34 KB, patch) 2015-05-28 09:30 EDT, Tomas Jelinek	no flags	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2015:2290	normal	SHIPPED_LIVE	Moderate: pcs security, bug fix, and enhancement update	2015-11-19 04:43:53 EST

Groups: None (edit)

Description Radek Steiger 2015-03-23 12:42:32 EDT

> Description of problem:

Pcs doesn't properly check whether the stonith level value is really numerical, as it should be by specification.


> Version-Release number of selected component (if applicable):

pcs-0.9.139-5.el6.x86_64


> How reproducible:

Always


> Steps to Reproduce:

1. pcs stonith create XVM fence_xvm
2. pcs stonith level add NotANumber host-091 XVM
3.


> Actual results:

Error: Unable to update cib
Call cib_replace failed (-203): Update does not conform to the configured schema
<...CIB dump...>


> Expected results:

Proper error message.

Comment 1 Tomas Jelinek 2015-05-28 09:30:55 EDT

Created attachment 1031292 [details]
proposed fix

Comment 2 Tomas Jelinek 2015-06-04 10:49:29 EDT

Before Fix:
[root@rh71-node1 ~]# rpm -q pcs
pcs-0.9.137-13.el7_1.2.x86_64
[root@rh71-node1:~]# rpm -q pcs
pcs-0.9.140-1.el6.x86_64
[root@rh71-node1:~]# pcs stonith
 xvmNode1       (stonith:fence_xvm):    Started rh71-node1 
 xvmNode2       (stonith:fence_xvm):    Started rh71-node2 
[root@rh71-node1:~]# pcs stonith level add NotANumber rh71-node1 xvmNode1
Error: Unable to update cib
Call cib_replace failed (-203): Update does not conform to the configured schema
...



After Fix:
[root@rh71-node1:~]# rpm -q pcs
pcs-0.9.140-1.el6.x86_64
[root@rh71-node1:~]# pcs stonith
 xvmNode1       (stonith:fence_xvm):    Started rh71-node1 
 xvmNode2       (stonith:fence_xvm):    Started rh71-node2 
[root@rh71-node1:~]# pcs stonith level add NotANumber rh71-node1 xvmNode1
Error: invalid level 'NotANumber', use a positive integer
[root@rh71-node1:~]# echo $?
1

Works in web UI as well.

Comment 6 errata-xmlrpc 2015-11-19 04:36:21 EST

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-2290.html

Note You need to log in before you can comment on or make changes to this bug.