Note: This bug is displayed in read-only format because
the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Description of problem:
Kernel goes into a busy loop when it waits for more data in a recv(MSG_PEEK|MSG_WAITALL) call.
E.g.
------
#include <stdlib.h>
#include <netinet/ip.h>
int main(void)
{
struct sockaddr_in addr = {
.sin_family = AF_INET,
.sin_port = htons(1234),
.sin_addr = { INADDR_ANY }
};
int conn;
char buf[16];
int s = socket(AF_INET, SOCK_STREAM, 0);
bind(s, (void *)&addr, sizeof addr);
listen(s, 1);
conn = accept(s, NULL, 0);
recv(conn, buf, sizeof buf, MSG_PEEK|MSG_WAITALL);
}
----
$ gcc x.c
$ a.out &
$ nc 127.0.0.1 1234
1234<enter>
--> 'a.out' consumes 100% CPU
'a.out' stays alive and consumes CPU when the 'nc' connection is closed unclean (e.g. no TCP FIN/RST). This can be used for DDOS attacks.
Version-Release number of selected component (if applicable):
kernel-3.10.0-123.20.1.el7.x86_64
How reproducible:
100%
Upstream kernel behaves the same. MSG_WAITALL tells kernel to wait until whole buffer can be filled. Looks like the combination with MSG_PEEK is not handled properly in tcp_recvmsg:
if (copied >= target) {
/* Do not sleep, just process backlog. */
release_sock(sk);
lock_sock(sk);
} else
sk_wait_data(sk, &timeo);
In case both MSG_PEEK and MSG_WAITALL are there, sk_wait_data is not called.
Comment 3Hannes Frederic Sowa
2015-04-13 12:08:45 UTC
lock_sock (the only lock taken at that moment) is preemptible in process context, so it should not lead to a DoS situation. Albeit maybe we can do better and handle the situation where both flags are set more intelligent?
Hi, thanks for the update.
Will this patch go into the 3.13.0 kernel branch? I'm hoping to get Ubuntu to suck it into their LTS kernel packages which seem to be built from the 3.13.0 branch.
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.
https://rhn.redhat.com/errata/RHSA-2015-2152.html
Description of problem: Kernel goes into a busy loop when it waits for more data in a recv(MSG_PEEK|MSG_WAITALL) call. E.g. ------ #include <stdlib.h> #include <netinet/ip.h> int main(void) { struct sockaddr_in addr = { .sin_family = AF_INET, .sin_port = htons(1234), .sin_addr = { INADDR_ANY } }; int conn; char buf[16]; int s = socket(AF_INET, SOCK_STREAM, 0); bind(s, (void *)&addr, sizeof addr); listen(s, 1); conn = accept(s, NULL, 0); recv(conn, buf, sizeof buf, MSG_PEEK|MSG_WAITALL); } ---- $ gcc x.c $ a.out & $ nc 127.0.0.1 1234 1234<enter> --> 'a.out' consumes 100% CPU 'a.out' stays alive and consumes CPU when the 'nc' connection is closed unclean (e.g. no TCP FIN/RST). This can be used for DDOS attacks. Version-Release number of selected component (if applicable): kernel-3.10.0-123.20.1.el7.x86_64 How reproducible: 100%