Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
Bug 1205402 - Paginator has infinite pages
Paginator has infinite pages
Status: CLOSED ERRATA
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS (Show other bugs)
5.4.0
Unspecified Unspecified
medium Severity low
: GA
: 5.5.0
Assigned To: Martin Hradil
Kyrylo Zvyagintsev
: ZStream
Depends On:
Blocks: 1244715
  Show dependency treegraph
 
Reported: 2015-03-24 17:01 EDT by Sean Myers
Modified: 2015-12-08 08:04 EST (History)
6 users (show)

See Also:
Fixed In Version: 5.5.0.1
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1244715 (view as bug list)
Environment:
Last Closed: 2015-12-08 08:04:15 EST
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Too many pages (102.41 KB, image/png)
2015-03-24 17:01 EDT, Sean Myers
no flags Details


External Trackers
Tracker ID Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2015:2551 normal SHIPPED_LIVE Moderate: CFME 5.5.0 bug fixes and enhancement update 2015-12-08 12:58:09 EST

  None (edit)
Description Sean Myers 2015-03-24 17:01:04 EDT
Created attachment 1005997 [details]
Too many pages

Description of problem:
Paginator never ends


Version-Release number of selected component (if applicable):
5.4.0.0.13


How reproducible:
Always


Steps to Reproduce:
log in (admin)
nav to Intelligence > Reports > Reports (accordion) > Configuration (button) > Add a new Report

Form:
  Name/Title: Test
  Base the report on: EVM Groups
  Add "EVM Unique ID (Guid)" to Selected Fields
  Click Add

Select the report, hit the "Queue" button, wait for the report to be generated.
There are a couple of ways to do this, I suggest renavigating to Intelligence > Reports until "Generating Report" turns into a timestamped report.

Once generated, navigate to the report. There should be 12 rows; set the paginator to 5.
Click next.
Keep clicking next.
Stop when the paginator is obviously broken, e.g. displaying "(Rows 16-12 of 12)"

Actual results:
Paginator never greys out "Next"/"Last" buttons

Expected results:
Shouldn't be able to go past the last page.


Additional info:
I found our QE automation in an endless loop, as it was searching the report table for something that it couldn't find, and iterating over the paginator pages expecting to eventually reach the end.

I don't know if other paginators are similarly affected. Nothing interesting happens in the log files, everything is 200 OK with or without data to display for a requested page.
Comment 3 CFME Bot 2015-06-04 19:21:13 EDT
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/d7398c451d835991e847147f1835c98b41662204

commit d7398c451d835991e847147f1835c98b41662204
Author:     Martin Hradil <mhradil@redhat.com>
AuthorDate: Tue May 19 14:08:10 2015 +0000
Commit:     Martin Hradil <mhradil@redhat.com>
CommitDate: Tue May 19 14:08:10 2015 +0000

    Revert "Disable next and last pagination buttons when all the report data is on a single page"
    
    This reverts commit a3eec765bd0a2f0df9e9c81f01efe419aefc9e75.
    
    The original commit was to fix bz1182360, but this lead to infinite number of pages.
    The underlying issue (bz1182360) has apparently been fixed in the meantime (could not reproduce), so this is no longer necessary.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1205402

 vmdb/app/views/layouts/_saved_report_paging_bar.html.haml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 CFME Bot 2015-07-23 11:32:33 EDT
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=577bad373a302f3760f1d935f1ce5f7ce2284bd6

commit 577bad373a302f3760f1d935f1ce5f7ce2284bd6
Merge: 47fd64a 4eff2f1
Author:     Dan Clarizio <dclarizi@redhat.com>
AuthorDate: Thu Jul 23 11:26:29 2015 -0400
Commit:     Dan Clarizio <dclarizi@redhat.com>
CommitDate: Thu Jul 23 11:26:29 2015 -0400

    Merge branch 'bz1205402' into '5.4.z'
    
    Revert "Disable next and last pagination buttons when all the report data is on a single page"
    
    This reverts commit a3eec765bd0a2f0df9e9c81f01efe419aefc9e75.
    
    The original commit was to fix bz1182360, but this lead to infinite number of pages.
    The underlying issue (bz1182360) has apparently been fixed in the meantime (could not reproduce), so this is no longer necessary.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1205402
    (cherry picked from commit d7398c451d835991e847147f1835c98b41662204)
    
    See merge request !189

 vmdb/app/views/layouts/_saved_report_paging_bar.html.haml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 CFME Bot 2015-07-23 11:32:45 EDT
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=4eff2f191cf879d3a28d60815b97b166d2955b91

commit 4eff2f191cf879d3a28d60815b97b166d2955b91
Author:     Martin Hradil <mhradil@redhat.com>
AuthorDate: Tue May 19 14:08:10 2015 +0000
Commit:     Martin Hradil <mhradil@redhat.com>
CommitDate: Mon Jul 20 10:45:08 2015 +0000

    Revert "Disable next and last pagination buttons when all the report data is on a single page"
    
    This reverts commit a3eec765bd0a2f0df9e9c81f01efe419aefc9e75.
    
    The original commit was to fix bz1182360, but this lead to infinite number of pages.
    The underlying issue (bz1182360) has apparently been fixed in the meantime (could not reproduce), so this is no longer necessary.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1205402
    (cherry picked from commit d7398c451d835991e847147f1835c98b41662204)

 vmdb/app/views/layouts/_saved_report_paging_bar.html.haml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 6 Kyrylo Zvyagintsev 2015-10-01 11:41:45 EDT
Verified fixed in version 5.5.0.3:
Check this bug using steps represented in description. Besides check additional cases with different number of items per page
Comment 8 errata-xmlrpc 2015-12-08 08:04:15 EST
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2015:2551

Note You need to log in before you can comment on or make changes to this bug.