Spec URL: https://flepied.fedorapeople.org/edeploy.spec SRPM URL: https://flepied.fedorapeople.org/edeploy-1.8.0-1.fc23.src.rpm Description: eDeploy is a tool to provision and update systems (physical or virtual) using trees of files instead of packages or VM images. Fedora Account System Username: flepied
1. doesn't build due to missing BuildRequires: python-sphinx 2. if you use %autosetup, you don't need to use %patch as the former will apply it for you. I suggest using -S git option as it allows you to manage your patches with git (the standard for RDO btw) 3.use %{_sharedstatedir} instead of /var/lib 4. according guidelines, you shouldn't deploy web applications into /var/www but %{_datadir}/%{name} 5. sources shouldn't be put in /usr/src (non-standard), are they required ? If they're not, I'd suggest to drop them. 6.missing Requires: python-netaddr, python-pexpect
(In reply to Haïkel Guémar from comment #1) > 1. doesn't build due to missing BuildRequires: python-sphinx > 2. if you use %autosetup, you don't need to use %patch as the former will > apply it for you. I suggest using -S git option as it allows you to manage > your patches with git (the standard for RDO btw) > 3.use %{_sharedstatedir} instead of /var/lib > 4. according guidelines, you shouldn't deploy web applications into /var/www > but %{_datadir}/%{name} > 5. sources shouldn't be put in /usr/src (non-standard), are they required ? > If they're not, I'd suggest to drop them. > 6.missing Requires: python-netaddr, python-pexpect Thanks for the review, Haïkel ! I adapted the packaging according to your comments. Could you take a look again ? Thanks, Fred
Updated to version 1.9.0: Spec URL: https://flepied.fedorapeople.org/edeploy.spec SRPM URL: https://flepied.fedorapeople.org/edeploy-1.9.0-1.fc23.src.rpm
Updated to version 1.10.0: Spec URL: https://flepied.fedorapeople.org/edeploy.spec SRPM URL: https://flepied.fedorapeople.org/edeploy-1.10.0-1.fc23.src.rpm
Updated to version 1.11.0: Spec URL: https://flepied.fedorapeople.org/edeploy.spec SRPM URL: https://flepied.fedorapeople.org/edeploy-1.11.0-1.fc23.src.rpm
So, a few notes: 1) %{_sharedstatedir}/edeploy/ seems to be unowned 2) I prefer to have 1 requires on each line ( easier to see with diff, but just a personal preference, given for the pleasure of being pedantic as I promised to be ) 3) no need for BuildArch: noarch on the -devel package, that's redundant with the main rpm. 4) there is no file who details the license in a %license, please add it. 5) %{_datadir}/%{name} is unowned 6) %attr(0644, apache, apache) %{_sharedstatedir}/edeploy/*.cmdb this would requires a user apache on the system, and it is created by another rpm, which in turn should be required, if I am not wrong. I also suspect this might requires some selinux policy change, but that's outside of this review and package. In fact, if the files can be modified by apache, they should be marked as %ghost or something, and if they can't, then they shouldn't belong to apache, no ? Could you clarify that part ? 7) any reason to not run the tests in %check ( since there is tox.ini ) ? if so, I think we should have a comment in the rpm saying why they are not enabled, and if we can run, then run them. I might have others stuff to see once I look more on the policy for web application, and dig a bit more in the source code.
I created a version version 1.11.0-2 to address your concerns: Spec URL: https://flepied.fedorapeople.org/edeploy.spec SRPM URL: https://flepied.fedorapeople.org/edeploy-1.11.0-2.fc23.src.rpm The only point I haven't addressed is 7 as I cannot add a %check section because bash8 is not packaged and is used by the tests.
1. Drop PreReq tag, guidelines advise against it 2. Drop Group tags, it's not used anymore 3. Doc is large enough to be in its own subpackage 4. BR: python2-devel 5. you enable %check as I submitted python-bash8 (as enabling tests in packages builds will be a goal for Liberty, I will have to submit it anyway) https://bugzilla.redhat.com/show_bug.cgi?id=1224513
I created a version 1.11.0-4 to address your concerns: Spec URL: https://flepied.fedorapeople.org/edeploy.spec SRPM URL: https://flepied.fedorapeople.org/edeploy-1.11.0-4.fc23.src.rpm Please don't block on non available package. I have added a %check section and I'll activate the bash8 script later when bash8 will be available.
pbrobinson's scratch build of linux-user-chroot?#b7afe5173cbd31b029b027b6f8a14baa5e6ce87a for epel7-archbootstrap and git://pkgs.fedoraproject.org/linux-user-chroot?#b7afe5173cbd31b029b027b6f8a14baa5e6ce87a failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12089939