Bug 1206101 - __init()__ got an unexpected keyword argument 'min_luks_entropy'
Summary: __init()__ got an unexpected keyword argument 'min_luks_entropy'
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: 21
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: David Shea
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-03-26 10:19 UTC by Fabrice Robin
Modified: 2015-04-06 18:48 UTC (History)
5 users (show)

Fixed In Version: python-blivet-1.0.6-1.fc22
Clone Of:
Environment:
Last Closed: 2015-04-06 18:48:28 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Anaconda logs (92.87 KB, application/x-gzip)
2015-03-27 13:13 UTC, Fabrice Robin
no flags Details

Description Fabrice Robin 2015-03-26 10:19:07 UTC
Description of problem:
We are trying to write kickstart file which will allow to reinstall a machine
keeping /home partition which are encrypted.

Version-Release number of selected component (if applicable):
anaconda 21.48.21-1

How reproducible:
Always

Steps to Reproduce:
1. Define a kickstart with manual partitioning to be able to keep existing encrypted /home partition:
...
logvol /home  --fstype="ext4" --noformat --useexisting --encrypted --passphrase=xxxx --name=home --vgname=fedora-server_xxxx
...
2. Launch an install with this kickstart file
3.

Actual results:
Anaconda installation ends with an exception:
anaconda 21.48.21-1 exception report
Traceback (most recent call first):
  File "/usr/lib64/python2.7/site-packages/pyanaconda/kickstart.py", line 1029, in execute
    min_luks_entropy=MIN_CREATE_ENTROPY)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/kickstart.py", line 803, in execute
    l.execute(storage, ksdata, instClass)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/kickstart.py", line 2013, in doKickstartStorage
    ksdata.logvol.execute(storage, ksdata, instClass)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/spokes/storage.py", line 313, in _doExecute
    doKickstartStorage(self.storage, self.data, self.instclass)
  File "/usr/lib64/python2.7/threading.py", line 766, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/threads.py", line 227, in run
    threading.Thread.run(self, *args, **kwargs)
TypeError: __init__() got an unexpected keyword argument 'min_luks_entropy'

Expected results:


Additional info:
Looking at anaconda sources (kickstart.py line 1029 in F21-branch), we can see that a "min_luks_entropy" argument is used to create a LUKSDevice instance.
Problem is that this argument is unexpected for a LUKSDevice.
I think that this argument should have been used in the previous "getFormat" call and therefore the code should be:
...
            if self.preexist:
                luksformat = fmt
                device.format = getFormat("luks", passphrase=self.passphrase, device=device.path,
                                          cipher=self.cipher,
                                          escrow_cert=cert,
                                          add_backup_passphrase=self.backuppassphrase,
                                          min_luks_entropy=MIN_CREATE_ENTROPY)
                luksdev = LUKSDevice("luks%d" % storage.nextID,
                                     fmt=luksformat,
                                     parents=device)
...

Comment 1 David Shea 2015-03-27 11:53:16 UTC
Please attach the log files from /tmp at the time of the crash as individual, text/plain attachments. In particular, there should be a file named anaconda-tb-* containing the full traceback information

Comment 2 Fabrice Robin 2015-03-27 13:13:03 UTC
Created attachment 1007246 [details]
Anaconda logs

Anaconda logs. Anonymized.

Comment 3 Fedora Update System 2015-04-02 18:25:41 UTC
anaconda-22.20.8-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/anaconda-22.20.8-1.fc22

Comment 4 Fedora Update System 2015-04-04 16:32:25 UTC
Package python-blivet-1.0.6-1.fc22, anaconda-22.20.8-1.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing python-blivet-1.0.6-1.fc22 anaconda-22.20.8-1.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-5530/python-blivet-1.0.6-1.fc22,anaconda-22.20.8-1.fc22
then log in and leave karma (feedback).

Comment 5 Fedora Update System 2015-04-06 18:48:28 UTC
python-blivet-1.0.6-1.fc22, anaconda-22.20.8-1.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.