Bug 1206898 - Drop the virtual provides aspell-pt
Summary: Drop the virtual provides aspell-pt
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: aspell-pt_BR
Version: 22
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nikola Forró
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-03-29 12:43 UTC by Parag Nemade
Modified: 2015-07-18 02:06 UTC (History)
2 users (show)

Fixed In Version: aspell-pt_BR-20090702-8.fc22
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-07-18 02:06:07 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Parag Nemade 2015-03-29 12:43:05 UTC
Description of problem:
The aspell packages are not actively used in Fedora but I do have langpacks plugin which shows available packages for the given language. I am working on enhancing dnf-langpacks plugin which now will start giving output for "dnf langinfo pt_PT" or "dnf langinfo pt" as one of the package aspell-pt_BR which is wrong. It should show only aspell-pt

Hence proposing to drop the virtual provides aspell-pt from aspell-pt_BR package.

I can do this in next 3 days. If there is any questions for this please ask here else will commit this after 3 days in all fedora branches.

Comment 1 Jan Chaloupka 2015-04-01 10:23:23 UTC
Description says: Provides the word list/dictionaries for the following: Brazilian Portuguese. Why it should not display aspell-pt_BR as well?

Comment 2 Parag Nemade 2015-04-01 11:18:49 UTC
I want to know why packages aspell-pt_PT and aspell-pt_BR should provide aspell-pt? Generally aspell-pt_PT is mapped to aspell-pt but why aspell-pt_BR should be mapped to aspell-pt?

There is no i18n locale for pt available but only for pt_BR and pt_PT. Also for l10n just see most translations for pt_PT locale are in /usr/share/locale/pt_PT/LC_MESSAGES/ directory along with /usr/share/locale/pt/LC_MESSAGES/

Then we have translations for pt_BR only in /usr/share/locale/pt_BR/LC_MESSAGES/

So there is clear differentiation between pt/pt_PT and pt_BR.

Comment 3 Parag Nemade 2015-04-01 12:17:48 UTC
Basically I am requesting this
------------------------
diff --git a/aspell-pt_BR.spec b/aspell-pt_BR.spec
index b3fc71d..7f28881 100644
--- a/aspell-pt_BR.spec
+++ b/aspell-pt_BR.spec
@@ -12,7 +12,6 @@ Source: ftp://ftp.gnu.org/gnu/aspell/dict/%{lang}/aspell6-%{lang}-%{version}-%{l
 Buildrequires: aspell >= 12:0.60
 Requires: aspell >= 12:0.60
 Obsoletes: aspell-pt <= 50:0.50
-Provides: aspell-pt = %{epoch}:%{version}
 
 %define debug_package %{nil}
 
---------------------------------------

Comment 4 Parag Nemade 2015-04-04 09:03:26 UTC
Jan,
   May I know if you still have a concern for not to make above change in spec file?

Comment 5 Jan Chaloupka 2015-04-06 12:07:10 UTC
Parag,

looking at aspell-pt package itself (which is dead package), its description says:
Provides the word list/dictionaries for the following: European Portuguese,
-Brazilian Portuguese

> I want to know why packages aspell-pt_PT and aspell-pt_BR should
> provide aspell-pt? Generally aspell-pt_PT is mapped to aspell-pt
> but why aspell-pt_BR should be mapped to aspell-pt?

So IMHO aspell-pt was decomposed into two packages, aspell-pt_PT and aspell-pt_BR which is the reason why both packages provides aspell-pt. Thus we should not drop the virtual provide. 

> There is no i18n locale for pt available but only for pt_BR and pt_PT.

Yes as aspell-pt is gone.

> Also for l10n just see most translations for pt_PT locale are in
> /usr/share/locale/pt_PT/LC_MESSAGES/ directory along with
> /usr/share/locale/pt/LC_MESSAGES/
> Then we have translations for pt_BR only in
> /usr/share/locale/pt_BR/LC_MESSAGES/

I am not sure but maybe European Portuguese is much closer to Portuguese than Brazilian Portuguese? I don't know the precise distinction.

Parag, what do you think? Is removing the virtual provide the only solution?

Comment 6 Parag Nemade 2015-04-06 14:32:03 UTC
As per policy https://fedoraproject.org/wiki/Upgrade_paths_%E2%80%94_renaming_or_splitting_packages#Do_I_need_to_Provide_my_old_package_names.3F page, I suppose when aspell-pt was split into aspell-pt_PT and aspell-pt_BR, both packages got added "Provides: aspell-pt" to make sure any other depending packages to work fine with aspell-pt package name.

I don't remember when this split happened but what I can think is that might be that time openoffice.org was using that name and that can be one reason for providing that name. But later in FC9 development cycle we moved to using hunspell packages.

Also, that policy page clearly says to clean up old Provides and Obsoletes after next two Fedora releases.

Comment 7 Jan Chaloupka 2015-04-08 18:07:40 UTC
Fair enough. What about to change

-Provides: aspell-pt = %{epoch}:%{version}
+Provides: aspell-pt_BR = %{epoch}:%{version}

?

Comment 8 Parag Nemade 2015-04-08 18:12:08 UTC
Generally a package's "n=e-v-r" gets automatically provided by rpm. See existing aspell-pt_BR provides -> http://koji.fedoraproject.org/koji/rpminfo?rpmID=5369419

So, no need for above proposed change in comment#7

Comment 9 Fedora Update System 2015-04-08 18:33:10 UTC
aspell-pt_BR-20090702-8.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/aspell-pt_BR-20090702-8.fc22

Comment 10 Fedora Update System 2015-04-09 16:46:10 UTC
Package aspell-pt_BR-20090702-8.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing aspell-pt_BR-20090702-8.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-5903/aspell-pt_BR-20090702-8.fc22
then log in and leave karma (feedback).

Comment 11 Fedora Admin XMLRPC Client 2015-07-13 12:06:53 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 12 Fedora Update System 2015-07-18 02:06:07 UTC
aspell-pt_BR-20090702-8.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.