Spec URL: https://msrb.fedorapeople.org/review/groovy-sandbox.spec SRPM URL: https://msrb.fedorapeople.org/review/groovy-sandbox-1.8-1.fc23.src.rpm Description: This project defines a Groovy CompilationCustomizer, which allows a program to execute Groovy script in a restricted sandbox environment. It is useful for applications that want to provide some degree of scriptability to users, without allowing them to execute System.exit(0) or any other undesirable operations. This compile-time transformation modifies untrusted Groovy script in such a way that every operation that can cause interactions with the external world gets intercepted. This allows your code to examine and deny executions. This includes every method call, object allocations, property/attribute access, array access, and so on. Fedora Account System Username: msrb
you could use antrun plugin to compile files groovy e.g. <plugin> <artifactId>maven-antrun-plugin</artifactId> <version>1.4</version> <dependencies> <dependency> <groupId>org.codehaus.groovy</groupId> <artifactId>groovy</artifactId> <version>1.8.9</version> </dependency> <dependency> <groupId>antlr</groupId> <artifactId>antlr</artifactId> <version>any</version> </dependency> <dependency> <groupId>commons-cli</groupId> <artifactId>commons-cli</artifactId> <version>any</version> </dependency> <dependency> <groupId>asm</groupId> <artifactId>asm-all</artifactId> <version>3.3.1</version> </dependency> <dependency> <groupId>org.slf4j</groupId> <artifactId>slf4j-nop</artifactId> <version>any</version> </dependency> </dependencies> <executions> <execution> <id>compile</id> <phase>process-sources</phase> <configuration> <target> <mkdir dir="${basedir}/target/classes"/> <taskdef name="groovyc" classname="org.codehaus.groovy.ant.Groovyc"> <classpath refid="maven.plugin.classpath"/> </taskdef> <groovyc destdir="${project.build.outputDirectory}" srcdir="${basedir}/src/main" classpathref="maven.compile.classpath"> <javac source="1.6" target="1.6" debug="on"/> </groovyc> </target> </configuration> <goals> <goal>run</goal> </goals> </execution> </executions> </plugin>
need asm-all-distroshaded
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find LICENSE.md in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text IGNORE, is available ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 17 files have unknown license. Detailed output of licensecheck in /home/gil/1207116-groovy-sandbox/review-groovy- sandbox/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/licenses, /usr/share/maven-metadata [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/licenses, /usr/share /maven-metadata [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: Using prebuilt rpms. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in groovy- sandbox-javadoc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: groovy-sandbox-1.8-1.fc23.noarch.rpm groovy-sandbox-javadoc-1.8-1.fc23.noarch.rpm groovy-sandbox-1.8-1.fc23.src.rpm groovy-sandbox.noarch: W: spelling-error Summary(en_US) untrusted -> entrusted, trusted, encrusted groovy-sandbox.noarch: W: spelling-error %description -l en_US scriptability -> script ability, script-ability, inscrutability groovy-sandbox.noarch: W: spelling-error %description -l en_US untrusted -> entrusted, trusted, encrusted groovy-sandbox.noarch: W: no-documentation groovy-sandbox.src: W: spelling-error Summary(en_US) untrusted -> entrusted, trusted, encrusted groovy-sandbox.src: W: spelling-error %description -l en_US scriptability -> script ability, script-ability, inscrutability groovy-sandbox.src: W: spelling-error %description -l en_US untrusted -> entrusted, trusted, encrusted groovy-sandbox.src: W: invalid-url Source0: https://github.com/kohsuke/groovy-sandbox/archive/groovy-sandbox-1.8.tar.gz <urlopen error timed out> 3 packages and 0 specfiles checked; 0 errors, 8 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- groovy-sandbox (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(org.codehaus.groovy:groovy) groovy-sandbox-javadoc (rpmlib, GLIBC filtered): jpackage-utils Provides -------- groovy-sandbox: groovy-sandbox mvn(org.kohsuke:groovy-sandbox) mvn(org.kohsuke:groovy-sandbox:pom:) groovy-sandbox-javadoc: groovy-sandbox-javadoc Source checksums ---------------- https://github.com/kohsuke/groovy-sandbox/archive/groovy-sandbox-1.8.tar.gz : CHECKSUM(SHA256) this package : 4f8e963e0c167c5ee1fbf11fc4ec80595386951fc1c4a9933a0f66302efe4308 CHECKSUM(SHA256) upstream package : 4f8e963e0c167c5ee1fbf11fc4ec80595386951fc1c4a9933a0f66302efe4308 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -vpn groovy-sandbox -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Thanks! New Package SCM Request ======================= Package Name: groovy-sandbox Short Description: Groovy sandbox for executing untrusted Groovy scripts safely Upstream URL: http://groovy-sandbox.kohsuke.org Owners: msrb mizdebsk msimacek Branches: f21 f22 InitialCC: java-sig
Git done (by process-git-requests).