Bug 1207178 - fedpkg hangs when the certificate is expired
Summary: fedpkg hangs when the certificate is expired
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: fedpkg
Version: 21
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Pavol Babinčák
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1213454 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-03-30 11:49 UTC by Jan Synacek
Modified: 2015-12-02 17:48 UTC (History)
9 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-12-02 10:40:08 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Get logs from koji to fedpkg (794 bytes, patch)
2015-04-14 08:08 UTC, Pavol Babinčák
no flags Details | Diff

Description Jan Synacek 2015-03-30 11:49:00 UTC
Description of problem:
fedpkg hangs when the certificate is expired. I can't see any warning or anything that might indicate what the problem might be and where.


Version-Release number of selected component (if applicable):
fedpkg-1.19-1.fc21.noarch


Steps to Reproduce:
1. Have an expired certificate that is commonly acquired by 'fedora-cert'
2. cd to a package directory
3. $ fedpkg build 


Actual results:
fedpkg hangs with absolutely zero output. fedpkg -v doesn't show anything either.


Expected results:
At least issue a warning about an invalid certificate and don't hang.

Comment 1 Pavol Babinčák 2015-04-14 08:08:18 UTC
Created attachment 1014186 [details]
Get logs from koji to fedpkg

This is partial patch and not very well tested.

Comment 2 Pavol Babinčák 2015-04-14 08:09:52 UTC
Just couple of notes why this happens:
- fedpkg (via rpkg) uses koji lib to authenticate against Koji buildsystem.
- if client certificate is expired, koji logs the error and retries sslLogin call with current settings 30 times with 20 seconds sleep interval.

Problem is that fedpkg doesn't hook on koji's logger so it doesn't print any error.

Solution might be to connect koji's logger to fedpkg (rpkg) one. Which works in this case but it might print quite a lot of messages in other cases.

Another partial solution might be to test client certificate with other call which doesn't have these retries. Logoff call in koji uses this approach.

I don't have tested solution yet.

Comment 3 Pavol Babinčák 2015-04-21 06:58:21 UTC
*** Bug 1213454 has been marked as a duplicate of this bug. ***

Comment 4 Kamil Dudka 2015-05-26 08:51:57 UTC
This bug still exists in fedpkg-1.20-1.fc22.noarch.

Comment 5 Mathieu Bridon 2015-06-29 08:46:50 UTC
This is a bug in Koji, not in fedpkg:

https://lists.fedoraproject.org/pipermail/buildsys/2015-June/004799.html

Comment 6 Mosaab Alzoubi 2015-07-13 17:28:32 UTC
Don't work !!  http://i.imgur.com/9mjEC8a.png

Comment 7 Mathieu Bridon 2015-07-13 18:15:02 UTC
@Mosaab: your problem has nothing to do with this bug, as Koji isn't queried at all when cloning a package.

Please open a new bug report for it.

Comment 8 Mosaab Alzoubi 2015-07-13 19:53:36 UTC
I think they related , anyway I wrote new one : Bug 1242625

Comment 9 Fedora End Of Life 2015-11-04 15:26:58 UTC
This message is a reminder that Fedora 21 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 21. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '21'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 21 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 10 Fedora End Of Life 2015-12-02 10:40:14 UTC
Fedora 21 changed to end-of-life (EOL) status on 2015-12-01. Fedora 21 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.