Bug 1207280 - Review Request: python-semantic_version - A library implementing the 'SemVer' scheme
Summary: Review Request: python-semantic_version - A library implementing the 'SemVer'...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Alan Pevec (Fedora)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1077030 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-03-30 15:29 UTC by Haïkel Guémar
Modified: 2015-08-08 20:03 UTC (History)
4 users (show)

Fixed In Version: python-semantic_version-2.4.2-1.el7
Clone Of:
Environment:
Last Closed: 2015-07-18 02:00:03 UTC
Type: ---
Embargoed:
apevec: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Haïkel Guémar 2015-03-30 15:29:10 UTC
Spec URL: https://hguemar.fedorapeople.org/reviews/python-semantic_version.spec
SRPM URL: https://hguemar.fedorapeople.org/reviews/python-semantic_version-2.3.1-1.fc22.src.rpm
Description: This small library handle semantic versioning in Python
Fedora Account System Username:hguemar

Comment 1 Alan Pevec (Fedora) 2015-03-30 22:47:55 UTC
Please include Provides: python-semantic-version for compatibility with https://review.gerrithub.io/#/c/228901/2/openstack-glance.spec@87

Comment 2 Haïkel Guémar 2015-03-31 08:33:16 UTC
Added the provides: spec & SRPM updated

Comment 3 Chandan Kumar 2015-04-01 02:52:46 UTC
New version of the python-semantic-version is available: https://pypi.python.org/pypi/semantic_version/2.4.1
- doc/credits.rst file fixed
- LICENSE included in the pip tarball

Please update the spec file and sprm.

Comment 5 Alan Pevec (Fedora) 2015-05-28 17:28:16 UTC
Sorry for the massive delay :(

APPROVED

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
     NOTE there's compatiblity Provides for compatibility with early packaging
     in RDO Delorean
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
     * spelling-error is false positive
     * encoding: it's generated javascript, ignore
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python-semantic_version-2.4.1-1.fc23.noarch.rpm
          python-semantic_version-doc-2.4.1-1.fc23.noarch.rpm
          python-semantic_version-2.4.1-1.fc23.src.rpm
python-semantic_version.noarch: W: spelling-error %description -l en_US versioning -> versifying, version, overseeing
python-semantic_version-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-semantic_version-doc/html/_static/jquery.js
python-semantic_version.src: W: spelling-error %description -l en_US versioning -> versifying, version, overseeing
python-semantic_version.src:17: W: unversioned-explicit-provides python-semantic-version
3 packages and 0 specfiles checked; 0 errors, 4 warnings.




Rpmlint (installed packages)
----------------------------
python-semantic_version-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-semantic_version-doc/html/_static/jquery.js
python-semantic_version.noarch: W: spelling-error %description -l en_US versioning -> versifying, version, overseeing
2 packages and 0 specfiles checked; 0 errors, 2 warnings.



Requires
--------
python-semantic_version-doc (rpmlib, GLIBC filtered):

python-semantic_version (rpmlib, GLIBC filtered):
    python(abi)



Provides
--------
python-semantic_version-doc:
    python-semantic_version-doc

python-semantic_version:
    python-semantic-version
    python-semantic_version



Source checksums
----------------
https://pypi.python.org/packages/source/s/semantic_version/semantic_version-2.4.1.tar.gz :
  CHECKSUM(SHA256) this package     : 33018ab2807ba395c418b4633993a7572b8a4b3e924823f5828788023b3c9b30
  CHECKSUM(SHA256) upstream package : 33018ab2807ba395c418b4633993a7572b8a4b3e924823f5828788023b3c9b30


Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1207280
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 6 Haïkel Guémar 2015-05-28 18:50:15 UTC
New Package SCM Request
=======================
Package Name: python-semantic_version
Short Description: A library implementing the 'SemVer' scheme 
Upstream URL: https://github.com/rbarrois/python-semanticversion
Owners: hguemar apevec
Branches: f21 f22 epel7
InitialCC:

Comment 7 Gwyn Ciesla 2015-05-28 19:39:43 UTC
Git done (by process-git-requests).

Comment 8 Fedora Update System 2015-06-01 15:35:52 UTC
python-semantic_version-2.4.1-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/python-semantic_version-2.4.1-1.fc22

Comment 9 Fedora Update System 2015-06-01 15:54:17 UTC
python-semantic_version-2.4.1-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/python-semantic_version-2.4.1-1.fc21

Comment 10 Fedora Update System 2015-06-01 16:07:35 UTC
python-semantic_version-2.4.1-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/python-semantic_version-2.4.1-1.el7

Comment 11 Fedora Update System 2015-06-02 15:14:50 UTC
python-semantic_version-2.4.1-1.fc22 has been pushed to the Fedora 22 testing repository.

Comment 12 Fedora Update System 2015-07-03 18:04:49 UTC
python-semantic_version-2.4.2-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/python-semantic_version-2.4.2-1.fc22

Comment 13 Fedora Update System 2015-07-03 18:15:42 UTC
python-semantic_version-2.4.2-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/python-semantic_version-2.4.2-1.fc21

Comment 14 Fedora Update System 2015-07-03 18:20:31 UTC
python-semantic_version-2.4.2-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/python-semantic_version-2.4.2-1.el7

Comment 15 Fedora Update System 2015-07-18 02:00:03 UTC
python-semantic_version-2.4.2-1.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2015-07-18 02:08:30 UTC
python-semantic_version-2.4.2-1.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 17 Christopher Meng 2015-07-22 01:45:37 UTC
*** Bug 1077030 has been marked as a duplicate of this bug. ***

Comment 18 Fedora Update System 2015-08-08 20:03:30 UTC
python-semantic_version-2.4.2-1.el7 has been pushed to the Fedora EPEL 7 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.