Bug 1207532 - BitRot :- gluster volume help gives insufficient and ambiguous information for bitrot
Summary: BitRot :- gluster volume help gives insufficient and ambiguous information fo...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: bitrot
Version: mainline
Hardware: x86_64
OS: Linux
urgent
urgent
Target Milestone: ---
Assignee: Satish Mohan
QA Contact:
bugs@gluster.org
URL:
Whiteboard:
: 1215033 (view as bug list)
Depends On:
Blocks: qe_tracker_everglades
TreeView+ depends on / blocked
 
Reported: 2015-03-31 06:47 UTC by Rachana Patel
Modified: 2016-06-16 12:45 UTC (History)
6 users (show)

Fixed In Version: glusterfs-3.8rc2
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-06-16 12:45:56 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Rachana Patel 2015-03-31 06:47:05 UTC
Description of problem:
=======================
gluster volume help gives insufficient and ambiguous information for bitrot 


Version-Release number of selected component (if applicable):
=============================================================
0.803.gitf64666f.el6.x86_64

How reproducible:
=================
always

Steps to Reproduce:
===================
1.
[root@rhs-client37 ~]# gluster volume help | less
[root@rhs-client37 ~]# gluster volume help | grep bitrot
volume bitrot <volname> {enable|disable} |
volume bitrot <volname> {scrub-throttle frozen|lazy|normal|aggressive} |
volume bitrot <volname> {scrub-frequency daily|weekly|biweekly|monthly} |
volume bitrot <volname> {scrub pause|resume} - Bitrot translator specific operations.



Actual results:
===============
insufficient and ambiguous information

Expected results:
================
should provide more detailed information about bitrot and its option

Comment 1 Anand Avati 2015-04-06 09:59:38 UTC
REVIEW: http://review.gluster.org/10133 (cli: gluster volume help should give sufficient information for bitrot) posted (#1) for review on master by Gaurav Kumar Garg (ggarg)

Comment 2 Anand Avati 2015-04-06 12:51:17 UTC
REVIEW: http://review.gluster.org/10139 (cluster/dht: fix spurious smoke test failure) posted (#1) for review on master by Gaurav Kumar Garg (ggarg)

Comment 3 Anand Avati 2015-04-06 13:14:27 UTC
COMMIT: http://review.gluster.org/10139 committed in master by Niels de Vos (ndevos) 
------
commit e47a64b929d400ade6c97c3e45531100b979fc51
Author: Gaurav Kumar Garg <ggarg>
Date:   Mon Apr 6 18:17:10 2015 +0530

    cluster/dht: fix spurious smoke test failure
    
    There is smoke test failure due to implici declaration of function
    "uuid_parse" and "uuid_compare".
    
    Fix is to change these function caller name to "gf_uuid_parse" and
    "gf_uuid_compare."
    
    Change-Id: I79efa00c44d112c2ca732a9d9711c07bd5f1a069
    BUG: 1207532
    Signed-off-by: Gaurav Kumar Garg <ggarg>
    Reviewed-on: http://review.gluster.org/10139
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Niels de Vos <ndevos>

Comment 4 Anand Avati 2015-04-06 18:02:31 UTC
REVIEW: http://review.gluster.org/10133 (cli: gluster volume help should give sufficient information for bitrot) posted (#2) for review on master by Gaurav Kumar Garg (ggarg)

Comment 5 Anand Avati 2015-04-07 06:16:25 UTC
REVIEW: http://review.gluster.org/10133 (cli: gluster volume help should give sufficient information for bitrot) posted (#3) for review on master by Gaurav Kumar Garg (ggarg)

Comment 6 Anand Avati 2015-04-08 07:24:08 UTC
REVIEW: http://review.gluster.org/10133 (cli: gluster volume help should give sufficient information for bitrot) posted (#4) for review on master by Gaurav Kumar Garg (ggarg)

Comment 7 Anand Avati 2015-04-08 11:17:00 UTC
REVIEW: http://review.gluster.org/10133 (cli: gluster volume help should give sufficient information for bitrot) posted (#5) for review on master by Gaurav Kumar Garg (ggarg)

Comment 8 Anand Avati 2015-04-09 04:40:55 UTC
COMMIT: http://review.gluster.org/10133 committed in master by Kaushal M (kaushal) 
------
commit 61afe3a0c87f11fa685db1e71867d80c533f42e0
Author: Gaurav Kumar Garg <ggarg>
Date:   Mon Apr 6 15:23:55 2015 +0530

    cli: gluster volume help should give sufficient information for bitrot
    
    Previously command "gluster volume help | grep bitrot" was not giving
    sufficient information for bitrot.
    
    With this fix command "gluster volume help" will give appropriate information
    for bitrot.
    
    Change-Id: Ic385c760d4ecbfb16ff5d90dba8940b3616035e5
    BUG: 1207532
    Signed-off-by: Gaurav Kumar Garg <ggarg>
    Reviewed-on: http://review.gluster.org/10133
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaushal M <kaushal>

Comment 9 Anand Avati 2015-04-16 12:31:09 UTC
REVIEW: http://review.gluster.org/10273 (cli,doc: man page of gluster (man gluster) should show bitrot command information) posted (#1) for review on master by Gaurav Kumar Garg (ggarg)

Comment 11 Anand Avati 2015-04-20 18:33:50 UTC
REVIEW: http://review.gluster.org/10273 (cli,doc: man page of gluster (man gluster) should show bitrot command information) posted (#2) for review on master by Vijay Bellur (vbellur)

Comment 12 Anand Avati 2015-04-22 08:50:00 UTC
REVIEW: http://review.gluster.org/10273 (cli,doc: man page of gluster (man gluster) should show bitrot command information) posted (#3) for review on master by Gaurav Kumar Garg (ggarg)

Comment 13 Anand Avati 2015-04-27 07:01:43 UTC
REVIEW: http://review.gluster.org/10273 (cli,doc: man page of gluster (man gluster) should show bitrot command information) posted (#4) for review on master by Gaurav Kumar Garg (ggarg)

Comment 14 Anand Avati 2015-04-29 07:00:21 UTC
COMMIT: http://review.gluster.org/10273 committed in master by Kaushal M (kaushal) 
------
commit 9f7557a50584dd71e7d84cedf16d4937dc821f42
Author: Gaurav Kumar Garg <ggarg>
Date:   Thu Apr 16 17:50:04 2015 +0530

    cli,doc: man page of gluster (man gluster) should show bitrot command information
    
    Currently when user type incorrent bitrot specific command then every
    time cli error suggest wrong command to reuse.
    With this fix it cli will suggest specific bitrot command when user type
    wrong bitrot command.
    
    With this fix it will also display bitrot command information in man page
    by typing 'man gluster'
    
    Change-Id: I7dbf31332a8cc0723e54e8a37fea0afe19d95e0e
    BUG: 1207532
    Signed-off-by: Gaurav Kumar Garg <ggarg>
    Reviewed-on: http://review.gluster.org/10273
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Venky Shankar <vshankar>
    Reviewed-by: Atin Mukherjee <amukherj>
    Tested-by: NetBSD Build System
    Reviewed-by: Kaushal M <kaushal>

Comment 15 Gaurav Kumar Garg 2015-04-29 07:06:42 UTC
[root@rhs-client37 ~]# gluster volume help | grep bitrot
volume bitrot <volname> {enable|disable} |
volume bitrot <volname> {scrub-throttle frozen|lazy|normal|aggressive} |
volume bitrot <volname> {scrub-frequency daily|weekly|biweekly|monthly} |
volume bitrot <volname> {scrub pause|resume} - "Bitrot translator specific operation. For more information about bitrot command type  'man gluster'"



and if user type "man gluster" command it will give you details about individual commands. 

Above patch also fixes bug if user type incorrect bitrot command then along with displaying error every time cli suggesting the different bitrot specific command to use again.

Comment 16 Anand Avati 2015-04-30 08:14:32 UTC
REVIEW: http://review.gluster.org/10461 (cli,doc: man page of gluster (man gluster) should show bitrot command information) posted (#1) for review on release-3.7 by Gaurav Kumar Garg (ggarg)

Comment 17 Anand Avati 2015-05-02 11:59:32 UTC
COMMIT: http://review.gluster.org/10461 committed in release-3.7 by Vijay Bellur (vbellur) 
------
commit 09bbd5c767c917b90a12f015ab4c943c0c210574
Author: Gaurav Kumar Garg <ggarg>
Date:   Thu Apr 16 17:50:04 2015 +0530

    cli,doc: man page of gluster (man gluster) should show bitrot command information
    
    Currently when user type incorrent bitrot specific command then every
    time cli error suggest wrong command to reuse.
    With this fix it cli will suggest specific bitrot command when user type
    wrong bitrot command.
    
    With this fix it will also display bitrot command information in man page
    by typing 'man gluster'
    
    Change-Id: I7dbf31332a8cc0723e54e8a37fea0afe19d95e0e
    BUG: 1207532
    Signed-off-by: Gaurav Kumar Garg <ggarg>
    Reviewed-on: http://review.gluster.org/10273
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Venky Shankar <vshankar>
    Reviewed-by: Atin Mukherjee <amukherj>
    Tested-by: NetBSD Build System
    Reviewed-by: Kaushal M <kaushal>
    (cherry picked from commit 9f7557a50584dd71e7d84cedf16d4937dc821f42)
    Reviewed-on: http://review.gluster.org/10461
    Reviewed-by: Vijay Bellur <vbellur>

Comment 18 Nagaprasad Sathyanarayana 2015-05-06 09:20:37 UTC
*** Bug 1215033 has been marked as a duplicate of this bug. ***

Comment 19 Niels de Vos 2015-05-14 17:27:07 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 20 Niels de Vos 2015-05-14 17:28:38 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 21 Niels de Vos 2015-05-14 17:35:18 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 23 Niels de Vos 2016-06-16 12:45:56 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.