1207547 – BitRot :- If bitrot is not enabled for given volume then scrubber should not crawl bricks of that volume and should not update vol file for that volume

Bug 1207547 - BitRot :- If bitrot is not enabled for given volume then scrubber should not crawl bricks of that volume and should not update vol file for that volume

Summary: BitRot :- If bitrot is not enabled for given volume then scrubber should not ...

Keywords:
Status:	CLOSED CURRENTRELEASE
Alias:	None
Product:	GlusterFS
Classification:	Community
Component:	bitrot
Sub Component:
Version:	mainline
Hardware:	x86_64
OS:	Linux
Priority:	high
Severity:	high
Target Milestone:	---
Assignee:	Gaurav Kumar Garg
QA Contact:
Docs Contact:	bugs@gluster.org
URL:
Whiteboard:
Depends On:
Blocks:	qe_tracker_everglades
TreeView+	depends on / blocked

Reported:	2015-03-31 07:15 UTC by Rachana Patel
Modified:	2016-06-05 23:38 UTC (History)
CC List:	5 users (show)
Fixed In Version:	glusterfs-3.7.0beta1
Doc Type:	Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:	2015-05-14 17:27:07 UTC
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Embargoed:
Dependent Products:

Attachments	(Terms of Use)

Description Rachana Patel 2015-03-31 07:15:48 UTC

Description of problem:
=======================
even though bitrot is not enabled on volume, it updates vol files and scrubber is crawling brick for that volume.

Version-Release number of selected component (if applicable):
=============================================================
0.803.gitf64666f.el6.x86_64

How reproducible:
=================
always


Steps to Reproduce:
===================
1. create multiple volumes in cluster and enable bitrot for only one volume(volume name - rac1)
2. check scrubber log and vol file.
3. vol file is updated for other volumes(bitrot was not enabled for volumes -  2tier_distrep, tiervol10 ...)


[root@rhs-client37 scrub]# cat scrub-server.vol 
volume 2tier_distrep-client-8
    type protocol/client
    option password d7cf0a0c-ec5a-454c-8ffd-a4903a782ee7
    option username 1036c4b2-6ee3-40fa-8ca1-7d70c77c2f1d
    option transport-type tcp
    option remote-subvolume /pavanbrick2/2tier_distrep/hb2
    option remote-host rhs-client37
    option ping-timeout 42
end-volume

volume 2tier_distrep-client-7
    type protocol/client
    option password d7cf0a0c-ec5a-454c-8ffd-a4903a782ee7
    option username 1036c4b2-6ee3-40fa-8ca1-7d70c77c2f1d
    option transport-type tcp
    option remote-subvolume /pavanbrick2/2tier_distrep/hb1m
    option remote-host rhs-client37
    option ping-timeout 42
end-volume

volume 2tier_distrep-client-1
    type protocol/client
    option password d7cf0a0c-ec5a-454c-8ffd-a4903a782ee7
    option username 1036c4b2-6ee3-40fa-8ca1-7d70c77c2f1d
    option transport-type tcp
    option remote-subvolume /pavanbrick1/2tier_distrep/b1m
    option remote-host rhs-client37
    option ping-timeout 42
end-volume

volume 2tier_distrep-client-2
    type protocol/client
    option password d7cf0a0c-ec5a-454c-8ffd-a4903a782ee7
    option username 1036c4b2-6ee3-40fa-8ca1-7d70c77c2f1d
    option transport-type tcp
    option remote-subvolume /pavanbrick1/2tier_distrep/b2
    option remote-host rhs-client37
    option ping-timeout 42
end-volume

volume tiervol10-client-4
    type protocol/client
    option password 30014655-01c9-4bee-a907-187d1fc68094
    option username ab1c7b6d-0e75-4a8b-8392-86d22d8b51c6
    option transport-type tcp
    option remote-subvolume /pavanbrick2/tiervol10/hb1
    option remote-host rhs-client37
    option ping-timeout 42
end-volume

volume tiervol10-client-1
    type protocol/client
    option password 30014655-01c9-4bee-a907-187d1fc68094
    option username ab1c7b6d-0e75-4a8b-8392-86d22d8b51c6
    option transport-type tcp
    option remote-subvolume /pavanbrick1/tiervol10/b1
    option remote-host rhs-client37
    option ping-timeout 42
end-volume

volume tier_distrep-client-8
    type protocol/client
    option password 7fff38fb-f3c9-4875-8287-7b6896cd7300
    option username f917e26f-80e0-4679-8cd1-cdf97a94e5f3
    option transport-type tcp
    option remote-subvolume /pavanbrick2/tier_distrep/hb2
    option remote-host rhs-client37
    option ping-timeout 42
end-volume

volume tier_distrep-client-7
    type protocol/client
    option password 7fff38fb-f3c9-4875-8287-7b6896cd7300
    option username f917e26f-80e0-4679-8cd1-cdf97a94e5f3
    option transport-type tcp
    option remote-subvolume /pavanbrick2/tier_distrep/hb1m
    option remote-host rhs-client37
    option ping-timeout 42
end-volume

volume tier_distrep-client-1
    type protocol/client
    option password 7fff38fb-f3c9-4875-8287-7b6896cd7300
    option username f917e26f-80e0-4679-8cd1-cdf97a94e5f3
    option transport-type tcp
    option remote-subvolume /pavanbrick1/tier_distrep/b1m
    option remote-host rhs-client37
    option ping-timeout 42
end-volume

volume tier_distrep-client-2
    type protocol/client
    option password 7fff38fb-f3c9-4875-8287-7b6896cd7300
    option username f917e26f-80e0-4679-8cd1-cdf97a94e5f3
    option transport-type tcp
    option remote-subvolume /pavanbrick1/tier_distrep/b2
    option remote-host rhs-client37
    option ping-timeout 42
end-volume

volume rac1-client-1
    type protocol/client
    option password 2d5e8d5a-4495-4432-9fe8-37926e6f8ee7
    option username f4052478-a69a-42dd-bb61-88ea41c353a2
    option transport-type tcp
    option remote-subvolume /pavanbrick7/r1
    option remote-host rhs-client37
    option ping-timeout 42
end-volume

volume bit-rot
    type features/bit-rot
    option scrubber true
    subvolumes 2tier_distrep-client-8 2tier_distrep-client-7 2tier_distrep-client-1 2tier_distrep-client-2 tiervol10-client-4 tiervol10-client-1 tier_distrep-client-8 tier_distrep-client-7 tier_distrep-client-1 tier_distrep-client-2 rac1-client-1
end-volume


Actual results:
===============
even though bitrot is not enabled on volume, it updates vol files and scrubber is crawling brick for that volume.

Expected results:
================
vol file should be updated on enabling bitrot

Comment 1 Rachana Patel 2015-03-31 07:17:11 UTC

sosreport@  http://rhsqe-repo.lab.eng.blr.redhat.com/sosreports/1207029/

Comment 2 Anand Avati 2015-04-10 08:58:38 UTC

REVIEW: http://review.gluster.org/10190 (bitrot/glusterd: Scrubber should not crawl bricks if bitrot is not enable) posted (#1) for review on master by Gaurav Kumar Garg (ggarg)

Comment 3 Anand Avati 2015-04-13 08:46:10 UTC

COMMIT: http://review.gluster.org/10190 committed in master by Venky Shankar (vshankar) 
------
commit 1387bd92e8ada3a0e46d833997a14d35e810f0de
Author: Gaurav Kumar Garg <ggarg>
Date:   Fri Apr 10 14:16:36 2015 +0530

    bitrot/glusterd: Scrubber should not crawl bricks if bitrot is not enable
    
    If user create multiple volume and user enable bitrot only for few
    volume then scrubber should not crawl bricks of volume on which bitrot
    is not enable.
    Fix is while volfile generation check whether bitrot is enable on that
    particular volume or not. If bitrot is enable then only it add bricks of
    that volume in scrubber volfile.
    
    Change-Id: I53687c8e1acb39f8e4a712028b73f0b7006122b9
    BUG: 1207547
    Signed-off-by: Gaurav Kumar Garg <ggarg>
    Reviewed-on: http://review.gluster.org/10190
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Atin Mukherjee <amukherj>
    Reviewed-by: Venky Shankar <vshankar>
    Tested-by: Venky Shankar <vshankar>

Comment 5 Niels de Vos 2015-05-14 17:27:07 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Niels de Vos 2015-05-14 17:28:38 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 7 Niels de Vos 2015-05-14 17:35:18 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Note You need to log in before you can comment on or make changes to this bug.