Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1207615

Summary:	sharding - Implement remaining fops
Product:	[Community] GlusterFS	Reporter:	Krutika Dhananjay <kdhananj>
Component:	sharding	Assignee:	Krutika Dhananjay <kdhananj>
Status:	CLOSED CURRENTRELEASE	QA Contact:	bugs <bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---	Keywords:	Reopened, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1214247 (view as bug list)		Environment:
Last Closed:	2016-06-16 12:46:47 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1214247

Description Krutika Dhananjay 2015-03-31 10:18:10 UTC

Description of problem:
This bug is for tracking the completion of the following fops in sharding:

READV
OPEN
[F]TRUNCATE
DISCARD
FALLOCATE
ZEROFILL
RENAME
UNLINK
[F]SETATTR
FSYNC
FLUSH


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2015-04-15 08:27:25 UTC

REVIEW: http://review.gluster.org/10249 (features/shard: Implement unlink fop) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 2 Anand Avati 2015-04-15 09:49:29 UTC

REVIEW: http://review.gluster.org/10249 (features/shard: Implement unlink fop) posted (#2) for review on master by Krutika Dhananjay (kdhananj)

Comment 3 Anand Avati 2015-04-17 09:10:38 UTC

REVIEW: http://review.gluster.org/10249 (features/shard: Implement unlink fop) posted (#3) for review on master by Krutika Dhananjay (kdhananj)

Comment 4 Anand Avati 2015-04-22 05:38:43 UTC

REVIEW: http://review.gluster.org/10249 (features/shard: Implement unlink fop) posted (#4) for review on master by Vijay Bellur (vbellur)

Comment 5 Anand Avati 2015-04-23 07:17:46 UTC

REVIEW: http://review.gluster.org/10249 (features/shard: Implement unlink fop) posted (#5) for review on master by Krutika Dhananjay (kdhananj)

Comment 6 Anand Avati 2015-04-25 07:34:35 UTC

COMMIT: http://review.gluster.org/10249 committed in master by Vijay Bellur (vbellur) 
------
commit 3514f465ef58aff3ed160538fbd22fc72a27b2aa
Author: Krutika Dhananjay <kdhananj>
Date:   Mon Apr 13 15:32:58 2015 +0530

    features/shard: Implement unlink fop
    
    Change-Id: I5cdd805821a4f3657f490223b97f42c724ee588f
    BUG: 1207615
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/10249
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: NetBSD Build System
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 7 Anand Avati 2015-04-25 10:20:35 UTC

REVIEW: http://review.gluster.org/10373 (features/shard: Implement rename() fop) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 8 Anand Avati 2015-04-28 10:54:48 UTC

REVIEW: http://review.gluster.org/10373 (features/shard: Implement rename() fop) posted (#2) for review on master by Krutika Dhananjay (kdhananj)

Comment 9 Anand Avati 2015-04-28 13:27:39 UTC

REVIEW: http://review.gluster.org/10427 (features/shard: Add "is-directory" checks in stat/fstat) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 10 Anand Avati 2015-04-29 06:44:35 UTC

REVIEW: http://review.gluster.org/10446 (features/shard: Take hole size into account while computing ia_size) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 11 Anand Avati 2015-04-29 17:12:30 UTC

COMMIT: http://review.gluster.org/10373 committed in master by Vijay Bellur (vbellur) 
------
commit 5b5048670c34df3f9eab9a6a3ab8eec288bd9d74
Author: Krutika Dhananjay <kdhananj>
Date:   Thu Apr 16 11:34:18 2015 +0530

    features/shard: Implement rename() fop
    
    Change-Id: Ia39fa0f29eac84c18d13a94f704b1703565b504e
    BUG: 1207615
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/10373
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System
    Reviewed-by: Vijay Bellur <vbellur>

Comment 12 Anand Avati 2015-04-30 03:46:46 UTC

REVIEW: http://review.gluster.org/10427 (features/shard: Add "is-directory" checks in stat/fstat) posted (#2) for review on master by Krutika Dhananjay (kdhananj)

Comment 13 Anand Avati 2015-04-30 03:50:01 UTC

REVIEW: http://review.gluster.org/10446 (features/shard: Take hole size into account while computing ia_size) posted (#2) for review on master by Krutika Dhananjay (kdhananj)

Comment 14 Anand Avati 2015-04-30 10:27:02 UTC

REVIEW: http://review.gluster.org/10446 (features/shard: Take hole size into account while computing ia_size) posted (#3) for review on master by Krutika Dhananjay (kdhananj)

Comment 15 Anand Avati 2015-04-30 10:27:29 UTC

REVIEW: http://review.gluster.org/10427 (features/shard: Add "is-directory" checks in stat/fstat) posted (#3) for review on master by Krutika Dhananjay (kdhananj)

Comment 16 Anand Avati 2015-05-03 15:39:02 UTC

COMMIT: http://review.gluster.org/10427 committed in master by Vijay Bellur (vbellur) 
------
commit cff5db814ee31b556d321f7421cdb3fccc8c629d
Author: Krutika Dhananjay <kdhananj>
Date:   Tue Apr 28 18:51:38 2015 +0530

    features/shard: Add "is-directory" checks in stat/fstat
    
    During mount, NFS directly calls stat on the root of the volume
    without sending a lookup on it. This was causing inode_ctx_get_block_size()
    to fail on /. A check is now added in [f]stat which would ensure no action
    is taken by shard xlator when the operation is on a directory.
    
    Change-Id: I81849eeddfdad9f271155442408d95b4a25d7647
    BUG: 1207615
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/10427
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 17 Anand Avati 2015-05-04 12:43:42 UTC

REVIEW: http://review.gluster.org/10528 (features/shard: Implement readv() fop) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 18 Anand Avati 2015-05-04 15:27:31 UTC

REVIEW: http://review.gluster.org/10528 (features/shard: Implement readv() fop) posted (#2) for review on master by Krutika Dhananjay (kdhananj)

Comment 19 Anand Avati 2015-05-05 08:57:56 UTC

REVIEW: http://review.gluster.org/10528 (features/shard: Implement readv() fop) posted (#3) for review on master by Krutika Dhananjay (kdhananj)

Comment 20 Anand Avati 2015-05-05 17:34:36 UTC

REVIEW: http://review.gluster.org/10528 (features/shard: Implement readv() fop) posted (#4) for review on master by Vijay Bellur (vbellur)

Comment 21 Anand Avati 2015-05-07 12:08:32 UTC

REVIEW: http://review.gluster.org/10631 (features/shard: Implement [f]truncate fops) posted (#2) for review on master by Krutika Dhananjay (kdhananj)

Comment 22 Anand Avati 2015-05-08 01:46:17 UTC

COMMIT: http://review.gluster.org/10631 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 768b86a269378e66f9378295073740ff6e0cb02e
Author: Krutika Dhananjay <kdhananj>
Date:   Tue May 5 06:50:46 2015 +0530

    features/shard: Implement [f]truncate fops
    
    To-Do:
    * Make ftruncate work even in the absence of path
    * Aggregate and update ia_blocks appropriately when a file is
      truncated to a lower size.
    
    Change-Id: Ifd24c2f5e80d2c3bc921261f5481251df8948126
    BUG: 1207615
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/10631
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 23 Nagaprasad Sathyanarayana 2015-10-25 14:51:45 UTC

Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 24 Niels de Vos 2016-06-16 12:46:47 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user