Bug 1208118 - gf_log_inject_timer_event can crash if the passed ctx is null.
Summary: gf_log_inject_timer_event can crash if the passed ctx is null.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: core
Version: mainline
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Humble Chirammal
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-04-01 12:48 UTC by Humble Chirammal
Modified: 2015-05-14 17:46 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.7.0
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-05-14 17:29:26 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Humble Chirammal 2015-04-01 12:48:57 UTC
Description of problem:

ctx is passed to gf_log_inject_timer_event() and pass through to
__gf_log_inject_timer_event() where the ctx struct members are getting
dereferenced, and can cause crash if the passed ctx is null.



Version-Release number of selected component (if applicable):

GlusterFS 3.6

How reproducible:

N/A

Steps to Reproduce:

N/A

Actual results:

The ctx can be null and can lead to crash.

Expected results:

The ctx need to be checked before dereferencing its members.

Comment 1 Anand Avati 2015-04-01 12:55:59 UTC
REVIEW: http://review.gluster.org/10102 (libglusterfs: avoid possibility of crash when ctx is null) posted (#1) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 2 Anand Avati 2015-04-08 18:15:11 UTC
COMMIT: http://review.gluster.org/10102 committed in master by Niels de Vos (ndevos) 
------
commit 737c027edc51749ebe023baf4ec0db3077329988
Author: Humble Devassy Chirammal <hchiramm>
Date:   Wed Apr 1 17:50:25 2015 +0530

    libglusterfs: avoid possibility of crash when ctx is null
    
    ctx is passed to gf_log_inject_timer_event() and pass through to
     __gf_log_inject_timer_event() where the struct members are getting
    dereferenced, and can cause crash if the passed ctx is null. This patch
    avoids the issue.
    
    Change-Id: I153dbb5d3744898429139e3d40bb4f0e9093632a
    BUG: 1208118
    Signed-off-by: Humble Devassy Chirammal <hchiramm>
    Reviewed-on: http://review.gluster.org/10102
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>

Comment 3 Niels de Vos 2015-05-14 17:29:26 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 4 Niels de Vos 2015-05-14 17:35:55 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 5 Niels de Vos 2015-05-14 17:38:17 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Niels de Vos 2015-05-14 17:46:38 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.