Bug 1208509 - Review Request: perl-License-Syntax - Coding and decoding of license strings using SPDX and SUSE syntax
Summary: Review Request: perl-License-Syntax - Coding and decoding of license strings ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-04-02 12:17 UTC by Petr Šabata
Modified: 2015-05-14 08:57 UTC (History)
2 users (show)

Fixed In Version: perl-License-Syntax-0.13-1.fc21
Clone Of:
Environment:
Last Closed: 2015-05-14 08:57:40 UTC
Type: ---
Embargoed:
ppisar: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Šabata 2015-04-02 12:17:36 UTC
Spec URL: https://psabata.fedorapeople.org/pkgs/perl-License-Syntax/perl-License-Syntax.spec
SRPM URL: https://psabata.fedorapeople.org/pkgs/perl-License-Syntax/perl-License-Syntax-0.13-1.fc21.src.rpm
Description:
License::Syntax is an object oriented module.  When constructing new 
License::Syntax objects, you can provide a mapping table for license
names.  The table is used for recognizing alternate alias names for the 
licenses (left hand side) and also defines the canonical short names of
the licenses (right hand side).  The mapping table is consulted twice,
before and after decoding the syntax, thus non-terminal mappings may 
actually be followed.
Fedora Account System Username: psabata

Comment 1 Petr Pisar 2015-04-02 15:07:36 UTC
URL and Souce0 are usable. Ok.
Source archive is original (SHA-256: 18401fd2aa73f6ef4b85bb8f6f69c48452b554ab8c4397808c178c36c34beca5). Ok.
Summary is Ok.
Description is Ok.
License verified from README, Makefile.PL, Syntax.pm. Ok.
No XS code, noarch BuilArch is Ok.
Build-requires are Ok.

TODO: Removing write-protected license_syntax.pl in %install section is interactive. Please make the removal forceful or patch Makefile.Pl not to install the file.

All test pass. Ok.

$ rpmlint perl-License-Syntax.spec ../SRPMS/perl-License-Syntax-0.13-1.fc23.src.rpm ../RPMS/noarch/perl-License-Syntax-0.13-1.fc23.noarch.rpm 
perl-License-Syntax.src: W: tag-in-description C License:
perl-License-Syntax.src: W: tag-in-description C License:
perl-License-Syntax.noarch: W: tag-in-description C License:
perl-License-Syntax.noarch: W: tag-in-description C License:
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
rpmlint is dizzy today. Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-License-Syntax-0.13-1.fc23.noarch.rpm se-Syntax-0.13.tar.gz (timeout 10 seconds)                               .
drwxr-xr-x    2 root    root                        0 Apr  2 17:00 /usr/share/doc/perl-License-Syntax
-rw-r--r--    1 root    root                     1196 Nov 30  2011 /usr/share/doc/perl-License-Syntax/Changes
-rw-r--r--    1 root    root                     1563 Oct  5  2011 /usr/share/doc/perl-License-Syntax/README
-rw-r--r--    1 root    root                     1425 Oct  5  2011 /usr/share/doc/perl-License-Syntax/license_syntax.pl
-rw-r--r--    1 root    root                    22001 Nov 30  2011 /usr/share/doc/perl-License-Syntax/synopsis.csv
-rw-r--r--    1 root    root                     4606 Apr  2 16:59 /usr/share/man/man3/License::Syntax.3pm.gz
drwxr-xr-x    2 root    root                        0 Apr  2 16:59 /usr/share/perl5/vendor_perl/License
-rw-r--r--    1 root    root                    25370 Nov 30  2011 /usr/share/perl5/vendor_perl/License/Syntax.pm
File permissions and layout are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-License-Syntax-0.13-1.fc23.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.20.2)
      1 perl(Carp)
      1 perl(Data::Dumper)
      1 perl(DBD::SQLite)
      1 perl(DBI)
      1 perl(POSIX)
      1 perl(strict)
      1 perl(Text::CSV)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-License-Syntax-0.13-1.fc23.noarch.rpm | sort -f | uniq -c
      1 perl(License::Syntax) = 0.13
      1 perl-License-Syntax = 0.13-1.fc23
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-License-Syntax-0.13-1.fc23.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F23 (http://koji.fedoraproject.org/koji/taskinfo?taskID=9399836). Ok.

Otherwise the package in line with Fedora and Perl packaging guidelines.

Please consider fixing all `TODO' items before building this package.

Resolution: Package APPROVED.

Comment 2 Petr Šabata 2015-04-02 15:48:48 UTC
New Package SCM Request
=======================
Package Name: perl-License-Syntax
Short Description: Coding and decoding of license strings using SPDX and SUSE syntax
Upstream URL: http://search.cpan.org/dist/License-Syntax/
Owners: psabata jplesnik ppisar
Branches: f21 f22
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2015-04-02 19:34:07 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2015-04-08 12:17:27 UTC
perl-License-Syntax-0.13-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/perl-License-Syntax-0.13-1.fc22

Comment 5 Fedora Update System 2015-04-08 12:18:13 UTC
perl-License-Syntax-0.13-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/perl-License-Syntax-0.13-1.fc21

Comment 6 Fedora Update System 2015-04-21 19:04:55 UTC
perl-License-Syntax-0.13-1.fc22 has been pushed to the Fedora 22 stable repository.

Comment 7 Fedora Update System 2015-05-10 23:56:24 UTC
perl-License-Syntax-0.13-1.fc21 has been pushed to the Fedora 21 stable repository.


Note You need to log in before you can comment on or make changes to this bug.