Spec URL: https://fedorapeople.org/cgit/ktdreyer/public_git/python-jenkins-job-builder.git/plain/python-jenkins-job-builder.spec SRPM URL: https://ktdreyer.fedorapeople.org/reviews/python-jenkins-job-builder-1.1.0-1.fc23.src.rpm Description: Jenkins Job Builder takes simple descriptions of Jenkins jobs in YAML format and uses them to configure Jenkins. You can keep your job descriptions in human readable text format in a version control system to make changes and auditing easier. It also has a flexible template system, so creating many similarly configured jobs is easy. Fedora Account System Username: ktdreyer Rawhide (F23) scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9408332
Ok, so no dependencies that aren't in Fedora now, good. fedora-review isn't working for me, so no automated paste. - Maybe create a macro for the description rather than copy/paste - What is PBR_VERSION? There are no hits for that in the source I see These are minor issues though, setting fedora_review+ since they can be fixed before or after commit.
Hi Colin, would you be ok with me renaming this to simply "jenkins-job-builder" ? I noticed dcaro's package was named this way, and I think it makes more sense. If you indicate your approval for this change, I'll rename the bug title and put in the SCM admin request.
(In reply to Ken Dreyer from comment #2) > Hi Colin, would you be ok with me renaming this to simply > "jenkins-job-builder" ? I noticed dcaro's package was named this way, and I > think it makes more sense. This actually leads to a question I had - right now this package includes both a Python library *and* a binary. Are there any other packages that might depend on the library code? If not, that would argue for moving the library into a private directory (e.g. /usr/lib/jenkins-job-builder), and setting PYTHONPATH (or changing sys.path) inside the binary script. I realize this approach isn't common among Python programs, but I believe that making a shared library shouldn't be the default - only libraries which are "stable" should be public. > If you indicate your approval for this change, I'll rename the bug title and > put in the SCM admin request. The above all said...I'm not opposed to a rename. You'll find Python packages whose primary interface is an executable in Fedora that go both ways.
What is the reason to not follow the same naming of other Python packages like python-nose or python-unittest2? (In reply to Colin Walters from comment #3) > (In reply to Ken Dreyer from comment #2) > > Hi Colin, would you be ok with me renaming this to simply > > "jenkins-job-builder" ? I noticed dcaro's package was named this way, and I > > think it makes more sense. > > This actually leads to a question I had - right now this package includes > both a Python library *and* a binary. > > Are there any other packages that might depend on the library code? If not, > that would argue for moving the library into a private directory (e.g. > /usr/lib/jenkins-job-builder), and setting PYTHONPATH (or changing sys.path) > inside the binary script. > > I realize this approach isn't common among Python programs, but I believe > that making a shared library shouldn't be the default - only libraries which > are "stable" should be public. > > > If you indicate your approval for this change, I'll rename the bug title and > > put in the SCM admin request. > > The above all said...I'm not opposed to a rename. You'll find Python > packages whose primary interface is an executable in Fedora that go both > ways. What is the reason to not follow the same naming of other Python packages like python-nose or python-unittest2?
Ok, let's just keep it as python-jenkins-job-builder :) New Package SCM Request ======================= Package Name: python-jenkins-job-builder Short Description: Manage Jenkins jobs with YAML Upstream URL: http://ci.openstack.org/jenkins-job-builder/ Owners: ktdreyer Branches: f21 f22 epel7
Git done (by process-git-requests).
python-jenkins-job-builder-1.1.0-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-jenkins-job-builder-1.1.0-1.fc22
python-jenkins-job-builder-1.1.0-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-jenkins-job-builder-1.1.0-1.fc21
python-jenkins-job-builder-1.1.0-1.fc22 has been pushed to the Fedora 22 testing repository.
python-jenkins-job-builder-1.1.0-1.fc22 has been pushed to the Fedora 22 stable repository.
python-jenkins-job-builder-1.1.0-1.fc21 has been pushed to the Fedora 21 stable repository.