I used as example one of the latest packages I had reviewed: $ fedora-review -b 894602 INFO: Processing bugzilla bug: 894602 INFO: Getting .spec and .srpm Urls from : 894602 INFO: --> SRPM url: http://pcpa.fedorapeople.org/coin-or/coin-or-Dip-0.91.1-1.fc23.src.rpm INFO: --> Spec url: http://pcpa.fedorapeople.org/coin-or/coin-or-Dip.spec INFO: Using review directory: /home/pcpa/894602-coin-or-Dip INFO: Downloading .spec and .srpm files INFO: Downloading (Source0): http://www.coin-or.org/download/pkgsource/Dip/Dip-0.91.2.tgz INFO: Running checks and generating report INFO: Results and/or logs in: /home/pcpa/894602-coin-or-Dip/results INFO: Build completed WARNING: Package coin-or-Dip-0.91.2-1.fc23 not built WARNING: Package coin-or-Dip-devel-0.91.2-1.fc23 not built ERROR: 'No srpm found for coin-or-Dip' (logs in /home/pcpa/.cache/fedora-review.log) Note that to get to this point, I did need to run: # echo "config_opts['dnf_builddep_command'] = '/usr/bin/dnf builddep'" >> /etc/mock/site-defaults.cfg as described at https://bugzilla.redhat.com/show_bug.cgi?id=1208912 But the files are there: $ ls 894602-coin-or-Dip/results/ build.log coin-or-Dip-0.91.1-1.fc23.src.rpm coin-or-Dip-0.91.1-1.fc23.x86_64.rpm coin-or-Dip-debuginfo-0.91.1-1.fc23.x86_64.rpm coin-or-Dip-devel-0.91.1-1.fc23.x86_64.rpm root.log state.log but because it got confused, it generated a 0 bytes review.txt $ ls -l 894602-coin-or-Dip/ total 28 -rw-rw-r-- 1 pcpa pcpa 1024 Apr 3 18:33 build.log drwxrwxr-x 2 pcpa pcpa 4096 Apr 3 18:32 dependencies -rw-rw-r-- 1 pcpa pcpa 0 Apr 3 18:33 files.dir drwxrwxr-x 2 pcpa pcpa 4096 Apr 3 18:33 results -rw-rw-r-- 1 pcpa pcpa 0 Apr 3 18:32 review.txt drwxrwxr-x 2 pcpa pcpa 4096 Apr 3 18:32 srpm drwxrwxr-x 2 pcpa pcpa 4096 Apr 3 18:32 srpm-unpacked drwxrwxr-x 2 pcpa pcpa 4096 Apr 3 18:32 upstream drwxrwxr-x 2 pcpa pcpa 4096 Apr 3 18:32 upstream-unpacked for extra information: $ cat 894602-coin-or-Dip/build.log INFO: mock.py version 1.2.7 starting (python version = 3.4.2)... Start: init plugins INFO: selinux disabled Finish: init plugins Start: run INFO: Start(/home/pcpa/894602-coin-or-Dip/srpm/coin-or-Dip-0.91.1-1.fc23.src.rpm) Config(fedora-rawhide-x86_64) Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled yum cache Start: cleaning yum metadata Finish: cleaning yum metadata INFO: enabled ccache Mock Version: 1.2.7 INFO: Mock Version: 1.2.7 Finish: chroot init Start: build phase for coin-or-Dip-0.91.1-1.fc23.src.rpm Start: build setup for coin-or-Dip-0.91.1-1.fc23.src.rpm Finish: build setup for coin-or-Dip-0.91.1-1.fc23.src.rpm Start: rpmbuild coin-or-Dip-0.91.1-1.fc23.src.rpm Finish: rpmbuild coin-or-Dip-0.91.1-1.fc23.src.rpm Finish: build phase for coin-or-Dip-0.91.1-1.fc23.src.rpm INFO: Done(/home/pcpa/894602-coin-or-Dip/srpm/coin-or-Dip-0.91.1-1.fc23.src.rpm) Config(default) 0 minutes 54 seconds INFO: Results and/or logs in: /home/pcpa/894602-coin-or-Dip/results Finish: run this run was fast because it was a second try, and the mock chroot was already created, and dependencies installed, files were in cache, etc.
Hm... My first guess is that this is related to using dnf instead of yum. Unfortunetaly, fedora-review has not been ported to dnf yet. The srpm and spec file are gone. Could you make them available somehow so we reproduce?
Ping? We need more input (i. e., a reproducer) to be able to handle this. Will close bug if there is no feedback.
Hi, I did reupload the srpm now as: http://pcpa.fedorapeople.org/coin-or/coin-or-Dip-0.91.2-1.fc23.src.rpm But it can be also regenerated with: $ fedpkg co coin-or-Dip $ fedpkg srpm Then, it would be better to test as: $ fedora-review -n coin-or-Dip -r The problem happened because I was adding for some time, -o--yum to fedora-review command line, what broke when dnf changed yum to a wrapper to dnf, and previous yum was renamed to yum-deprecated I did run the command: echo "config_opts['dnf_builddep_command'] = '/usr/bin/dnf builddep'" >> /etc/mock/site-defaults.cfg to get fedora-review, in rawhide to generated the chroot. Note that the problem is/was only in rawhide, and things may have changed since then. I use rawhide in my desktop computer for several years already.
Basically, this yet another incompatibility between dnf and yum. Blocking this bug on upstream bug https://fedorahosted.org/FedoraReview/ticket/250 - there is really no point in messing around wuth the compatibility layer, we need to make a full move to dnf
I have pushed version 0.6.0 to rawhide. There is also an update [1] for f22 pending. Could you possibly verify that this solves your problem? Please note that the updated version only runs on f22+ [1] https://admin.fedoraproject.org/updates/fedora-review-0.6.0-1.fc22
This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle. Changing version to '23'. (As we did not run this process for some time, it could affect also pre-Fedora 23 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23
This now works for me, at least in the upstream version. Closing