RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1209434 - ValueError: invalid literal for int() with base 10: '.'
Summary: ValueError: invalid literal for int() with base 10: '.'
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: targetcli
Version: 7.1
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Andy Grover
QA Contact: Bruno Goncalves
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-04-07 11:04 UTC by Alexander Todorov
Modified: 2023-03-08 07:27 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Previously, the "delete ." command within a target configuration node caused the targetcli utility to terminate unexpectadly. With this update, targetcli no longer crashes in the described situation.
Clone Of:
Environment:
Last Closed: 2015-11-19 14:49:28 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2015:2441 0 normal SHIPPED_LIVE targetcli bug fix and enhancement update 2015-11-19 11:46:26 UTC

Description Alexander Todorov 2015-04-07 11:04:20 UTC 
Description of problem:

While I was cd'd into one of my iscsi targets I issued 'delete .' hoping to delete the currently active entry. Instead targetcli crashed:


/iscsi/iqn.20...ample:target2> delete .
Traceback (most recent call last):
  File "/usr/bin/targetcli", line 122, in <module>
    main()
  File "/usr/bin/targetcli", line 112, in main
    shell.run_interactive()
  File "/usr/lib/python2.7/site-packages/configshell/shell.py", line 948, in run_interactive
    self._cli_loop()
  File "/usr/lib/python2.7/site-packages/configshell/shell.py", line 777, in _cli_loop
    self.run_cmdline(cmdline)
  File "/usr/lib/python2.7/site-packages/configshell/shell.py", line 891, in run_cmdline
    self._execute_command(path, command, pparams, kparams)
  File "/usr/lib/python2.7/site-packages/configshell/shell.py", line 866, in _execute_command
    result = target.execute_command(command, pparams, kparams)
  File "/usr/lib/python2.7/site-packages/configshell/node.py", line 1413, in execute_command
    return method(*pparams, **kparams)
  File "/usr/lib/python2.7/site-packages/targetcli/ui_target.py", line 363, in ui_command_delete
    tpg = TPG(self.rtsnode, int(tag), mode='lookup')
ValueError: invalid literal for int() with base 10: '.'
# 


I'm not requesting to support my syntax (possibly invalid) but at least an error message or proper input handling should be done. 


Version-Release number of selected component (if applicable):
targetcli-2.1.fb37-3.el7.noarch

How reproducible:
always


Steps to Reproduce:
1. Define iscsi target
2. 

# targetcli
/> cd iscsi/iqn.2015-04.com.example:target1
/iscsi/iqn.20...ample:target1> delete .

3.

Actual results:
Traceback

Expected results:
Error message or active iscsi node deleted.

Additional info:
Comment 1 Andy Grover 2015-04-21 17:19:12 UTC 
fixed upstream, will be in next release.
Comment 3 Bruno Goncalves 2015-07-27 13:08:00 UTC 
Fixed on targetcli-2.1.fb41-2.el7.noarch

/> cd /iscsi/iqn.2009-10.com.redhat:storage-1/
/iscsi/iqn.20...hat:storage-1> delete .
Tag argument must be a number.

/iscsi/iqn.20...hat:storage-1> delete  1
Deleted TPGT 1.

######################

Reproduced the problem on targetcli-2.1.fb37-3.el7.noarch

/iscsi/iqn.20...hat:storage-1> delete .
Traceback (most recent call last):
  File "/usr/bin/targetcli", line 122, in <module>
    main()
  File "/usr/bin/targetcli", line 112, in main
    shell.run_interactive()
  File "/usr/lib/python2.7/site-packages/configshell/shell.py", line 894, in run_interactive
    self._cli_loop()
  File "/usr/lib/python2.7/site-packages/configshell/shell.py", line 723, in _cli_loop
    self.run_cmdline(cmdline)
  File "/usr/lib/python2.7/site-packages/configshell/shell.py", line 837, in run_cmdline
    self._execute_command(path, command, pparams, kparams)
  File "/usr/lib/python2.7/site-packages/configshell/shell.py", line 812, in _execute_command
    result = target.execute_command(command, pparams, kparams)
  File "/usr/lib/python2.7/site-packages/configshell/node.py", line 1411, in execute_command
    return method(*pparams, **kparams)
  File "/usr/lib/python2.7/site-packages/targetcli/ui_target.py", line 363, in ui_command_delete
    tpg = TPG(self.rtsnode, int(tag), mode='lookup')
ValueError: invalid literal for int() with base 10: '.'
Comment 4 errata-xmlrpc 2015-11-19 14:49:28 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-2441.html
Note You need to log in before you can comment on or make changes to this bug.