Bug 1209751 - BitRot :- on restarting glusterd values for tunables are reset to default
Summary: BitRot :- on restarting glusterd values for tunables are reset to default
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: bitrot
Version: mainline
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Gaurav Kumar Garg
QA Contact:
bugs@gluster.org
URL:
Whiteboard:
Depends On:
Blocks: qe_tracker_everglades
TreeView+ depends on / blocked
 
Reported: 2015-04-08 07:01 UTC by Rachana Patel
Modified: 2016-06-05 23:38 UTC (History)
5 users (show)

Fixed In Version: glusterfs-3.7.0beta1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-05-14 17:27:16 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Rachana Patel 2015-04-08 07:01:29 UTC
Description of problem:
=======================
On restarting glusterd, values for BitRot tunables are reset to default.


Version-Release number of selected component (if applicable):
=============================================================
0.803.gitf64666f.el6.x86_64

How reproducible:
=================
always

Steps to Reproduce:
===================
1. create and mount volume.
2. enable bitrot
3. create few files.
4. change tunables.
[root@rhs-client37 rac2]# gluster volume bitrot rac1 scrub-throttle  frozen
volume bitrot: success
[root@rhs-client37 rac2]# gluster volume bitrot rac1 scrub-frequency daily
volume bitrot: success
[root@rhs-client37 rac2]# gluster v info rac1
 
Volume Name: rac1
Type: Distribute
Volume ID: 7e82fbfa-1877-4eb3-9c26-d821950dc9ee
Status: Started
Number of Bricks: 3
Transport-type: tcp
Bricks:
Brick1: rhs-client44:/pavanbrick6/r1
Brick2: rhs-client38:/pavanbrick6/r1
Brick3: rhs-client37:/pavanbrick6/r1
Options Reconfigured:
features.scrub-freq: daily
features.scrub-throttle: frozen
features.bitrot: on

5. restart glusterd on one of the server and check volume info
[root@rhs-client37 rac2]# service glusterd restart
Starting glusterd:                               [  OK  ]
[root@rhs-client37 rac2]# gluster v info rac1
 
Volume Name: rac1
Type: Distribute
Volume ID: 7e82fbfa-1877-4eb3-9c26-d821950dc9ee
Status: Started
Number of Bricks: 3
Transport-type: tcp
Bricks:
Brick1: rhs-client44:/pavanbrick6/r1
Brick2: rhs-client38:/pavanbrick6/r1
Brick3: rhs-client37:/pavanbrick6/r1
Options Reconfigured:
features.bitrot: on

6. check vol info on other servers

[root@rhs-client38 ~]# gluster v info rac1
 
Volume Name: rac1
Type: Distribute
Volume ID: 7e82fbfa-1877-4eb3-9c26-d821950dc9ee
Status: Started
Number of Bricks: 3
Transport-type: tcp
Bricks:
Brick1: rhs-client44:/pavanbrick6/r1
Brick2: rhs-client38:/pavanbrick6/r1
Brick3: rhs-client37:/pavanbrick6/r1
Options Reconfigured:
features.scrub-freq: daily
features.scrub-throttle: frozen
features.scrub: pause
features.bitrot: on


Actual Result:-
===============
values for tunables are reset to default on glusterd restart

Expect Result:-
===============
Bitrot configuration should remain same even after restart of glusterd/node

Comment 1 Anand Avati 2015-04-08 07:17:24 UTC
REVIEW: http://review.gluster.org/10159 (glusterd: on restarting glusterd should not reset bitrot tunable value to default) posted (#1) for review on master by Gaurav Kumar Garg (ggarg)

Comment 2 Anand Avati 2015-04-09 18:46:11 UTC
REVIEW: http://review.gluster.org/10159 (glusterd: Restarting glusterd should not reset bitrot tunable value to default) posted (#2) for review on master by Gaurav Kumar Garg (ggarg)

Comment 3 Anand Avati 2015-04-10 07:23:12 UTC
REVIEW: http://review.gluster.org/10159 (glusterd: Restarting glusterd should not reset bitrot tunable value to default) posted (#3) for review on master by Gaurav Kumar Garg (ggarg)

Comment 4 Anand Avati 2015-04-10 09:16:59 UTC
REVIEW: http://review.gluster.org/10159 (glusterd: Restarting glusterd should not reset bitrot tunable value to default) posted (#4) for review on master by Gaurav Kumar Garg (ggarg)

Comment 5 Anand Avati 2015-04-13 08:48:42 UTC
COMMIT: http://review.gluster.org/10159 committed in master by Venky Shankar (vshankar) 
------
commit a2deb5ffb7aba02fe50ef38d9ead84debc3411cb
Author: Gaurav Kumar Garg <ggarg>
Date:   Wed Apr 8 00:27:54 2015 +0530

    glusterd: Restarting glusterd should not reset bitrot tunable value to default
    
    Previously when user restart glusterd then bitrot tunable value for option
    "scrub-throttle", "scrub-frequency", "scrub" cleared. glusterd was not storing
    these bitrot tunable value properly.
    
    With this fix it will store scrub-throttle, scrub-frequency, scrub, bitrot
    tunable value in /var/lib/glusterd/vols/<volname>/info file and it will resume
    these value when glusterd restart.
    
    Change-Id: I58e756e14fbb8513a6f878f808ea148e7aa33cb0
    BUG: 1209751
    Signed-off-by: Gaurav Kumar Garg <ggarg>
    Reviewed-on: http://review.gluster.org/10159
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Atin Mukherjee <amukherj>
    Reviewed-by: Venky Shankar <vshankar>
    Tested-by: Venky Shankar <vshankar>

Comment 7 Niels de Vos 2015-05-14 17:27:16 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 8 Niels de Vos 2015-05-14 17:28:43 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 9 Niels de Vos 2015-05-14 17:35:19 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.