Bug 1209881 - [RFE] remove iptables from hosted-engine.spec file to be able to deploy hosted-engine without firewall services installed
Summary: [RFE] remove iptables from hosted-engine.spec file to be able to deploy hoste...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-hosted-engine-setup
Classification: oVirt
Component: Network
Version: ---
Hardware: x86_64
OS: Linux
low
medium
Target Milestone: ovirt-4.3.0
: 2.3.0
Assignee: Ido Rosenzwig
QA Contact: Nikolai Sednev
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-04-08 12:05 UTC by Sven Kieske
Modified: 2019-04-28 09:02 UTC (History)
9 users (show)

Fixed In Version: ovirt-hosted-engine-setup-2.3.0-0.1.beta
Doc Type: Enhancement
Doc Text:
The iptables and iptables-service have been removed from the list of dependencies in self-hosted engine deployment.
Clone Of:
Environment:
Last Closed: 2019-02-13 07:43:41 UTC
oVirt Team: Integration
Embargoed:
rule-engine: ovirt-4.3+
mavital: testing_plan_complete?
ylavi: planning_ack+
rule-engine: devel_ack+
rule-engine: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 92572 0 master MERGED spec: Remove iptables from spec file 2018-09-03 09:32:28 UTC

Description Sven Kieske 2015-04-08 12:05:58 UTC
Description of problem:
currently you can't install hosted-engine without iptables
because of the spec file, there is however no real need to require it in
the spec file, because the setup explicitly asks the users if he want's to
configure the local firewall

Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
1.try to install hosted-engine without iptables
2.
3.

Actual results:
does not work

Expected results:
does work

Additional info:
created BZ in order to track this as requested by sbonazzo on IRC.
I maybe can submit the patch myself later today.

This also is a prerequisite in order to use firewalld instead of iptables.

also there are many enterprise environments where you do not run local firewalls, but hardware network appliances, which do the firewalling.

Comment 1 Yedidyah Bar David 2015-04-08 12:31:52 UTC
The change to require it was done in [1].

I don't remember anymore the exact reason, but basically, it was because libvirt stopped requiring iptables-service (actually iptables-ipv6, which provided it), so we did not get it anymore as an indirect vdsm dependency.

So when fixing this bug, we have to consider all relevant flows, including setups where iptables is installed but iptables-service isn't.

[1] https://gerrit.ovirt.org/#/q/I12139f9a9f5d4d542e42de00c7a479a2fcc0ccce,n,z

Comment 2 Nikolai Sednev 2018-10-15 12:49:45 UTC
Tested on these components:
ovirt-hosted-engine-setup-2.3.0-0.0.master.20180925121021.git7ceacf4.el7.noarch
ovirt-hosted-engine-ha-2.3.0-0.0.master.20180921140632.20180921140629.gitb3aaef2.el7.noarch

I've removed iptables and then installed ovirt-hosted-engine-setup and seen that 
iptables-1.4.21-24.1.el7_5.x86_64 got installed on host as dependency.
Moving back to assigned.

Comment 3 Nikolai Sednev 2018-10-15 12:51:22 UTC
Appliance was:
ovirt-engine-appliance.noarch 4.3-20181014.1.el7

Comment 4 Simone Tiraboschi 2018-10-16 06:55:23 UTC
We removed it from ovirt-hosted-engine-setup spec file, the issue is that iptables and iptables-services are required by a lot of other packages including firewalld and libvirtd.

See the full tree on https://paste.fedoraproject.org/paste/iav1mfCCskcdJL-ww3F96A

Comment 5 Nikolai Sednev 2018-10-16 09:04:09 UTC
(In reply to Simone Tiraboschi from comment #4)
> We removed it from ovirt-hosted-engine-setup spec file, the issue is that
> iptables and iptables-services are required by a lot of other packages
> including firewalld and libvirtd.
> 
> See the full tree on
> https://paste.fedoraproject.org/paste/iav1mfCCskcdJL-ww3F96A

So what should I test here?
It looks like meaningless to me to test this with provided reproductions steps.

Comment 6 Simone Tiraboschi 2018-10-16 09:13:59 UTC
I think we can just test that ovirt-hosted-engine-setup is not directly requiring iptables and iptables-service but please note that firewalld (and other direct or indirect dependency of ovirt-hosted-engine-setup) still requires them.

Comment 7 Sven Kieske 2018-10-16 09:47:11 UTC
(In reply to Simone Tiraboschi from comment #6)
> I think we can just test that ovirt-hosted-engine-setup is not directly
> requiring iptables and iptables-service but please note that firewalld (and
> other direct or indirect dependency of ovirt-hosted-engine-setup) still
> requires them.

why does ovirt-hosted-engine-setup require firewalld or iptables?

Comment 8 Nikolai Sednev 2018-10-16 11:51:17 UTC
rpm -qaR ovirt-hosted-engine-setup* | grep iptables*
# 
No dependent iptables by ovirt-hosted-engine-setup-2.3.0-0.0.master.20180925121021.git7ceacf4.el7.noarch or ovirt-hosted-engine-ha-2.3.0-0.0.master.20180921140632.20180921140629.gitb3aaef2.el7.noarch
Moving to verified.

Comment 9 Nikolai Sednev 2018-10-16 12:05:59 UTC
puma18 ~]# yum deplist ovirt-hosted-engine-setup* | grep libvirt*
  dependency: libvirt-client
   provider: libvirt-client.x86_64 3.9.0-14.el7_5.8
   provider: libvirt-client.i686 3.9.0-14.el7_5.8
  dependency: libvirt-daemon-config-network
   provider: libvirt-daemon-config-network.x86_64 3.9.0-14.el7_5.8
puma18 ~]# yum deplist libvirt* | grep iptables*
  dependency: iptables
   provider: iptables-services.x86_64 1.4.21-24.1.el7_5
   provider: iptables.x86_64 1.4.21-24.1.el7_5
   provider: iptables.i686 1.4.21-24.1.el7_5
  dependency: iptables
   provider: iptables-services.x86_64 1.4.21-24.1.el7_5
   provider: iptables.x86_64 1.4.21-24.1.el7_5
   provider: iptables.i686 1.4.21-24.1.el7_5
  dependency: iptables
   provider: iptables-services.x86_64 1.4.21-24.1.el7_5
   provider: iptables.x86_64 1.4.21-24.1.el7_5
   provider: iptables.i686 1.4.21-24.1.el7_5
  dependency: iptables
   provider: iptables-services.x86_64 1.4.21-24.1.el7_5
   provider: iptables.x86_64 1.4.21-24.1.el7_5
   provider: iptables.i686 1.4.21-24.1.el7_5

ovirt-hosted-engine-setup doesn't requires iptables directly, hence moved to verified. In case that you still think that iptables have to be removed from other components, please open another bug on that matter.

Comment 10 Sandro Bonazzola 2018-11-02 14:38:04 UTC
This bugzilla is included in oVirt 4.2.7 release, published on November 2nd 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.7 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.

Comment 11 Sandro Bonazzola 2018-11-02 14:45:09 UTC
Closed by mistake, moving back to qa -> verified

Comment 14 Sandro Bonazzola 2019-02-13 07:43:41 UTC
This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.