Bug 1209946 - Review Request: perl-MooseX-Meta-TypeConstraint-Mooish - Translate Moo-style constraints to Moose-style
Summary: Review Request: perl-MooseX-Meta-TypeConstraint-Mooish - Translate Moo-style ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1209926
TreeView+ depends on / blocked
 
Reported: 2015-04-08 13:47 UTC by Petr Pisar
Modified: 2015-04-09 13:26 UTC (History)
2 users (show)

Fixed In Version: perl-MooseX-Meta-TypeConstraint-Mooish-0.001-1.fc23
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-04-09 13:26:37 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Pisar 2015-04-08 13:47:07 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-MooseX-Meta-TypeConstraint-Mooish/perl-MooseX-Meta-TypeConstraint-Mooish.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-MooseX-Meta-TypeConstraint-Mooish/perl-MooseX-Meta-TypeConstraint-Mooish-0.001-1.fc23.src.rpm
Description:
Moose type constraints are expected to return true if the value passes the
constraint, and false otherwise; Moo constraints, on the other hand, die
if validation fails. This meta-class allows for Moo-style constraints. It will
wrap them and translate their Moo into a dialect Moose understands.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2015-04-08 15:22:51 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-MooseX-Meta-TypeConstraint-Mooish-0.001-1.fc23.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.20.2)
      1 perl(Moose)
      1 perl(Moose::Meta::TypeConstraint)
      1 perl(Moose::Role)
      1 perl(Try::Tiny)
      1 perl(namespace::autoclean) >= 0.24
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-MooseX-Meta-TypeConstraint-Mooish-0.001-1.fc23.noarch.rpm | sort | uniq -c
      1 perl(MooseX::Meta::TypeConstraint::Mooish) = 0.001
      1 perl(MooseX::TraitFor::Meta::TypeConstraint::Mooish) = 0.001
      1 perl-MooseX-Meta-TypeConstraint-Mooish = 0.001-1.fc23
Binary provides are Ok.

$ rpmlint perl-MooseX-Meta-TypeConstraint-Mooish*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok


Package is good.
APPROVED.

Comment 2 Petr Pisar 2015-04-09 10:44:53 UTC
New Package SCM Request
=======================
Package Name: perl-MooseX-Meta-TypeConstraint-Mooish
Short Description: Translate Moo-style constraints to Moose-style
Upstream URL: http://search.cpan.org/dist/MooseX-Meta-TypeConstraint-Mooish/
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2015-04-09 12:51:44 UTC
Git done (by process-git-requests).

Comment 4 Petr Pisar 2015-04-09 13:26:37 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.