Bug 1210610 - Review Request: perl-Mojolicious-Plugin-CHI - Use CHI Caches in Mojolicious
Summary: Review Request: perl-Mojolicious-Plugin-CHI - Use CHI Caches in Mojolicious
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-04-10 07:53 UTC by Emmanuel Seyman
Modified: 2015-05-14 09:57 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-05-14 09:57:46 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Emmanuel Seyman 2015-04-10 07:53:44 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Mojolicious-Plugin-CHI/perl-Mojolicious-Plugin-CHI.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Mojolicious-Plugin-CHI/perl-Mojolicious-Plugin-CHI-0.11-1.fc21.src.rpm
Description:
Mojolicious::Plugin::CHI is a simple plugin to work with CHI caches within
Mojolicious.

Fedora Account System Username: eseyman
Rpmlint output: 1 packages and 1 specfiles checked; 0 errors, 0 warnings.

Comment 1 Jitka Plesnikova 2015-04-10 14:50:32 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Mojolicious-Plugin-CHI-0.11-1.fc23.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.20.2)
      1 perl(CHI)
      1 perl(Getopt::Long)
      1 perl(Mojo::Base)
      1 perl(Mojo::Util)
      1 perl(Scalar::Util)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Mojolicious-Plugin-CHI-0.11-1.fc23.noarch.rpm | sort | uniq -c
      1 perl(Mojolicious::Plugin::CHI) = 0.11
      1 perl(Mojolicious::Plugin::CHI::chi)
      1 perl-Mojolicious-Plugin-CHI = 0.11-1.fc23
Binary provides are Ok.

$ rpmlint perl-Mojolicious-Plugin-CHI*
./perl-Mojolicious-Plugin-CHI*
perl-Mojolicious-Plugin-CHI.noarch: E: script-without-shebang /usr/share/licenses/perl-Mojolicious-Plugin-CHI/LICENSE
perl-Mojolicious-Plugin-CHI.noarch: E: script-without-shebang /usr/share/perl5/vendor_perl/Mojolicious/Plugin/CHI/chi.pm
perl-Mojolicious-Plugin-CHI.noarch: E: script-without-shebang /usr/share/perl5/vendor_perl/Mojolicious/Plugin/CHI.pm
perl-Mojolicious-Plugin-CHI.noarch: W: spurious-executable-perm /usr/share/doc/perl-Mojolicious-Plugin-CHI/Changes
2 packages and 1 specfiles checked; 3 errors, 1 warnings.
Rpmlint reported some errors.

FIX: Permission of following files in %prep section
* Changes
* LICENSE
* lib/Mojolicious/Plugin/CHI/chi.pm
* lib/Mojolicious/Plugin/CHI.pm
E.g.
find lib -type f -exec chmod -c -x {} ';'
chmod -c -x Changes LICENSE


Please fix the permission and provide updated files.
Package is not approved.

Comment 3 Jitka Plesnikova 2015-04-13 06:28:49 UTC
> FIX: Permission of following files in %prep section
> * Changes
> * LICENSE
> * lib/Mojolicious/Plugin/CHI/chi.pm
> * lib/Mojolicious/Plugin/CHI.pm
> E.g.
> find lib -type f -exec chmod -c -x {} ';'
> chmod -c -x Changes LICENSE
> 
Solved.

$ rpmlint perl-Mojolicious-Plugin-CHI.spec perl-Mojolicious-Plugin-CHI-0.11-2.*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.


Otherwise package is good.
Approved.

Comment 4 Emmanuel Seyman 2015-04-13 07:57:48 UTC
Thank you, Jikta. Requesting SCM.

New Package SCM Request
=======================
Package Name: perl-Mojolicious-Plugin-CHI
Short Description: Use CHI Caches in Mojolicious
Upstream URL: http://search.cpan.org/dist/Mojolicious-Plugin-CHI/
Owners: eseyman
Branches: f22 f21
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2015-04-13 19:25:11 UTC
Git done (by process-git-requests).

Comment 6 Emmanuel Seyman 2015-05-14 09:57:46 UTC
Built for rawhide.


Note You need to log in before you can comment on or make changes to this bug.