Bug 1210612 - Review Request: perl-Mojolicious-Plugin-RenderFile - Mojolicious plugin allowing customization to force file download
Summary: Review Request: perl-Mojolicious-Plugin-RenderFile - Mojolicious plugin allow...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-04-10 08:04 UTC by Emmanuel Seyman
Modified: 2015-05-14 10:05 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-05-14 09:57:49 UTC
Type: ---
Embargoed:
psabata: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Emmanuel Seyman 2015-04-10 08:04:12 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Mojolicious-Plugin-RenderFile/perl-Mojolicious-Plugin-RenderFile.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Mojolicious-Plugin-RenderFile/perl-Mojolicious-Plugin-RenderFile-0.09-1.fc21.src.rpm
Description:
Mojolicious::Plugin::RenderFile is a Mojolicious plugin that adds
"render_file" helper. It does not read file in memory and just streaming it
to a client.

Fedora Account System Username: eseyman
Rpmlint output: 1 packages and 1 specfiles checked; 0 errors, 0 warnings.

Comment 1 Petr Šabata 2015-04-10 15:10:12 UTC
The description and summary are weird.  Edit it so it makes sense and is grammatically correct.

No other issues.

Comment 3 Petr Šabata 2015-04-13 10:59:47 UTC
Much better.  Approving.

Comment 4 Emmanuel Seyman 2015-04-13 11:03:50 UTC
Thanks, Petr.

New Package SCM Request
=======================
Package Name: perl-Mojolicious-Plugin-RenderFile
Short Description: Mojolicious plugin allowing customization to force file download
Upstream URL: http://search.cpan.org/dist/Mojolicious-Plugin-RenderFile/
Owners: eseyman
Branches: f22 f21
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2015-04-13 19:25:37 UTC
Git done (by process-git-requests).

Comment 6 Petr Šabata 2015-05-14 08:56:13 UTC
Just a ping on this one.

Comment 7 Emmanuel Seyman 2015-05-14 09:54:40 UTC
I was looking at my Bugzilla dashboard and noticed that this review was still open despite the package having been mashed in rawhide a month ago. I'll close this in a few minutes.

Comment 8 Emmanuel Seyman 2015-05-14 09:57:49 UTC
Built for rawhide.

Comment 9 Petr Šabata 2015-05-14 10:05:12 UTC
Well, you requested f21/f22 branches too.  I saw an f22 build failure in koji and wasn't sure whether you were working on it or not.


Note You need to log in before you can comment on or make changes to this bug.