Description of problem:

We auto-generate the network config for all our hosts. After a change in the auto-generation tool, config items now look like

NETMASK='255.255.255.255.0'

i.e. they use single quotes. This works fine since the network scripts will use the "source" command to include the configs. So any valid shell syntax will do the job.

The only exception is the MASTER variable in the configuration files of ethernet devices when a bonding is configured. This is because /etc/sysconfig/network-scripts/ifup-eth uses the code

    for device in $(LANG=C grep -l "^[[:space:]]*MASTER=\"\?${DEVICE}\"\?\([[:space:]#]\|$\)" /etc/sysconfig/network-scripts/ifcfg-*) ; do

to find the individual devices for a bond. Note that the regular expression accepts double quotes or no quotes, but not single quotes. Essentially, the regular expression tries to parse shell scripts, which is not trivial. It sounds like a better idea to let the shell parse the shell script:

    for device in /etc/sysconfig/network-scripts/ifcfg-*; do
        if [ $(source $config; echo -n $MASTER) == ${DEVICE} ]; then

This will work for any kind of quoting, escaping or other strange stuff that is valid shell syntax.

A very similar issue exists in the ifdown-eth script.



How reproducible:

100%

Steps to Reproduce:

1. Configure a bond of 2 Ethernet NICs.

2. Change the quoting around the MASTER variable in /etc/sysconfig/network-scripts/ifcfg-eth* to use single quotes like

MASTER='bond0'

3. After "service network restart", the bond does not work.