Spec URL: http://ralph.fedorapeople.org//python-munch.spec
SRPM URL: http://ralph.fedorapeople.org//python-munch-2.0.2-1.fc21.src.rpm
munch is a fork of David Schoonover's **Bunch** package, providing similar
functionality. 99% of the work was done by him, and the fork was made
mainly for lack of responsiveness for fixes and maintenance on the original
Munch is a dictionary that supports attribute-style access, a la
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9462321
You can drop the python2_sitearch definition at the top since you don't need it.
Otherwise spec file looks clean
* Using the sources from upstream:
* License MIT is valid, present in the sources and installed correctly in the spec file
* Spec file looks good
! rpmlint output can be improved:
python-munch.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/munch/__init__.py 0644L /usr/bin/env
python3-munch.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/munch/__init__.py 0644L /usr/bin/env
3 packages and 0 specfiles checked; 2 errors, 0 warnings.
Maybe https://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries could help
After this I'll approve the review
Done. Removed shebang to make rpmlint happy.
Spec URL: http://threebean.org/rpm/SPECS/python-munch.spec
SRPM URL: http://threebean.org/rpm/SRPMS/python-munch-2.0.2-2.fc21.src.rpm
OK, this package is APPROVED.
New Package SCM Request
Package Name: python-munch
Upstream URL: https://pypi.python.org/pypi/munch
Branches: f22 f21 f20 epel7 el6
Git done (by process-git-requests).
python-munch-2.0.2-2.el7 has been submitted as an update for Fedora EPEL 7.
python-munch-2.0.2-2.fc22 has been submitted as an update for Fedora 22.
python-munch-2.0.2-2.fc21 has been submitted as an update for Fedora 21.
python-munch-2.0.2-2.fc20 has been submitted as an update for Fedora 20.
python-munch-2.0.2-2.fc22 has been pushed to the Fedora 22 stable repository.
python-munch-2.0.2-2.fc20 has been pushed to the Fedora 20 stable repository.
python-munch-2.0.2-2.fc21 has been pushed to the Fedora 21 stable repository.
python-munch-2.0.2-2.el7 has been pushed to the Fedora EPEL 7 stable repository.