Bug 1210983 - Review Request: python-vcrpy - Automatically mock your HTTP interactions to simplify and speed up testing
Summary: Review Request: python-vcrpy - Automatically mock your HTTP interactions to s...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Pierre-YvesChibon
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1210978 1210982
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-04-11 20:15 UTC by Ralph Bean
Modified: 2016-03-29 01:19 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-03-29 01:19:21 UTC
Type: ---
Embargoed:
pingou: fedora-review+


Attachments (Terms of Use)

Description Ralph Bean 2015-04-11 20:15:49 UTC
Spec URL: http://ralph.fedorapeople.org//python-vcrpy.spec
SRPM URL: http://ralph.fedorapeople.org//python-vcrpy-1.4.0-1.fc21.src.rpm

Description:
Simplify and speed up testing HTTP by recording all HTTP interactions and
saving them to "cassette" files, which are yaml files containing the contents
of your requests and responses.  Then when you run your tests again, they all
just hit the text files instead of the internet.  This speeds up your tests and
lets you work offline.

If the server you are testing against ever changes its API, all you need to do
is delete your existing cassette files, and run your tests again.  All of the
mocked responses will be updated with the new API.

Comment 1 Pierre-YvesChibon 2015-05-06 08:52:59 UTC
Note: This package won't build on F21

Comment 2 Pierre-YvesChibon 2015-05-06 09:05:02 UTC
! Changelog is invalid
! Spec in the srpm is different from the spec linked to here
! Using the spec file linked to here, I fail to rebuild this package in mock
mock --rebuild ~/rpmbuild/SRPMS/python-vcrpy-1.4.0-1.fc21.src.rpm -r fedora-22-x86_64
output: http://fpaste.org/218906/43090307/

Comment 3 Ralph Bean 2015-05-06 13:53:46 UTC
Sorry about that.  I must've been in a rush at PyCon.

Here's a latest upstream rebuild with some fixes to the specfile:

Spec URL: http://threebean.org/rpm/SPECS/python-vcrpy.spec
SRPM URL: http://threebean.org/rpm/SRPMS/python-vcrpy-1.4.2-1.fc21.src.rpm

Comment 4 Pierre-YvesChibon 2015-05-06 14:24:44 UTC
* Rpmlint can safely be ignored:
python3-vcrpy.noarch: W: spelling-error %description -l en_US yaml -> yam, yams, yawl
python3-vcrpy.noarch: W: no-documentation
python-vcrpy.noarch: E: explicit-lib-dependency python-contextlib2
python-vcrpy.noarch: E: explicit-lib-dependency python3-contextlib2
python-vcrpy.noarch: W: spelling-error %description -l en_US yaml -> yam, yams, yawl
python-vcrpy.noarch: W: no-documentation
python-vcrpy.src: W: spelling-error %description -l en_US yaml -> yam, yams, yawl
python-vcrpy.src:135: W: macro-in-comment %doc
python-vcrpy.src:136: W: macro-in-comment %license
python-vcrpy.src:144: W: macro-in-comment %doc
python-vcrpy.src:145: W: macro-in-comment %license
3 packages and 0 specfiles checked; 2 errors, 9 warnings.

* Spec is clean
* License is MIT and is shipped in the sources
! The LICENSE and README file can now be marked as %doc
* No bundle in the sources
* Builds cleanly on F22 (via mock) (not in F21 but that's likely an updates-testing issue)
* Consistent usage of the macros
* Upstream sources:
6f40f3e0fbde03ca44ccdff2711cac39dcd6d2354795582f8bf6f98376fa0b62  vcrpy-1.4.2.tar.gz
* srpm sources:
6f40f3e0fbde03ca44ccdff2711cac39dcd6d2354795582f8bf6f98376fa0b62  python-vcrpy-1.4.2-1.fc21.src/vcrpy-1.4.2.tar.gz

This looks all good to me

This package is APPROVED

Comment 5 Fedora Update System 2015-05-14 21:30:42 UTC
python-vcrpy-1.4.2-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/python-vcrpy-1.4.2-1.fc22

Comment 6 Fedora Update System 2015-05-16 11:51:38 UTC
python-vcrpy-1.5.2-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/python-vcrpy-1.5.2-1.fc22

Comment 7 Fedora Update System 2015-05-26 03:15:19 UTC
python-vcrpy-1.5.2-1.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.