Spec URL: http://files.braun-jones.org/qt5-qtwebchannel.spec SRPM URL: http://files.braun-jones.org/qt5-qtwebchannel-5.4.1-1.el7.centos.src.rpm Description: The Qt WebChannel module provides a library for seamless integration of C++ and QML applications with HTML/JavaScript clients. Any QObject can be published to remote clients, where its public API becomes available. Fedora Account System Username: nocnokneo Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9463055
$ rpmlint qt5-qtwebchannel qt5-qtwebchannel-devel qt5-qtwebchannel.x86_64: W: incoherent-version-in-changelog 5.4.0-1 ['5.4.1-1.fc22', '5.4.1-1'] qt5-qtwebchannel.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libQt5WebChannel.so.5.4.1 /lib64/libQt5Network.so.5 qt5-qtwebchannel.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libQt5WebChannel.so.5.4.1 /lib64/libpthread.so.0 qt5-qtwebchannel.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libQt5WebChannel.so.5.4.1 /lib64/libm.so.6 qt5-qtwebchannel.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libQt5WebChannel.so.5.4.1 /lib64/libgcc_s.so.1 qt5-qtwebchannel-devel.x86_64: W: only-non-binary-in-usr-lib qt5-qtwebchannel-devel.x86_64: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 7 warnings. mostly harmless naming: ok, matches standard naming of other qt5- modules in distro license: ok sources: ok $ md5sum *.xz bb914134c164c6758a0074748cc678ff qtwebchannel-opensource-src-5.4.1.tar.xz builds/installs: ok macros: ok scriptlet: ok looks like the qt5-qtwebsocket build dependency is optional and only for some examples, but using it here is mostly harmless. Probably worth adding a .spec comment about this, in case it helps bootstrapping new archs. Otherwise, thanks, looks good, APPROVED
If you don't mind, please add group:kde-sig as comaintainer for this package when submitting scm request.
(In reply to Rex Dieter from comment #1) > looks like the qt5-qtwebsocket build dependency is optional and only for > some examples, but using it here is mostly harmless. Probably worth adding > a .spec comment about this, in case it helps bootstrapping new archs. Fixed with comment explanation.
New Package SCM Request ======================= Package Name: qt5-qtwebchannel Short Description: Qt5 WebChannel component Upstream URL: http://qt.io Owners: nocnokneo group:kde-sig Branches: f20 f21 f22 el6 epel7 InitialCC:
Sorry, checking other reviews, looks like the correct syntax is group::kde-sig
New Package SCM Request ======================= Package Name: qt5-qtwebchannel Short Description: Qt5 WebChannel component Upstream URL: http://qt.io Owners: nocnokneo group::kde-sig Branches: f20 f21 f22 el6 epel7 InitialCC:
Git done (by process-git-requests).
imported into rawhide awhile back.