Bug 1211529 - Review Request: docker-machine - Tool for managing Docker hosts
Summary: Review Request: docker-machine - Tool for managing Docker hosts
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Chaloupka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2015-04-14 08:59 UTC by Lokesh Mandvekar
Modified: 2020-06-13 15:38 UTC (History)
11 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-06-13 15:38:47 UTC
Type: ---
Embargoed:
jchaloup: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
spec file modifications (1.52 KB, patch)
2015-04-14 10:52 UTC, Jan Chaloupka
no flags Details | Diff

Description Lokesh Mandvekar 2015-04-14 08:59:03 UTC
Spec URL: https://lsm5.fedorapeople.org/docker-machine/docker-machine.spec
SRPM URL: https://lsm5.fedorapeople.org/docker-machine/SRPMS/docker-machine-0-0.1.gite4c2173.fc23.src.rpm

Description:
Machine makes it really easy to create Docker hosts on your computer, on
cloud providers and inside your own data center. It creates servers, installs
Docker on them, then configures the Docker client to talk to them.

Fedora Account System Username: lsm5

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=9475292

Comment 1 Jan Chaloupka 2015-04-14 10:52:00 UTC
OK
- list of provides
- license
- binary is build from bundled source codes (lets keep all its deps up2date at least and package new packages)

not OK
- missing debug info

Check of dependencies from Godeps.json

$ gofed check-deps Godeps.json
golang-googlecode-goauth2: upstream commit afe77d958c701557ec5dc56f6936fcc194d15520 not found
import path github.com/MSOpenTech/azure-sdk-for-go not found
import path github.com/cenkalti/backoff not found
package golang-github-codegangsta-cli outdated
import path github.com/digitalocean/godo not found
docker-io: upstream commit a8a31eff10544860d2188dddabdee4d727545796 not found
import path github.com/docker/docker/vendor/src/code.google.com/p/go/src/pkg/archive/tar not found
package golang-github-docker-libtrust outdated
import path github.com/google/go-querystring/query not found
package golang-github-rackspace-gophercloud outdated
import path github.com/skarademir/naturalsort not found
import path github.com/smartystreets/go-aws-auth not found
import path github.com/tent/http-link-go not found
import path github.com/vmware/govcloudair not found
package golang-googlecode-go-crypto not found in golang.repos

There are 8 new packages so far (direct ones).


As some golang packages still break API building tools from dependencies is possible but can lead to missing or modified symbols during building. Building from bundled source codes handle this situation. However we should keep all its dependencies up2date and debundle them anyway. As one day dependencies's API get stable we can then easily switch to packaged dependencies.

Comment 2 Jan Chaloupka 2015-04-14 10:52:34 UTC
Created attachment 1014245 [details]
spec file modifications

Comment 3 Jan Chaloupka 2015-04-16 23:02:56 UTC
11 new packages for this:

github.com/MSOpenTech/azure-sdk-for-go (ASL 2.0)
    github.com/Azure/go-pkcs12 (MIT)
        github.com/ebfe/rc2 (no LICENSE)
github.com/digitalocean/godo (MIT)
    github.com/google/go-querystring (BSD)
    github.com/tent/http-link-go (BSD)

github.com/skarademir/naturalsort (MIT)
github.com/smartystreets/go-aws-auth (MIT)
    github.com/smartystreets/goconvey (MIT)
github.com/vmware/govcloudair (ASL 2.0)
    github.com/cenkalti/backoff (ASL 2.0)

github.com/ebfe/rc2 has no LICENSE, lets see what can be done.

Comment 4 Jan Chaloupka 2015-04-16 23:07:20 UTC
https://github.com/tqbf/rc2/issues/2

Comment 5 Jan Chaloupka 2015-04-26 17:12:41 UTC
So docker-machine actually uses only (515f3ec74ce6a5b31e934cefae997c97bd0a1b1e commit):

github.com/MSOpenTech/azure-sdk-for-go
github.com/MSOpenTech/azure-sdk-for-go/clients/vmClient

clients directory is removed in the latest commit. Tests (go tests) run on 515f3ec74ce6a5b31e934cefae997c97bd0a1b1e are failing because of removed IdleConnKeysForTesting symbol from http.Transport. 

Looking at the latest golang [1] there is no IdleConnKeysForTesting provided by Transport structure.

So we can package it (outdated and likely failing for all other packages) or skip this package and wait until docker-machine starts using version 1.2 or newer. As 515f3ec74ce6a5b31e934cefae997c97bd0a1b1e commit of MSOpenTech does not need github.com/ebfe/rc2, we don't have to package it. And author of tqbf/rc2 (ebfe/rc2 forked it) does not wish it to be packaged as it is not safe.

[1] http://golang.org/pkg/net/http/#Transport

Comment 6 Robert P. J. Day 2015-09-15 08:04:08 UTC
Is there any ETA for this package? And docker-swarm as well?

Comment 7 Jan Chaloupka 2015-09-15 08:37:45 UTC
Hi Robert, how much urgent/important is this for you?

Comment 8 Robert P. J. Day 2015-09-15 08:43:02 UTC
It's not *urgent*, but it would at least be nice to have an idea of when it will show up, given that there has been no activity on this BZ filing for a few months. Being available with Fedora 23 would be fine with me, I would just like some clue as to progress.

Comment 9 Lokesh Mandvekar 2015-09-15 13:26:30 UTC
Hi Robert, i'll get on with this soon after I have docker-distribution into Fedora. Sorry, been many distractions lately :|.

Comment 10 Robert P. J. Day 2015-09-15 13:30:23 UTC
No problem ... part of my interest is that I'm writing a couple courses in Docker that I mean to teach on Fedora, and I'm trying to keep track of all the relevant Fedora packages on a wiki page here:

http://www.crashcourse.ca/wiki/index.php/Docker_on_Fedora

so as soon as new/updated Fedora packages become available, I'll update my list. Thanks for your time.

Comment 11 Lokesh Mandvekar 2015-09-15 13:33:56 UTC
Robert, would you like to be co-maintainer of docker-swarm/docker-machine? In case you're sponsored already you can take this review ahead, if not we could get a sponsor to review this. That'd kinda take care of the bottleneck issue(me). Totally fine if you don't want to :). I'll get this going asap.

Comment 12 Robert P. J. Day 2015-09-15 13:38:46 UTC
Not sponsored yet, but I'm willing to give it a shot. Makes sense given that I'm the one whining so relentlessly about it. Where do I start? Is there a doc to read to give me a clue as to how this works?

If you want to take this offline, I'm username "rpjday" at the URL given in my last comment.

Comment 13 Lokesh Mandvekar 2015-09-16 15:06:54 UTC
See: https://fedoraproject.org/wiki/How_to_create_an_RPM_package

If you'd like to go through with that, feel free to clone this bug with links to srpm and spec files, and we'll try and get a sponsor to review it and get you into the packager group.

Comment 14 Jan Chaloupka 2015-09-16 15:19:37 UTC
The latest current release is 0.4.1 [1]. So the spec file should be regenerated. The same holds for deps. It could have new. Besides, the latest gofed reduces the number of deps.

Robert, to generate spec file, you can use gofed [2]. Let me know if there is something that is not clear. In case, you decide to use it. It generates the spec file with the best effort.

[1] https://github.com/docker/machine/releases/tag/v0.4.1
[2] https://github.com/ingvagabund/gofed

Comment 15 Robert P. J. Day 2015-09-16 17:34:19 UTC
I've played with creating simple RPM packages before so this isn't entirely new to me ... I'll tackle this on the weekend.

Comment 16 Upstream Release Monitoring 2015-09-24 15:05:12 UTC
jgrulich's scratch build of kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 for f22-candidate and git://pkgs.fedoraproject.org/kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11212117

Comment 17 Lokesh Mandvekar 2015-09-30 16:19:00 UTC
(In reply to Upstream Release Monitoring from comment #16)
> jgrulich's scratch build of
> kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 for f22-candidate and
> git://pkgs.fedoraproject.org/
> kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 completed
> http://koji.fedoraproject.org/koji/taskinfo?taskID=11212117

probably wrong bz used in bodhi :)

Comment 19 Jan Chaloupka 2015-09-30 18:25:41 UTC
Spec file is ok, no need to generate it via gofed. As it depends on docker, it has to be built from tarball. Would be great to generate entire spec file and just set with_bundled 1 and with_devel 0. This was it can be switch to Fedora deps at any time without additional work.

Approving.

Comment 20 Lokesh Mandvekar 2015-09-30 22:01:50 UTC
New Package SCM Request
=======================
Package Name: docker-machine 
Short Description: Tool for managing Docker hosts
Upstream URL: https://github.com/docker/machine
Owners: lsm5 jchaloup fpokorny
Branches: f23 f22 f21
InitialCC: golang-sig

Comment 21 Gwyn Ciesla 2015-10-01 12:52:57 UTC
Git done (by process-git-requests).

Comment 22 Yajo 2016-02-19 08:16:28 UTC
Any news on this?

Comment 23 Jan Chaloupka 2016-02-23 12:04:58 UTC
Lokesh' links to spec seems to be lost. Lokesh, do you have a backup?

Comment 24 Yajo 2016-10-14 08:09:23 UTC
Ping! :)

Comment 25 Lokesh Mandvekar 2017-11-13 14:27:33 UTC
sorry, 2 years too late on this :\ ... and yup, seems like I ended up deleting spec files. THe dist-git seems to be created already, so maybe someone interested can post spec files again and I can review it for them.

Comment 26 Mattia Verga 2020-06-13 15:38:47 UTC
I'm going to close this as dead review, package has been retired from Rawhide.


Note You need to log in before you can comment on or make changes to this bug.