Bug 1211762 - [RFE] OVF_STORE disks should be filtered out in the views in Admin Portal
Summary: [RFE] OVF_STORE disks should be filtered out in the views in Admin Portal
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: RFEs
Version: 3.5.0
Hardware: All
OS: Linux
medium
medium
Target Milestone: ovirt-4.2.0
: ---
Assignee: Tal Nisan
QA Contact: Raz Tamir
URL:
Whiteboard:
: 1131508 (view as bug list)
Depends On:
Blocks: 902971
TreeView+ depends on / blocked
 
Reported: 2015-04-14 20:06 UTC by Marina Kalinin
Modified: 2019-04-28 13:53 UTC (History)
10 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-12-20 11:33:44 UTC
oVirt Team: Storage
Embargoed:
amureini: ovirt-4.2?
gklein: testing_plan_complete-
rule-engine: planning_ack?
rule-engine: devel_ack+
rule-engine: testing_ack+


Attachments (Terms of Use)
Content Type radio selection (110.34 KB, image/png)
2017-10-24 10:33 UTC, Allon Mureinik
no flags Details

Description Marina Kalinin 2015-04-14 20:06:01 UTC
OVF_STORE disks should be filtered out in the views in Admin Portal.
Both from the Disks Tab, since those are not regular disks and their representation is confusing.
And from the Attach Dialogue for VM's Add Disk feature, since those disks cannot be attached to VM anyway.
Right now it just clutters the view.

On the disks tab, those disk can be showed, but not together with other regular images. Or, at least, that should be marked somehow as different disks.

Comment 1 Tal Nisan 2015-04-15 11:45:07 UTC
Not sure it's right to filter them out completely, they are still images existing in the storage domain and the admin should probably know about their existence and maybe also for backup issues.
We can maybe filter it out on their own rubric such as the filtering in All disks/Images/LUNs, we can add OVF disks there
Allon, what do you think?

Comment 2 Einav Cohen 2015-04-15 14:35:04 UTC
seems like a "duplicate" of bug 1131508 (this one is RHEV, bug 1131508 is oVirt).

Comment 3 Allon Mureinik 2015-04-16 06:20:39 UTC
(In reply to Tal Nisan from comment #1)
> Not sure it's right to filter them out completely, they are still images
> existing in the storage domain and the admin should probably know about
> their existence and maybe also for backup issues.
> We can maybe filter it out on their own rubric such as the filtering in All
> disks/Images/LUNs, we can add OVF disks there
> Allon, what do you think?

The admin should be able to see these, although I agree they probably don't fit the default view.

Looking forward, we should have two types of filters:
1. The disk TYPE - image, direct lun or cinder
2. The disk FUNCTION - data (most of our disks), ovf_store, memory_volume (Arik Hadas is working on it).

The default filtering should be all storage types for data only.

Comment 4 Yaniv Lavi 2016-12-05 13:42:12 UTC
*** Bug 1131508 has been marked as a duplicate of this bug. ***

Comment 5 Allon Mureinik 2017-10-24 10:32:51 UTC
In 4.2, a new radio selection was added for Content Type.
The default display is "all" (in order to keep backwards compatibility), but you can select specific types, such as data (see attached screenshot)

Comment 6 Allon Mureinik 2017-10-24 10:33:48 UTC
Created attachment 1342684 [details]
Content Type radio selection

Comment 7 Raz Tamir 2017-10-26 14:59:39 UTC
Hi,

I need more information about the expected results (from comment #0):

"... from the Attach Dialogue for VM's Add Disk feature, since those disks cannot be attached to VM anyway."
--> This is not the actual results

"On the disks tab, those disk can be showed, but not together with other regular images. "
--> This is not the actual results

Comment 8 Tal Nisan 2017-10-29 11:12:57 UTC
The actual results should be that the disks in the main disks tab can be filtered according to their content type, there should also be an option to show all the disks as well.
As for the attach option, a separate bug can be opened for that as not only OVF disks should be filtered but any disk that is not a DATA disk

Comment 9 Raz Tamir 2017-10-30 09:04:19 UTC
Thanks Tal.
Opened https://bugzilla.redhat.com/show_bug.cgi?id=1507426

This bug verified on ovirt-engine-4.2.0-0.0.master.20171027213842.gitded437c.el7.centos

Comment 10 Sandro Bonazzola 2017-12-20 11:33:44 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.