With: kernel-4.1.0-0.rc0.git1.1.fc23.x86_64 or kernel-4.1.0-0.rc0.git2.1.fc23.x86_64 3 finger tapping no longer works. Works with kernel-4.0.0-1.fc23.x86_64
Created attachment 1014953 [details] 3fg-tap evemu recording Evemu recording showing the issue (from Bug 1209151, see also attachment 1014925 [details]). With the new kernel tracking, the touchpad now claims it has 3 slots instead of 2 (hw only does 2). In the second frame, the kernel opens another slot for the jumping touch when the third finger is down, but closes slot 1. So we now have two slots active, but BTN_TOOL_TRIPLETAP is set. What libinput sees is one touch disappearing and another one starting in the same frame, i.e. you go from 2 touches to 2 touches. libinput ignores BTN_TOOL_* for any number less than num_slots. That's a regression in the kernel IMO, we always relied on the BTN_TOOL_* only to be set when the matching number of slots is open too (where supported by the HW). Synaptics would likely break with this too. We can't work around the event sequence either, we must handle the above behaviour on clickpads where users may lift the index finger in the same frame as they are putting their thumb down to physically click. synaptics used to have a bug where it would wrongly trigger a two-finger click in that case. So now we have the code counting only active touches at SYN_REPORT time. Benjamin already has a good idea on how to fix this in the kernel though.
Created attachment 1015305 [details] 0001-Input-synaptics-pin-3-touches-when-the-firmware-repo.patch Proposed patch to fix the issue. I am not a pro of the tap to click, so I'd like to get some more feedback before submitting this upstream. You can find a scratch build here with the patch applied: http://koji.fedoraproject.org/koji/taskinfo?taskID=9494204
Grmbl... I messed up with the arches for the scratch build. The new one: http://koji.fedoraproject.org/koji/taskinfo?taskID=9494269
3 finger tap works again with that scratch built kernel. :) thanks.
Patch added to 4.1.0-0.rc0.git7.1.fc23. Thanks!
FWIW, patch submitted upstream: https://patchwork.kernel.org/patch/6256771/
This seems to be back with 4.1.0-0.rc3.git0.1.fc23.x86_64. :( Happy to provide more info...
(In reply to Kevin Fenzi from comment #7) > This seems to be back with 4.1.0-0.rc3.git0.1.fc23.x86_64. That is weird. The patch that fixes this is still in this particular kernel, so either there is something else in the kernel which prevents the triple tap to be seen or libinput failed to recognize it. Can you attach a new evemu-recording of the misrecognized gesture with the updated kernel?
ok. I swear it wasn't working, but rebooted to the latest kernel and now it is. :( Sorry for the noise.
I've added the various patches for this issue to the f21 and f22 trees now as well.
kernel-4.0.6-300.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/kernel-4.0.6-300.fc22
kernel-4.0.6-200.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/kernel-4.0.6-200.fc21
kernel-4.0.6-300.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
kernel-4.0.6-200.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.
sigh, Josh, please revert the three patches, they trigger a regression, see bug 1236540. If the fingers are close together, the touchpad still sends two touches but the ABS_MT_SLOT event is missing now. Can be reproduced quite easily on a T440s. Actual trigger is the first patch, but I'll let Benjamin figure out what to do with the other two. The patches are Patch26238: Input-Revert-Revert-synaptics-use-dmax-in-input_mt_a.patch Patch26239: Input-synaptics-allocate-3-slots-to-keep-stability-i.patch Patch26240: Input-synaptics-pin-3-touches-when-the-firmware-repo.patch Thanks.
*** Bug 1236540 has been marked as a duplicate of this bug. ***
*** Bug 1236642 has been marked as a duplicate of this bug. ***
(In reply to Peter Hutterer from comment #15) > sigh, Josh, please revert the three patches, they trigger a regression, see > bug 1236540. > > If the fingers are close together, the touchpad still sends two touches but > the ABS_MT_SLOT event is missing now. Can be reproduced quite easily on a > T440s. > Actual trigger is the first patch, but I'll let Benjamin figure out what to > do with the other two. > > The patches are > Patch26238: Input-Revert-Revert-synaptics-use-dmax-in-input_mt_a.patch > Patch26239: Input-synaptics-allocate-3-slots-to-keep-stability-i.patch > Patch26240: Input-synaptics-pin-3-touches-when-the-firmware-repo.patch I've commented them out in the spec so they are no longer applied. If there are alternative patches, we can add those.
*** Bug 1241685 has been marked as a duplicate of this bug. ***
kernel-4.0.8-200.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/kernel-4.0.8-200.fc21
Package kernel-4.0.8-200.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing kernel-4.0.8-200.fc21' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-11589/kernel-4.0.8-200.fc21 then log in and leave karma (feedback).
*** Bug 1236425 has been marked as a duplicate of this bug. ***
kernel-4.0.8-200.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.
On my Lenovo T440 with Fedora 22, problem solved. Thank you.