Created attachment 1015345 [details] List of (mostly) MSDN isos, --test-media-detection output and isoinfo -d -i readings. Description of problem: Many ISOs are not correctly identified by e.g. virt-install --test-media-detection. Version-Release number of selected component (if applicable): Fedora 22, RC2. libosinfo 0.2.11-2.fc22 How reproducible: 100% Steps to Reproduce: 1. run virt-install --test-media-detection <msdn.iso> Actual results: "None" is often printed. Expected results: "win7," "win8," etcetera as appropriate. Additional info: Please see attached file for a large dump of ISO information compared against the outputs of --test-media-detection from virt-install.
Created attachment 1015485 [details] Patch adding new test data to tests/isodata As a first step towards fixing this bug, this patch adds the data you provided to libosinfo/tests/isodata/, tests/test-isodetect can then be used to point out which images are missing from data/oses/ Couple of notes: - I think some of the RHEL test cases are already present with a different name, but I blindly added the new ones - your text file included some virtio-win images which I did not add in this patch Next step is to fill data/oses/ so that make check passes with all these new test cases, but this is work for another day... ;) Thanks a lot for providing all this data!
Moving this bug upstream
This has been fixed upstream by the commits between https://git.fedorahosted.org/cgit/libosinfo.git/commit/?id=cdadfbe76617883fa5ea567b888cee0b505b73e0 and https://git.fedorahosted.org/cgit/libosinfo.git/commit/?id=12717aced02d4180af25d4bc911f4af9bf149039 Only xubuntu has not been added (but I may have missed a few other isos while doing this!)
I'm closing the bug as current release, as these patches got in for 0.3.0.