Bug 1213096 - Traceback during kickstart with --encrypt and no --passphrase, no prompt for PP:Skipping sanity check in GUI
Summary: Traceback during kickstart with --encrypt and no --passphrase, no prompt for ...
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: 21
Hardware: x86_64
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Vojtech Trefny
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-04-18 20:50 UTC by Rick
Modified: 2015-12-03 13:01 UTC (History)
6 users (show)

Fixed In Version: anaconda-23.17-1
Clone Of:
Environment:
Last Closed: 2015-12-02 19:24:08 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Anaconda traceback log (truncated for clarity and privacy) (6.25 KB, text/plain)
2015-04-18 20:50 UTC, Rick
no flags Details
file generated by %pre which shows the partition configuration that resulted in the TB (282 bytes, text/plain)
2015-04-18 20:52 UTC, Rick
no flags Details
log file from Anaconda during the install that made the TB (11.19 KB, text/plain)
2015-04-18 20:53 UTC, Rick
no flags Details
Kickstart file I was using (3.03 KB, text/plain)
2015-04-18 20:59 UTC, Rick
no flags Details
Working kickstart for showing error (1.74 KB, text/plain)
2015-04-21 16:54 UTC, mulhern
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1060255 1 None None None 2021-01-20 06:05:38 UTC
Red Hat Bugzilla 1139222 1 None None None 2021-09-03 14:10:33 UTC
Red Hat Bugzilla 1185466 1 None None None 2021-01-20 06:05:38 UTC
Red Hat Bugzilla 1215689 0 medium CLOSED traceback on kickstart --encrypted without --passphrase= 2021-02-22 00:41:40 UTC

Internal Links: 1060255 1139222 1185466 1215689

Description Rick 2015-04-18 20:50:42 UTC
Created attachment 1015951 [details]
Anaconda traceback log (truncated for clarity and privacy)

Description of problem:



Version-Release number of selected component (if applicable):

Fedora 21, Anaconda 21.48.21-1

How reproducible:

Always


Steps to Reproduce:
1. Install Fedora 21 server spin via kickstart.
2. KS file contains partition definitions with --encrypt but without --passphrase.

Actual results:
Anacona blows out partition table, indicates its creating filesystems, then displays traceback, indicating no passphrase was recorded.


Expected results:
Prompt for encryption passphrase by anaconda

Additional info:
Similar to #446930

Comment 1 Rick 2015-04-18 20:52:06 UTC
Created attachment 1015952 [details]
file generated by %pre which shows the partition configuration that resulted in the TB

Comment 2 Rick 2015-04-18 20:53:55 UTC
Created attachment 1015953 [details]
log file from Anaconda during the install that made the TB

Comment 3 Rick 2015-04-18 20:59:41 UTC
Created attachment 1015954 [details]
Kickstart file I was using

Comment 4 Rick 2015-04-18 21:06:06 UTC
(In reply to Nick from comment #0)
> Created attachment 1015951 [details]
> Anaconda traceback log (truncated for clarity and privacy)
> 
> Description of problem:


Sorry I missed the description...

I boot up into my kickstart install, all goes well, except that I'm not prompted for a passphrase.

Yet the installer continues to try and format my disks, wiping out my MBR, etc., and only *then* does it traceback with the whole "missing passphrase" bit.

I think part of the solution here would be to check for correctness *before* touching the disks.  I had to file this bug from a different machine because this particular bug left my system in an unusable state. (BAD)

But the biggest thing to fix, is that Anaconda should prompt me for a passphrase in this case.

This was a bug going back all the way to Fedora 9...

https://bugzilla.redhat.com/show_bug.cgi?id=446930

Like that bug author, I tried adding --passphrase with no text (writing down passphrases in plain text in a kickstart file is a non-starter) and at least at that point, anaconda failed gracefully without breaking my system. :)

I'm surprised at how little attention to FDE bugs is paid.  I'm not a great python dev, but in the past, maintainers of Anaconda have given me the "here be dragons" warning when I asked for tips on where to start.  But that was before the new Fedora 20 installer version of Anaconda.

So if anyone can point me in the right direction on how to get started contributing bugfixes to Anaconda, I'd be happy to help! (once I get a working system again.)

Comment 5 mulhern 2015-04-20 16:06:56 UTC
I'm inclined to think that a pykickstart error when --encrypted is set but --passphrase is not is the best solution to this problem. Reassigning to pykickstart.

Comment 6 mulhern 2015-04-20 16:07:37 UTC
Taking, because already have related bug.

Comment 7 mulhern 2015-04-20 17:18:43 UTC
Reassigning to anaconda...seems that prompting for the missing passphrase is the correct solution.

Comment 8 Rick 2015-04-20 17:41:54 UTC
I would agree, getting Anaconda to prompt me for a passphrase is exactly the effect I was going for.  I believe that would keep in the kickstart tradition of "move forward and only pause if you're missing something."

What can I do to help?

Comment 9 mulhern 2015-04-20 19:34:44 UTC
Anaconda is now on GitHub: https://github.com/rhinstaller/anaconda.  Try checking out master and looking at custom.py and storage.py. There is an existing method, _check_encrypted which obtains passphrase from user. Also look out for occurrances of PassphraseDialog. These are examples of setting passphrases on LUKS devices.


(In reply to Nick from comment #8)
> I would agree, getting Anaconda to prompt me for a passphrase is exactly the
> effect I was going for.  I believe that would keep in the kickstart
> tradition of "move forward and only pause if you're missing something."
> 
> What can I do to help?

Comment 10 mulhern 2015-04-20 19:36:22 UTC
This seems like a blivet bug as well as I don't think TUI is an encryption handling UI.

Comment 11 mulhern 2015-04-20 21:49:45 UTC
Note that configuration should fail sanity check. sanity checking for missing passphrase was added in python-blivet-0.38-1 and required in anaconda-21.21-1. See bz#1060255.

Comment 12 Rick 2015-04-20 22:02:07 UTC
My last experience with Anaconda was such that TUI mode did *not* handle prompting for encryption. (Though it works perfectly fine if you pass in the LUKS PP via --passphrase="" in your kickstart file)

Comment 13 mulhern 2015-04-21 16:54:57 UTC
Created attachment 1016976 [details]
Working kickstart for showing error

In the file, change "text" to "graphical" to see traceback in GUI.

Comment 14 mulhern 2015-06-18 12:44:41 UTC
This is essentially the same as: https://github.com/rhinstaller/anaconda/pull/140.

Comment 15 Rick 2015-07-18 03:44:11 UTC
https://github.com/rhinstaller/anaconda/pull/174

^^ appears to fix the bug in RHEL7.  No such patch for F22 or F21 that I could see here: https://github.com/rhinstaller/anaconda/commits/f22-branch

or in Master.  :(

Comment 16 Fedora End Of Life 2015-11-04 15:56:16 UTC
This message is a reminder that Fedora 21 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 21. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '21'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 21 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 17 Jan Kurik 2015-12-02 19:24:13 UTC
Fedora 21 changed to end-of-life (EOL) status on 2015-12-01. Fedora 21 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.