Bug 1213123

/etc/yum.repos.d/spacewalk-client.repo is supposed to look like this

[spacewalk-client]
name=Spacewalk Client Tools
baseurl=http://yum.spacewalkproject.org/2.2-client/RHEL/$releasever/$basearch/
gpgkey=http://yum.spacewalkproject.org/RPM-GPG-KEY-spacewalk-2012
enabled=1
gpgcheck=1

(In reply to Mohammed Arafa from comment #0)
> Description of problem:
> this page 
> https://fedorahosted.org/spacewalk/wiki/RegisteringClients
> 
> gives 3 different repo files depending on the release version of the OS. 
> however the OS itself has a variable for the yum repo file called $releasever
> this means if the variable is used in the repo file. the same repo file can
> be used for centos5 or centos6 or centos7. 

I think you confuse repo file and an rpm command to install rpm package to get you the repo file.

> thereby 
> a) reducing documentation
> b) scripting logic
> c) time!
> 
> pls modify the repo file to use the $releasever variable instaled of

It does.

> hardcoding the release version into the repo file

It does not.

(In reply to Mohammed Arafa from comment #1)
> /etc/yum.repos.d/spacewalk-client.repo is supposed to look like this
> 
> [spacewalk-client]
> name=Spacewalk Client Tools
> baseurl=http://yum.spacewalkproject.org/2.2-client/RHEL/$releasever/
> $basearch/
> gpgkey=http://yum.spacewalkproject.org/RPM-GPG-KEY-spacewalk-2012
> enabled=1
> gpgcheck=1

This is exactly what is shipped in http://yum.spacewalkproject.org/2.2-client/Fedora/20/x86_64/spacewalk-client-repo-2.2-1.fc20.noarch.rpm.

i do not use fedora clients only centos

i verified for this bug report that $releasever is _missing_ and instead "7" was hardcoded into the repo.

i followed instructions from https://fedorahosted.org/spacewalk/wiki/RegisteringClients

which specifically states there is an rpm file and therefore a repo file for each os release:

<excerpt>

    RHEL 5 / CentOS 5

    # rpm -Uvh http://yum.spacewalkproject.org/2.3-client/RHEL/5/x86_64/spacewalk-client-repo-2.3-2.el5.noarch.rpm
    # BASEARCH=$(uname -i)
    # rpm -Uvh http://dl.fedoraproject.org/pub/epel/epel-release-latest-5.noarch.rpm

    RHEL 6 / SL 6 / CentOS 6

    # rpm -Uvh http://yum.spacewalkproject.org/2.3-client/RHEL/6/x86_64/spacewalk-client-repo-2.3-2.el6.noarch.rpm
    # BASEARCH=$(uname -i)
    # rpm -Uvh http://dl.fedoraproject.org/pub/epel/epel-release-latest-6.noarch.rpm

    RHEL 7 / SL 7 / CentOS 7

    # rpm -Uvh http://yum.spacewalkproject.org/2.3-client/RHEL/7/x86_64/spacewalk-client-repo-2.3-2.el7.noarch.rpm
    # BASEARCH=$(uname -i)
    # rpm -Uvh http://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm

(In reply to Mohammed Arafa from comment #4)
> i do not use fedora clients only centos

Ah, sorry about that, I missed the RHEL in your post.

> i verified for this bug report that $releasever is _missing_ and instead "7"
> was hardcoded into the repo.

The problem is, this will not work for RHEL/CentOS. The $releasever is not set to 7 on RHEL, it's set to 7<Variant> there. The $releasever on RHEL and on CentOS differ.

Unless the team is willing to maintain separate locations for various $releasever values on CentOS vs. different variants of RHEL, I propose closing as WONTFIX.

As from Spacewalk nightly/upcoming 2.8 version client registration instructions change (https://github.com/spacewalkproject/spacewalk/wiki/RegisteringClientsNightly) - RPM with repo files download required only on EL/CentOS 6, newer clients can enable repo with yum/dnf copr plugin, switching whis to MODIFIED.

Moving ON_QA

Spacewalk 2.8 has been released.
https://github.com/spacewalkproject/spacewalk/wiki/ReleaseNotes28