Bug 1213349 - [Snapshot] Scheduler should check vol-name exists or not before adding scheduled jobs
Summary: [Snapshot] Scheduler should check vol-name exists or not before adding sched...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: snapshot
Version: mainline
Hardware: x86_64
OS: Linux
unspecified
urgent
Target Milestone: ---
Assignee: Avra Sengupta
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: qe_tracker_everglades 1245923 1245924
TreeView+ depends on / blocked
 
Reported: 2015-04-20 11:07 UTC by Anil Shah
Modified: 2016-06-16 12:52 UTC (History)
4 users (show)

Fixed In Version: glusterfs-3.8rc2
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1245923 1245924 (view as bug list)
Environment:
Last Closed: 2016-06-16 12:52:58 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Anil Shah 2015-04-20 11:07:18 UTC
Description of problem:

When adding jobs to scheduler,  it should check whether volume with that volume name exist or not. If volume does not exists, it through message volume volume doesn't exists.   

Version-Release number of selected component (if applicable):

[root@localhost core]# rpm -qa | grep glusterfs
glusterfs-api-3.8dev-0.12.gitaa87c31.el6.x86_64
glusterfs-geo-replication-3.8dev-0.12.gitaa87c31.el6.x86_64
samba-glusterfs-3.6.509-169.4.el6rhs.x86_64
glusterfs-cli-3.8dev-0.12.gitaa87c31.el6.x86_64
glusterfs-fuse-3.8dev-0.12.gitaa87c31.el6.x86_64
glusterfs-server-3.8dev-0.12.gitaa87c31.el6.x86_64
glusterfs-rdma-3.8dev-0.12.gitaa87c31.el6.x86_64
glusterfs-debuginfo-3.7dev-0.994.gitf522001.el6.x86_64
glusterfs-libs-3.8dev-0.12.gitaa87c31.el6.x86_64
glusterfs-3.8dev-0.12.gitaa87c31.el6.x86_64


How reproducible:

100%

Steps to Reproduce:
1. Create 6*2 distributed replicate volume
2. create shared storage and do fuse mount on each storage node on path /var/run/gluster/shared_storage
mount -t glusterfs 10.70.47.143:meta /var/run/gluster/shared_storage/
3. initialize scheduler on each storage node e.g run snap_scheduler.py init  command
4. Enable scheduler on storage nodes e.g run snap_scheduler.py enable
5. Add jobs to scheduler providing volume name which doesn't exists


Actual results:

scheduler accepts the jobs.

Expected results:

Scheduler should check whether volume exists or not.

Additional info:

Comment 1 Anand Avati 2015-08-05 08:27:21 UTC
REVIEW: http://review.gluster.org/11830 (snapshot/scheduler: Check if volume exists before adding/editing schedules) posted (#1) for review on master by Avra Sengupta (asengupt)

Comment 2 Anand Avati 2015-08-19 07:05:43 UTC
REVIEW: http://review.gluster.org/11830 (snapshot/scheduler: Check if volume exists before adding/editing schedules) posted (#3) for review on master by Avra Sengupta (asengupt)

Comment 3 Anand Avati 2015-08-20 06:18:44 UTC
REVIEW: http://review.gluster.org/11830 (snapshot/scheduler: Check if volume exists before adding/editing schedules) posted (#4) for review on master by Avra Sengupta (asengupt)

Comment 4 Anand Avati 2015-08-24 06:55:50 UTC
COMMIT: http://review.gluster.org/11830 committed in master by Rajesh Joseph (rjoseph) 
------
commit 6cb78f8b7444ad7f216c976700c28a7d59f6b976
Author: Avra Sengupta <asengupt>
Date:   Wed Aug 5 13:49:41 2015 +0530

    snapshot/scheduler: Check if volume exists before adding/editing schedules
    
    Before adding or editing a scheduler, check if the volume name provided
    in the schedule, exists in the cluster or not.
    
    Added return code VOLUME_DOES_NOT_EXIST(17) for the same.
    
    Change-Id: Ia3fe3cc1e1568ddd10f9193bbf40a098f0fe990a
    BUG: 1213349
    Signed-off-by: Avra Sengupta <asengupt>
    Reviewed-on: http://review.gluster.org/11830
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: mohammed rafi  kc <rkavunga>
    Reviewed-by: Rajesh Joseph <rjoseph>

Comment 5 Nagaprasad Sathyanarayana 2015-10-25 14:50:20 UTC
Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 6 Niels de Vos 2016-06-16 12:52:58 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.