Bug 1213599 - Review Request: mediawiki123-RSS - Displays one or more RSS feeds on a wiki page
Summary: Review Request: mediawiki123-RSS - Displays one or more RSS feeds on a wiki page
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-04-20 21:11 UTC by Patrick Uiterwijk
Modified: 2015-05-29 21:47 UTC (History)
2 users (show)

Fixed In Version: mediawiki123-RSS-2.25.0-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-05-29 21:47:50 UTC
Type: ---
Embargoed:
kevin: fedora-review+


Attachments (Terms of Use)

Description Patrick Uiterwijk 2015-04-20 21:11:54 UTC
Spec URL: http://puiterwijk.fedorapeople.org//mediawiki123-RSS.spec
SRPM URL: http://puiterwijk.fedorapeople.org//mediawiki123-RSS-2.25.0-1.fc21.src.rpm

Description:
The RSS extension displays one or more RSS feeds
on a wiki page in a standard or user-definable format.
Since version 2.00, the extension is also compatible
with wiki-page-generated feeds (RSS or ATOM).

Comment 1 Patrick Uiterwijk 2015-04-20 21:12:29 UTC
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9522654

I'm only interrested in EPEL7.

Comment 2 Kevin Fenzi 2015-04-20 21:54:26 UTC
I'll review this. Look for a full review in a few.

Comment 3 Kevin Fenzi 2015-04-20 21:56:52 UTC
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
OK - License (GPLv2+)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
11ccf76bf7ebd9c4bf6308cd9c378c2d  RSS-REL1_23-c7c5f15.tar.gz

OK - BuildRequires correct
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output. 
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should function as described. 
OK - Should have sane scriptlets. 
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin

Issues: 

1. rpmlint says: 

mediawiki123-RSS.noarch: E: incorrect-fsf-address /usr/share/doc/mediawiki123-RSS-2.25.0/COPYING
2 packages and 0 specfiles checked; 1 errors, 0 warnings.

Might let upstream know, but not a blocker. 

I don't see any blockers here, so this package is APPROVED.

Comment 4 Fedora Update System 2015-04-20 22:18:33 UTC
mediawiki123-RSS-2.25.0-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/mediawiki123-RSS-2.25.0-1.el7

Comment 5 Fedora Update System 2015-04-22 05:09:44 UTC
mediawiki123-RSS-2.25.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository.

Comment 6 Fedora Update System 2015-05-29 21:47:50 UTC
mediawiki123-RSS-2.25.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository.


Note You need to log in before you can comment on or make changes to this bug.