Bug 1213680 - [lshw] does not determine FORMFACTOR
Summary: [lshw] does not determine FORMFACTOR
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Beaker
Classification: Retired
Component: inventory
Version: develop
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: 21.0
Assignee: beaker-dev-list
QA Contact: Dan Callaghan
URL:
Whiteboard:
Depends On:
Blocks: 541294
TreeView+ depends on / blocked
 
Reported: 2015-04-21 04:23 UTC by Dan Callaghan
Modified: 2018-02-06 00:41 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-08-26 06:17:46 UTC
Embargoed:


Attachments (Terms of Use)

Description Dan Callaghan 2015-04-21 04:23:13 UTC
FORMFACTOR key is Unknown instead of desktop.

This is most likely of no value and is probably wrong in most cases, so if it's not easy to fix we should just drop the key.

Comment 2 Dan Callaghan 2015-04-21 04:41:16 UTC
One value that *is* useful to have is FORMFACTOR="blade" as in the IBM JS20 systems. So we should make sure this is fixed.

Comment 3 Amit Saha 2015-06-15 04:12:52 UTC
We do not have a FORMFACTOR field in Beaker's DB..so we will need to fix that as well.

Comment 4 Amit Saha 2015-06-15 05:46:59 UTC
beaker-system-scan patch: http://gerrit.beaker-project.org/#/c/4257/

lshw doesn't report the formfactor on the IBM js20 system correctly, so need to patch it..

Comment 5 Amit Saha 2015-06-17 03:11:55 UTC
(In reply to Amit Saha from comment #4)

> 
> lshw doesn't report the formfactor on the IBM js20 system correctly, so need
> to patch it..


lshw uses SMBIOS data for the "description" of the computer which is equivalent to what we need for "form factor". However, SMBIOS doesn't exist for PPC (http://www.dmtf.org/standards/smbios). 

I am looking into hal's source code to see if I can understand how smolt is able to get it. The file specifically is hald/linux/osspec.c (searching for "formfactor" will lead to the key places in the code).

Comment 6 Amit Saha 2015-06-19 02:10:10 UTC
We adopted a strategy similar to smolt specifically for IBM blade systems which is use the model to check if it's a Blade, then we set it so in beaker-system-scan. We are going to work on a patch for lshw to do so, but in the meanwhile we strictly do the mapping in beaker-system-scan:

http://gerrit.beaker-project.org/#/c/4257/

Comment 7 Amit Saha 2015-07-03 00:26:27 UTC
(In reply to Amit Saha from comment #6)
> We adopted a strategy similar to smolt specifically for IBM blade systems
> which is use the model to check if it's a Blade, then we set it so in
> beaker-system-scan. We are going to work on a patch for lshw to do so, but
> in the meanwhile we strictly do the mapping in beaker-system-scan:
> 
> http://gerrit.beaker-project.org/#/c/4257/

We have patched/plan to patch lshw to report the chassis correctly, hence beaker-system-scan just retrieves it from lshw output instead of doing any mapping itself.

Comment 9 Dan Callaghan 2015-08-26 06:17:46 UTC
Beaker 21.0 has been released.


Note You need to log in before you can comment on or make changes to this bug.