Bug 1214346

Adam, what is you view on this?

type is a terrible variable name (as is state, status, mode, class, role, etc).  We introduced the schema change and appropriate fixup code in Bridge.py to move away from these bad things that cannot be changed in XMLRPC due to BC requirements.  If this code is breaking somewhere I think we should fix the jsonrpc bridge and not revert back to bad names.

(In reply to Adam Litke from comment #2)
> type is a terrible variable name (as is state, status, mode, class, role,
> etc).  We introduced the schema change and appropriate fixup code in
> Bridge.py to move away from these bad things that cannot be changed in
> XMLRPC due to BC requirements.  If this code is breaking somewhere I think
> we should fix the jsonrpc bridge and not revert back to bad names.

domain.type is the best name for the type of a domain. domain.domainType
a repeating "domain".

This is true also for state, status, mode, class and role :-)

I think the correct solution is removing the magical fixup code in the
bridge and use the short and nicer names.

This isn't the rest api, but vdsm's api.

Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

this is an automated message. oVirt 3.6.0 RC3 has been released and GA is targeted to next week, Nov 4th 2015.
Please review this bug and if not a blocker, please postpone to a later release.
All bugs not postponed on GA release will be automatically re-targeted to

- 3.6.1 if severity >= high
- 4.0 if severity < high

Moving from 4.0 alpha to 4.0 beta since 4.0 alpha has been already released and bug is not ON_QA.

oVirt 4.0 beta has been released, moving to RC milestone.

Same error for the "domainClass", the actual value is "class":

# vdsm-client StorageDomain getInfo \
    storagedomainID=7df95b16-1bd3-4c23-bbbe-b21d403bdcd8
{
    "uuid": "7df95b16-1bd3-4c23-bbbe-b21d403bdcd8", 
    "type": "ISCSI", 
    "vguuid": "yQyqnB-Y7x6-EGjl-WrFJ-fc9O-Oa4x-ShsdLa", 
    "metadataDevice": "360014052c81462a280847e8a6e3af8cd", 
    "state": "OK", 
    "version": "4", 
    "role": "Regular", 
    "vgMetadataDevice": "360014052c81462a280847e8a6e3af8cd", 
    "class": "Data", 
    "pool": [
        "ec544277-c00c-46ea-b330-7daac6d5c09d"
    ], 
    "name": "dumbo-iscsi-01"
}

The schema for this response:

StorageDomain.getInfo:
    added: '3.1' 
    description: Get information about a Storage Domain.
    params:
    -   description: The UUID of the Storage Domain
        name: storagedomainID
        type: *UUID 
    return:
        description: Storage domain information
        type: *StorageDomainInfo

    StorageDomainInfo: &StorageDomainInfo
        added: '3.1'
        description: Information about a Storage Domain.
        name: StorageDomainInfo
        properties:
        -   description: The Storage Domain role
            name: role
            type: *StorageDomainRole

        -   description: The lock version of the associated Storage Pool
            name: lver
            type: int

        -   description: The version of this Storage Domain
            name: version
            type: int

        -   description: The type of backing storage used by this domain
            name: domainType
            type: *StorageDomainType

        -   description: The human-readable name for this Storage Domain
            name: name
            type: string

        -   description: The Storage Pool associated with this Storage Domain
            name: pool
            type:
            - *UUID

        -   description: The version of the master Storage Domain
            name: master_ver
            type: int

        -   description: The Storage Domain class
            name: domainClass
            type: *StorageDomainImageClass

        -   description: Contains the Host ID of the Storage Pool Manager
            name: spm_id
            type: int

        -   description: The Storage Domain UUID
            name: uuid
            type: *UUID

        -   defaultvalue: null
            description: The GUID of the first device containing the domain
                metadata lv for block storage domains only
            name: metadataDevice
            type: string

        -   defaultvalue: null
            description: The GUID of the device containing the domain vg
                metadata for block storage domains (optional)
            name: vgMetadataDevice
            type: string
        type: object

So the fix should be for both "type" and "class".

@Nir - addressed in consecutive patches.

Using latest build [1], still getting 'type' and 'class' instead if 'domainType' and 'domainClass':


[root@storage-ge2-vdsm1 yum.repos.d]# vdsm-client StorageDomain getInfo storagedomainID=1eb49be0-bcc4-4f3b-94af-a10c669ad73a
{
    "uuid": "1eb49be0-bcc4-4f3b-94af-a10c669ad73a", 
    "type": "ISCSI", 
    "vguuid": "SKlPbo-YcD7-scWp-AHNe-QSFx-Ebqa-6mektL", 
    "metadataDevice": "3514f0c5a516008d5", 
    "state": "OK", 
    "version": "4", 
    "role": "Regular", 
    "vgMetadataDevice": "3514f0c5a516008d5", 
    "class": "Data", 
    "pool": [
        "fc52e0e4-5246-4f14-8269-a256c62608f9"
    ], 
    "name": "iscsi_1"
}



[1]
vdsm-4.19.2-2.el7ev.x86_64
vdsm-cli-4.19.2-2.el7ev.noarch
vdsm-jsonrpc-4.19.2-2.el7ev.noarch
vdsm-client-4.19.2-2.el7ev.noarch
vdsm-xmlrpc-4.19.2-2.el7ev.noarch
vdsm-yajsonrpc-4.19.2-2.el7ev.noarch
vdsm-python-4.19.2-2.el7ev.noarch
vdsm-api-4.19.2-2.el7ev.noarch

Hi Elad,

I guess the description was a bit misleading.
The fix here is *only* in the vdsm API schema:
- from 'domainType' to 'type'
- from 'domainClass' to 'class'

You can check the schema html file at:
'/usr/share/doc/vdsm-api-*/vdsm-api.html' (StorageDomainInfo section).

Moving back to ON_QA

Thanks Daniel, 

[root@storage-ge2-vdsm1 ~]# vim /usr/share/doc/vdsm-api-4.19.2/vdsm-api.html 

<a name="StorageDomainInfo" />

<b>StorageDomainInfo:</b><br/>
Information about a Storage Domain.<br/>


<tr><td class="attrlist">type</td><td class="attrlist"><a href="#StorageDomainType">StorageDomainType</a></td><td class="attrlist">The type of backing storage used by this domain</td></tr>

<tr><td class="attrlist">class</td><td class="attrlist"><a href="#StorageDomainImageClass">StorageDomainImageClass</a></td><td class="attrlist">The Storage Domain class</td></tr>


========================
Used:
vdsm-api-4.19.2-2.el7ev.noarch