Hide Forgot
Spec URL: https://asamalik.fedorapeople.org/dist-git/dist-git.spec SRPM URL: https://asamalik.fedorapeople.org/dist-git/dist-git-0.7-1.fc21.src.rpm Description: Dist Git is a remote Git repository specifically designed to hold RPM package sources. Fedora Account System Username: asamalik
> %config(noreplace) %{_sysconfdir}/httpd/conf.d/ssl.conf.example I would either leave out (noreplace) or I would put it in %doc directory (and remove %config completly). > %config %{_unitdir}/dist-git@.service > %config %{_unitdir}/dist-git.socket This should not be config at all. > /var/lib/dist-git/gitolite/hooks/common is listed twice. Because %attr (770, -, packager) %{_sharedstatedir}/dist-git/gitolite/hooks include this dir and *everything* below. So either put there %dir or remove that subdirectory [!]: Package must own all directories that it creates. Note: Directories without known owners: /var/lib/dist-git/git, /usr/share /dist-git, /var/lib/dist-git, /var/lib/dist-git/gitolite/local, /var/lib /dist-git/gitolite, /var/lib/dist-git/cache, /etc/cron.d, /var/lib/dist- git/web, /etc/httpd/conf.d/dist-git, /var/lib/dist-git/cache/lookaside, /etc/cron.d/dist-git, /etc/dist-git > dist-git.noarch: W: dangling-symlink /var/lib/dist-git/git/.gitolite /var/lib/dist-git/gitolite >dist-git.noarch: E: zero-length /var/lib/dist-git/gitolite/hooks/common/update > dist-git.noarch: E: script-without-shebang /var/lib/dist-git/gitolite/hooks/common/update > dist-git.noarch: W: no-documentation Since you are upstream, can you put there COPYING file where you would state which files are under which license and LICENSE files with all licenses used? And mark those files as %license Additionaly provided README you have in github as %doc would be nice too. Is this intentional?
Thank you for the feedback. I have fixed all the issues and described them below. Spec URL: https://asamalik.fedorapeople.org/dist-git/dist-git.spec SRPM URL: https://asamalik.fedorapeople.org/dist-git/dist-git-0.8-1.fc21.src.rpm Changes in %files section: - %config(noreplace) %{_sysconfdir}/httpd/conf.d/ssl.conf.example + %config %{_sysconfdir}/httpd/conf.d/ssl.conf.example - %config %{_unitdir}/dist-git@.service + %{_unitdir}/dist-git@.service - %config %{_unitdir}/dist-git.socket + %{_unitdir}/dist-git.socket /var/lib/dist-git/gitolite/hooks/common is not listed twice anymore All directories are owned by the package. Fixed for: /var/lib/dist-git/git, /usr/share /dist-git, /var/lib/dist-git, /var/lib/dist-git/gitolite/local, /var/lib /dist-git/gitolite, /var/lib/dist-git/cache, /etc/cron.d, /var/lib/dist- git/web, /etc/httpd/conf.d/dist-git, /var/lib/dist-git/cache/lookaside, /etc/cron.d/dist-git, /etc/dist-git New files: COPYING ,LICENSE > dist-git.noarch: W: dangling-symlink /var/lib/dist-git/git/.gitolite /var/lib/dist-git/gitolite That's because I wanted to store gitolite files on one place as they contain some git hooks and generated gitolite configuration. Scrips uses the original path "/var/lib/dist-git/gitolite". The gitolite itself, however, expects this directory under ~/.gitolite. It is also following the original design of dist-git. >dist-git.noarch: E: zero-length /var/lib/dist-git/gitolite/hooks/common/update > dist-git.noarch: E: script-without-shebang /var/lib/dist-git/gitolite/hooks/common/update Gitolite, for some reason, needs this file created in advance.
Spec URL: https://asamalik.fedorapeople.org/dist-git/dist-git.spec SRPM URL: https://asamalik.fedorapeople.org/dist-git/dist-git-0.9-1.fc21.src.rpm The file /var/lib/dist-git/gitolite/hooks/common/update is not needed.
However the program create it, so it should be owned with: %ghost %attr (775, gen-acls, packager) %{_sharedstatedir}/dist-git/gitolite/hooks/common/update
Additionally instead of: Requires: perl-Sys-Syslog should be: Requires: perl(Sys::Syslog)
Updated: Spec URL: https://asamalik.fedorapeople.org/dist-git/dist-git.spec SRPM URL: https://asamalik.fedorapeople.org/dist-git/dist-git-0.10-1.fc21.src.rpm
APPROVED
New Package SCM Request ======================= Package Name: dist-git Short Description: Package source version control system Upstream URL: https://github.com/release-engineering/dist-git Owners: asamalik Branches: f21 f22 epel7 InitialCC:
Git done (by process-git-requests).
dist-git-0.10-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/dist-git-0.10-1.fc21
dist-git-0.10-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/dist-git-0.10-1.fc22
dist-git-0.10-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/dist-git-0.10-1.el7
dist-git-0.10-1.el7 has been pushed to the Fedora EPEL 7 testing repository.
dist-git-0.11-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/dist-git-0.11-1.fc21
dist-git-0.11-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/dist-git-0.11-1.el7
dist-git-0.11-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/dist-git-0.11-1.fc22
dist-git-0.11-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
dist-git-0.11-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.
dist-git-0.11-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.