Spec URL: https://gil.fedorapeople.org/jbzip2.spec SRPM URL: https://gil.fedorapeople.org/jbzip2-0.9.1-1.fc20.src.rpm Description: jbzip2 is a Java bzip2 compression/decompression library. This is a dependency for support of compression in bzip2 files in netCDF-java and TDS (https://github.com/Unidata/thredds). Fedora Account System Username: gil Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=9538402
Issues: ======= - Bundled jar/class files should be removed before build Note: Jar files in source (see attachment) See: http://fedoraproject.org/wiki/Packaging:Java#Pre- built_JAR_files_.2F_Other_bundled_software' ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 10 files have unknown license. Detailed output of licensecheck in /home/mskalick/1214396-jbzip2/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/licenses, /usr/share/maven-metadata [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/licenses, /usr/share/maven-metadata [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jbzip2-javadoc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: jbzip2-0.9.1-1.fc23.noarch.rpm jbzip2-javadoc-0.9.1-1.fc23.noarch.rpm jbzip2-0.9.1-1.fc23.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- jbzip2-javadoc (rpmlib, GLIBC filtered): jpackage-utils jbzip2 (rpmlib, GLIBC filtered): java-headless jpackage-utils Provides -------- jbzip2-javadoc: jbzip2-javadoc jbzip2: jbzip2 mvn(org.itadaki:bzip2) mvn(org.itadaki:bzip2:pom:)
Issues: ======= - Bundled jar/class files should be removed before build Note: Jar files in source (see attachment) See: http://fedoraproject.org/wiki/Packaging:Java#Pre- built_JAR_files_.2F_Other_bundled_software' There is bundled jar file /maven-jbzip2-d01e55b27d282316ddc1e71b09f78239da59f830/target/bzip2-0.9.1.jar Are you really sure it isn't used during the build? -> "Bundled jar/class files should be removed before build..."
Spec URL: https://gil.fedorapeople.org/jbzip2.spec SRPM URL: https://gil.fedorapeople.org/jbzip2-0.9.1-2.fc20.src.rpm - remove pre-built binaries
OK. It works everything is now all right. Now I find out that in git there is second commit which removes these jar/class files. So according to me it should be better to only change githash. But it is up to you...
(In reply to Marek Skalický from comment #4) > OK. It works everything is now all right. > > Now I find out that in git there is second commit which removes these > jar/class files. So according to me it should be better to only change > githash. But it is up to you... Yes sure thanks for the advise
New Package SCM Request ======================= Package Name: jbzip2 Short Description: A Java bzip2 library Upstream URL: https://github.com/buttnerchristopher/maven-jbzip2 Owners: gil Branches: f22 InitialCC: java-sig
Git done (by process-git-requests).
jbzip2-0.9.1-2.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/jbzip2-0.9.1-2.fc22
jbzip2-0.9.1-2.fc22 has been pushed to the Fedora 22 testing repository.
jbzip2-0.9.1-2.fc22 has been pushed to the Fedora 22 stable repository.