Description of problem: Some of the leftover dhtmlxtree calls that need to be converted are mentioned on the Github issue: https://github.com/ManageIQ/manageiq/issues/2714 Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
New commit detected on manageiq/master: https://github.com/ManageIQ/manageiq/commit/1d48c28c6d19e69ec82b73cfbda64d7f5ec56805 commit 1d48c28c6d19e69ec82b73cfbda64d7f5ec56805 Author: Harpreet Kataria <hkataria> AuthorDate: Fri Apr 24 09:32:39 2015 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Fri Apr 24 11:31:30 2015 -0400 Removed/Replaced dhtmlxtree specific calls i.e. selectItem - Removed any unused code that had dhtmlxtree specific calls. - Replaced dhtmlxtree selectITem calls in use with dynatree specific calls. #2714 https://bugzilla.redhat.com/show_bug.cgi?id=1214776 vmdb/app/controllers/application_controller.rb | 2 +- .../application_controller/tree_support.rb | 25 ------ vmdb/app/controllers/catalog_controller.rb | 3 +- .../controllers/miq_ae_customization_controller.rb | 4 +- vmdb/app/controllers/report_controller/reports.rb | 40 ---------- vmdb/app/presenters/explorer_presenter.rb | 48 +----------- .../views/miq_policy/_profile_folders.html.haml | 13 ---- vmdb/app/views/service/_st_form.html.haml | 91 ---------------------- vmdb/app/views/service/_st_show.html.haml | 62 --------------- vmdb/app/views/shared/_tree_select_error.js.haml | 2 +- vmdb/spec/presenters/explorer_presenter_spec.rb | 18 ----- 11 files changed, 5 insertions(+), 303 deletions(-) delete mode 100644 vmdb/app/views/miq_policy/_profile_folders.html.haml delete mode 100644 vmdb/app/views/service/_st_form.html.haml delete mode 100644 vmdb/app/views/service/_st_show.html.haml
New commit detected on manageiq/master: https://github.com/ManageIQ/manageiq/commit/38075feb90d06ba17211f4ce2bc4f05305d14877 commit 38075feb90d06ba17211f4ce2bc4f05305d14877 Author: Harpreet Kataria <hkataria> AuthorDate: Fri Apr 24 11:52:56 2015 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Fri Apr 24 11:52:56 2015 -0400 Removed dhtmlxtree specific calls that aren't being used anymore - Removed deleteItem, saveOpenStates, loadOpenStates, loadJSONObject dhtmlxtree specific calls, that have either been replaced or no longer apply to dynatrees. #2714 https://bugzilla.redhat.com/show_bug.cgi?id=1214776 vmdb/app/controllers/catalog_controller.rb | 3 -- vmdb/app/controllers/miq_ae_class_controller.rb | 1 - .../controllers/miq_ae_customization_controller.rb | 5 --- vmdb/app/controllers/miq_capacity_controller.rb | 2 -- vmdb/app/controllers/miq_policy_controller.rb | 2 -- vmdb/app/controllers/vm_common.rb | 6 ---- vmdb/app/presenters/explorer_presenter.rb | 40 ++++------------------ vmdb/app/views/container/_explorer.js.haml | 10 +----- vmdb/app/views/service/_explorer.js.haml | 7 +--- 9 files changed, 9 insertions(+), 67 deletions(-)
New commit detected on manageiq/master: https://github.com/ManageIQ/manageiq/commit/f5ae3d0d00b9cde96d8538ee73c7f74d8447a97d commit f5ae3d0d00b9cde96d8538ee73c7f74d8447a97d Author: Harpreet Kataria <hkataria> AuthorDate: Fri Apr 24 12:32:33 2015 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Fri Apr 24 13:51:50 2015 -0400 Changed the call to cfmeDynatree_activateNode - Calling cfmeDynatree_activateNodeSilently was not refreshing right side of the screen, cfmeDynatree_activateNode call activates the node and refreshes results on the right side. - Changed cfmeDynaTree_activateNode method to reactivate tree if node is already active, to force it to run tree_Select transaction and refresh right cell results. #2714 https://bugzilla.redhat.com/show_bug.cgi?id=1214776 vmdb/app/assets/javascripts/miq_dynatree.js | 6 +++++- vmdb/app/controllers/vm_common.rb | 3 ++- vmdb/app/views/shared/_tree_select_error.js.haml | 2 +- 3 files changed, 8 insertions(+), 3 deletions(-)
Verified : Steps : 1. Automate customization, dialog editor, add a dialog then try to clear up the label and press save, it should show message i.e. label can't be blank, and it should put me back on that node in the tree 2. Edit a dialog, remove label of a tab or a field, then click on the treed node on the left, it didnt select the previous node, after fix it should reselect the node you were on 3.To test the change in vmdb/app/views/shared/_tree_select_error.js.haml,use 2 browser windows, in one log in as a specific user go to VM explorer then in second browser window log in as admin, changed the tags on VM so the user in first browser doesnt have access to the VM on his screen, then switched to first window and tried to access the VM, that shows flash message and puts user back to the root node 5.4.0.0.26.20150511144816_f924bd4
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-1100.html