Bug 1215039 - [HC] - API schema for StorageDomainType is missing glusterfs type
Summary: [HC] - API schema for StorageDomainType is missing glusterfs type
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: vdsm
Classification: oVirt
Component: General
Version: ---
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ovirt-4.1.1
: 4.19.5
Assignee: Denis Chaplygin
QA Contact: Raz Tamir
URL:
Whiteboard:
Depends On:
Blocks: 1036731 oVirt_Hosted_Engine_GlusterFS
TreeView+ depends on / blocked
 
Reported: 2015-04-24 07:42 UTC by Sandro Bonazzola
Modified: 2019-04-28 14:17 UTC (History)
16 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
undefined
Clone Of:
Environment:
Last Closed: 2017-02-12 13:16:45 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.1+
ylavi: planning_ack+
rule-engine: devel_ack+
ratamir: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 70917 0 master MERGED hc: Added GLUSTERFS to the API schema. 2017-01-26 09:48:06 UTC
oVirt gerrit 71380 0 ovirt-4.1 MERGED hc: Added GLUSTERFS to the API schema. 2017-02-02 10:05:52 UTC

Description Sandro Bonazzola 2015-04-24 07:42:58 UTC 
##
# @StorageDomainType:
#
# An enumeration of Storage Domain types.
#
# @UNKNOWN:   The type is not known
#
# @NFS:       The Storage Domain uses Network File System based storage
#
# @FCP:       The Storage Domain uses FibreChannel based storage
#
# @ISCSI:     The Storage Domain uses iSCSI based storage
#
# @LOCALFS:   The Storage Domain uses storage on the local file system
#
# @CIFS:      The Storage Domain uses CIFS/SMB based storage
#
# @SHAREDFS:  The Storage Domain uses storage from a Linux VFS file system
#
# Since: 4.10.0
# XXX: Need to specify explicit int values for the enum
##
{'enum': 'StorageDomainType',
 'data': ['UNKNOWN', 'NFS', 'FCP', 'ISCSI', 'LOCALFS', 'CIFS', 'SHAREDFS']}

This is missing GLUSTERFS which is referenced in the code with an int constant of value 7, so it should be enumerated after SHAREDFS.
Comment 1 Allon Mureinik 2015-04-26 16:40:42 UTC 
Fred, as you're the QA contact, please work with Nir on this issue.
Comment 2 Red Hat Bugzilla Rules Engine 2015-10-19 11:00:46 UTC 
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.
Comment 3 Sandro Bonazzola 2015-10-26 12:28:37 UTC 
this is an automated message. oVirt 3.6.0 RC3 has been released and GA is targeted to next week, Nov 4th 2015.
Please review this bug and if not a blocker, please postpone to a later release.
All bugs not postponed on GA release will be automatically re-targeted to

- 3.6.1 if severity >= high
- 4.0 if severity < high
Comment 4 Yaniv Lavi 2015-10-29 09:13:51 UTC 
Sandro, what is the impact of this issue on HE on gluster?
Comment 5 Sandro Bonazzola 2015-10-29 09:34:07 UTC 
(In reply to Yaniv Dary from comment #4)
> Sandro, what is the impact of this issue on HE on gluster?

If I've understood correctly, this API schema affects JSON-RPC only. Hosted Engine is using XML-RPC since no JSON-RPC client is available so 3.6 shouldn't be affected by this.
Comment 6 Sandro Bonazzola 2016-05-02 09:47:30 UTC 
Moving from 4.0 alpha to 4.0 beta since 4.0 alpha has been already released and bug is not ON_QA.
Comment 7 Yaniv Lavi 2016-05-23 13:12:32 UTC 
oVirt 4.0 beta has been released, moving to RC milestone.
Comment 8 Raz Tamir 2017-01-27 14:10:59 UTC 
Hi Sandro,
Where can I find the info you mentioned in the description?
Comment 9 Tal Nisan 2017-01-30 10:52:50 UTC 
Patch was not backported to 4.1 on time and did not make it to beta
Comment 10 Sandro Bonazzola 2017-01-30 17:19:46 UTC 
It was in ./vdsm/rpc/vdsmapi-schema.json but the file doesn't exist anymore on master branch since 2 years passed before fixing this issue.
You can still see that file in 3.6 branch.
Note You need to log in before you can comment on or make changes to this bug.