Bug 121514 - CAN-2005-0758 zgrep has security issue in sed usage
CAN-2005-0758 zgrep has security issue in sed usage
Status: CLOSED ERRATA
Product: Red Hat Enterprise Linux 3
Classification: Red Hat
Component: gzip (Show other bugs)
3.0
All Linux
medium Severity low
: ---
: ---
Assigned To: Ivana Varekova
Ben Levenson
impact=low,public=20050422,source=red...
: Security
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2004-04-22 06:46 EDT by Mark J. Cox (Product Security)
Modified: 2007-11-30 17:07 EST (History)
1 user (show)

See Also:
Fixed In Version: RHSA-2005-357
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2005-06-13 08:12:56 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)

  None (edit)
Description Mark J. Cox (Product Security) 2004-04-22 06:46:36 EDT
Al Viro posted to vendor-sec on Apr22:

zgrep contains the following gem:

for i do
[snip]
      if test $with_filename -eq 1; then
        sed_script="s|^[^:]*:|${i}:|"
      else
        sed_script="s|^|${i}:|"
      fi
      $grep $opt "$pat" | sed "$sed_script"
[snip]
done

Aside of the correctness issues (try to use zgrep on files with e.g.
'&' in names), it leads to obvious fun when zgrep arguments had been
obtained by globbing in an untrusted place.  Even with standard sed we
have at least ;w<filename>; to deal with; for GNU sed there's also ;e;
on top of that (execute the contents of pattern space).  bzgrep is no
better - it's based on zgrep.

AFAICS, there are two solutions - one is to do what *BSD had done and
make grep(1) use zlib and libbz; then zgrep et.al. become links to
grep.  Another is to quote \, |, ; and newlines, which means extra
invocation of sed(1)...

Treating as embargoed.
Also affects bzip2 package; not creating extra bug at this time
Comment 4 Jeff Johnson 2004-05-11 10:31:33 EDT

*** This bug has been marked as a duplicate of 123012 ***
Comment 5 Mark J. Cox (Product Security) 2004-05-11 10:40:00 EDT
not a duplicate.  123012 refers to this bug as it applies to Fedora
Core; this bug refers to Red Hat Enterprise Linux.  The two will
probably require different solutions.
Comment 6 Josh Bressers 2005-04-04 09:30:02 EDT
Ping on this issue (now that there is a new maintainer)
Comment 7 Ivana Varekova 2005-04-05 09:37:36 EDT
The new version 1.3.3-10.rhel3 is in errata process now.
Ivana Varekova
Comment 8 Josh Bressers 2005-04-07 10:09:55 EDT
Ivana,

Can you verify if this issue also affects RHEL2.1 and RHEL4?  My notes say yes
but the bug doesn't specify.
Comment 9 Ivana Varekova 2005-04-07 10:24:08 EDT
Yes I will verify it. 
Ivana
Comment 10 Ivana Varekova 2005-04-08 07:48:24 EDT
New RHEL2.1 and RHEL4 versions are in errata process now.
Ivana Varekova
Comment 11 Jay Turner 2005-04-25 10:06:33 EDT
Testing successful with the following:
gzip-1.3-16.rhel2
gzip-1.3.3-10.rhel3
gzip-1.3.3-14.rhel4
Comment 12 Josh Bressers 2005-04-27 10:36:57 EDT
Lifting embargo
Comment 13 Josh Bressers 2005-06-13 08:12:57 EDT
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2005-357.html

Note You need to log in before you can comment on or make changes to this bug.