Bug 121649 - typo in sk_g16.c kernel source
Summary: typo in sk_g16.c kernel source
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Linux 3
Classification: Red Hat
Component: kernel
Version: 3.0
Hardware: All
OS: Linux
medium
low
Target Milestone: ---
Assignee: Jeff Garzik
QA Contact: Brian Brock
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2004-04-24 15:27 UTC by Brian Smith
Modified: 2007-11-30 22:07 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-02-18 07:42:42 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Brian Smith 2004-04-24 15:27:33 UTC
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4.2)
Gecko/20040301

Description of problem:
In /usr/src/linux/drivers/net/sk_g16.c it causes a make modules to
fail with compiler error.

The fix is to change sb to skb on line 1285 from:
  memcpy_toio((tmdp->u.buffer & 0x00ffffff) + sb->len, pad, len-skb->len);
to:
  memcpy_toio((tmdp->u.buffer & 0x00ffffff) + skb->len, pad,
len-skb->len);

Granted this is minor, and I don't use this driver, but someone might. :)

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. cd /usr/src/linux
2. make modules


    

Actual Results:  compiler error

Expected Results:  all modules made w/o error

Additional info:

Comment 3 Ernie Petrides 2005-03-02 18:23:57 UTC
Hello, Brian.  A fixed version of that driver is upstream in 2.6.  But
the version whose source is included in RHEL3 is obsolete and is not
built in RHEL3 distributions because CONFIG_OBSOLETE is not enabled.



Note You need to log in before you can comment on or make changes to this bug.