Bug 1217256 - Shutdown by hardware button does not work in Xfce with default configuration
Summary: Shutdown by hardware button does not work in Xfce with default configuration
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: xfce4-power-manager
Version: 23
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Mukundan Ragavan
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-04-29 21:33 UTC by Raphael Groner
Modified: 2016-03-26 18:17 UTC (History)
2 users (show)

Fixed In Version: xfce4-power-manager-1.5.2-6.fc23 xfce4-power-manager-1.5.2-6.fc24
Clone Of:
Environment:
Last Closed: 2016-03-17 20:51:29 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
expected power manager settings (620.26 KB, image/png)
2015-04-29 21:33 UTC, Raphael Groner
no flags Details

Description Raphael Groner 2015-04-29 21:33:57 UTC
Created attachment 1020338 [details]
expected power manager settings

Description of problem:
Shutdown does not work in Xfce 4.12, as the default configuration is installed in Fedora 22 Beta-3.

Version-Release number of selected component (if applicable):
xfce4-power-manager-1.4.4-1.fc22.x86_64

How reproducible:
yes

Steps to Reproduce:
1. install Fedora 22 Xfce
2. login
3. press the hardware power button

Actual results:
nothing happens

Expected results:
shutdown is initiated (option "Shutdown"), or at least the system asks what to do (option "Ask")

Additional info:
Further, the systray icon should be active. See attached screen shot how the settings should look like in the live run and after a fresh installed system.

Comment 1 Mukundan Ragavan 2015-04-30 00:49:47 UTC
I am not sure if I want to change the defaults. But, I agree that "Ask" is certainly a better option than "Do nothing". Let me look.

As for systray icon, I will change that. But, it may be weekend before I get to this.

Thanks for the report.

Comment 2 Raphael Groner 2015-07-27 14:38:24 UTC
Any news here? The fix should be easy to do, isn't it?

Comment 3 Mukundan Ragavan 2015-08-11 00:43:29 UTC
raphael, I in the midst of moving and will be out till the 23rd aug. I will take a look again on or after 23rd ..

Thanks for pinging.

Comment 4 Raphael Groner 2015-11-15 16:28:59 UTC
Can I help somehow to get this old bug closed?

Comment 5 Mukundan Ragavan 2015-11-15 23:08:29 UTC
I will just have to poke at xfpm configs. Unfortunately, I will be able to take a look this Friday (travel).

Of course, if you do get some info, I can do the needful. I am very sorry for the delay.

Comment 6 Raphael Groner 2016-02-10 09:31:59 UTC
What's the state here? I'm asking cause you did recently some new builds to xfpm.

Comment 7 Mukundan Ragavan 2016-02-10 22:52:40 UTC
Oh yeah ... My apologies. I did not add any fix to this issue in the recent build. I should not have added this bug either to the update.

:(

Comment 8 Mukundan Ragavan 2016-02-19 02:10:48 UTC
Raphael - Can you please try this build and see how it looks?

https://koji.fedoraproject.org/koji/taskinfo?taskID=13042455

Comment 9 Raphael Groner 2016-02-19 13:19:08 UTC
Hmm, in an updated F23 system, xfpm 1.5.2-4 does not prevent logind to handle the ACPI shutdown event and the machine shuts down immediately for a button press. Although, setting in xfpm is "do nothing" for hardware button.

I can not use your build for a test in F22 because it's for F23. Besides that, where can I see what was changed in sources, especially I mean for 1.5.2-5?

Comment 11 Raphael Groner 2016-03-03 16:51:13 UTC
Sorry for my late feedback. As I'm not using Xfce any more in daily work, I am not sure how to verify this bug. What can we do? Are there any test cases to work with?

Comment 12 Mukundan Ragavan 2016-03-03 22:00:01 UTC
(In reply to Raphael Groner from comment #11)
> Sorry for my late feedback. As I'm not using Xfce any more in daily work, I
> am not sure how to verify this bug. What can we do? Are there any test cases
> to work with?

I suggest creating a new user and logging into Xfce. The default config in fedora should be present in this test. This will tell us if my solution really works.

Thanks for the feedback. No worries about the delay.

Comment 13 Raphael Groner 2016-03-04 15:38:26 UTC
(In reply to Mukundan Ragavan from comment #8)
> Raphael - Can you please try this build and see how it looks?
> 
> https://koji.fedoraproject.org/koji/taskinfo?taskID=13042455

x = OK
! = fail

{x} Settings dialog shows "ask" for all three event actions.
{!} Inhibition of systemd does not work, expected: no shutdown occurs.
    [machine shuts down immediately for an AHCI event (via virt-manager, kvm)]
{!} Systray icon is not visible, expected: on.
{!} Option for icon in settings dialog is off for systray icon, expected: on. 

Tested with F23-x86_64-XFCE-20160303.iso (respin).

Comment 14 Raphael Groner 2016-03-04 15:41:15 UTC
Note: Test results in comment #13 with two new users, one chose to see an empty panel after first login, second said to want default panel.

Comment 15 Mukundan Ragavan 2016-03-05 14:09:04 UTC
Thanks Raphael for testing.

(In reply to Raphael Groner from comment #13)
> (In reply to Mukundan Ragavan from comment #8)
> > Raphael - Can you please try this build and see how it looks?
> > 
> > https://koji.fedoraproject.org/koji/taskinfo?taskID=13042455
> 
> x = OK
> ! = fail
> 
> {x} Settings dialog shows "ask" for all three event actions.

---> Perfect!

> {!} Inhibition of systemd does not work, expected: no shutdown occurs.
>     [machine shuts down immediately for an AHCI event (via virt-manager,
> kvm)]

---> This should be an entirely different issue. Do you agree?

> {!} Systray icon is not visible, expected: on.
> {!} Option for icon in settings dialog is off for systray icon, expected:
> on. 
> 
> Tested with F23-x86_64-XFCE-20160303.iso (respin).

---> I have now fixed this in my new patch.


I will build this for rawhide and f24.

Comment 16 Raphael Groner 2016-03-05 14:17:59 UTC
(In reply to Mukundan Ragavan from comment #15)
> Thanks Raphael for testing.

You're welcome. :)

> (In reply to Raphael Groner from comment #13)> > {!} Inhibition of systemd does not work, expected: no shutdown occurs.
> >     [machine shuts down immediately for an AHCI event (via virt-manager,
> > kvm)]
> 
> ---> This should be an entirely different issue. Do you agree?

Well, we see a clear regression here. And if xfpm4 promises to ask for event actions to take, why does it not inhibit systemd default behaviour? I thought that was fixed upstream, now it's b0rken again.

> > {!} Systray icon is not visible, expected: on.
> > {!} Option for icon in settings dialog is off for systray icon, expected:
> > on. 
> > 
> > Tested with F23-x86_64-XFCE-20160303.iso (respin).
> 
> ---> I have now fixed this in my new patch.
> 
> 
> I will build this for rawhide and f24.

Cool. Please let me know about a new build.

Comment 17 Mukundan Ragavan 2016-03-05 14:29:55 UTC
(In reply to Raphael Groner from comment #16)
> …
> > > {!} Inhibition of systemd does not work, expected: no shutdown occurs.
> > >     [machine shuts down immediately for an AHCI event (via virt-manager,
> > > kvm)]
> > 
> > ---> This should be an entirely different issue. Do you agree?
> 
> Well, we see a clear regression here. And if xfpm4 promises to ask for event
> actions to take, why does it not inhibit systemd default behaviour? I
> thought that was fixed upstream, now it's b0rken again.
> 

Let me open a new bug report for this after I test this further. I have never really come across this honestly ... :(

> > 
> > 
> > I will build this for rawhide and f24.
> 
> Cool. Please let me know about a new build.

Rawhide - https://koji.fedoraproject.org/koji/buildinfo?buildID=742000
f24 - https://koji.fedoraproject.org/koji/buildinfo?buildID=742002 (building at the moment)

Again, thanks for this report and for testing! :)

Comment 18 Mukundan Ragavan 2016-03-06 21:33:48 UTC
So, I did a bit of testing with this.

Unless I do "force off" - I have no issues in triggering the "ask" action.

Do you have specific steps to reproduce this? Also, I doubt that this is a regression with the cuurent config build - I am going to close this issue as done.

Can you please open a new report along with steps on how I can try reproducing this?

Thanks!

Comment 19 Fedora Update System 2016-03-09 04:24:06 UTC
xfce4-power-manager-1.5.2-6.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-712eb3050d

Comment 20 Fedora Update System 2016-03-09 04:24:18 UTC
xfce4-power-manager-1.5.2-6.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-88fbd1a26c

Comment 21 Fedora Update System 2016-03-09 22:55:22 UTC
xfce4-power-manager-1.5.2-6.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-88fbd1a26c

Comment 22 Fedora Update System 2016-03-10 01:56:34 UTC
xfce4-power-manager-1.5.2-6.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-712eb3050d

Comment 23 Raphael Groner 2016-03-10 13:37:09 UTC
xfce4-power-manager-1.5.2-5 as in nightly f24 livemedia of 20160310 works for me.
I'll test 1.5.2-6 also and give karma.

Comment 24 Raphael Groner 2016-03-10 14:40:00 UTC
(In reply to Mukundan Ragavan from comment #18)
> So, I did a bit of testing with this.
> 
> Unless I do "force off" - I have no issues in triggering the "ask" action.
> 
> Do you have specific steps to reproduce this? Also, I doubt that this is a
> regression with the cuurent config build - I am going to close this issue as
> done.
> 
> Can you please open a new report along with steps on how I can try
> reproducing this?
> 
> Thanks!

In KVM, the F23 guest shuts down immediately when I click on the (external) shutdown button to emit an ACPI event into the guest. That's not reproducible in F24. Both times with a new user. Though, the systray icon is now enabled and visible for all users.

Comment 25 Fedora Update System 2016-03-17 20:51:22 UTC
xfce4-power-manager-1.5.2-6.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 26 Fedora Update System 2016-03-26 18:17:29 UTC
xfce4-power-manager-1.5.2-6.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.