Bug 1217495 - The new sign plugin signs all rpms in resultdir
Summary: The new sign plugin signs all rpms in resultdir
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: mock
Version: 26
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Miroslav Suchý
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-04-30 13:44 UTC by Roy Bonser
Modified: 2018-05-26 22:40 UTC (History)
8 users (show)

Fixed In Version: mock-1.4.10-1.fc28 mock-1.4.10-1.fc27 mock-1.4.10-1.el7
Clone Of:
Environment:
Last Closed: 2018-05-13 20:00:05 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
do signing of current packages (1.14 KB, patch)
2015-09-18 14:43 UTC, Mikhail Campos
no flags Details | Diff
Sign only built packages in resultdir (1.48 KB, patch)
2017-02-27 14:35 UTC, Mikhail Campos
no flags Details | Diff

Description Roy Bonser 2015-04-30 13:44:43 UTC
Description of problem:
I was testing the new sign plugin in mock 1.2.8. We use a common resultdir and createrepo with mock so rpms accumulate in the folder for testing.

The sign plugin grabs a list of every rpm in the resultdir and signs them. Is this intentional?

I expected the list to be the rpms produced in the current run of mock. The way it is now, on repeated mock runs the existing rpms in the resultdir get signed over and over.

  --Roy

Version-Release number of selected component (if applicable):
mock-1.2.8

Comment 1 Jan Kurik 2015-07-15 14:12:50 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle.
Changing version to '23'.

(As we did not run this process for some time, it could affect also pre-Fedora 23 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23

Comment 2 Mikhail Campos 2015-09-18 14:43:54 UTC
Created attachment 1074947 [details]
do signing of current packages

Proposed patch attached

Comment 3 Fedora End Of Life 2016-11-24 11:45:17 UTC
This message is a reminder that Fedora 23 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 23. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '23'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 23 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 4 Vit Ry 2017-02-27 10:06:08 UTC
There is one problem of such (and current) signing. It calls smth like

> my-sign-script.sh --addsign pkg1.rpm pkg2.rpm pkg3.rpm ...

and in case of a lot of binary packages in resultdir (texlive has ~5k of rpms from one src.rpm) command would fails, because of too long argument list (over 4Mb line, as far as I remember; bash-restriction)

Comment 5 Mikhail Campos 2017-02-27 14:35:18 UTC
Created attachment 1258113 [details]
Sign only built packages in resultdir

We can do signing by chunks for those packages that have a lot of binaries

Comment 6 Fedora End Of Life 2017-02-28 09:43:25 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle.
Changing version to '26'.

Comment 7 Vit Ry 2017-04-25 02:52:43 UTC
How to use sign-plugin at all (which workflow?), since gpg-key requires manually type password first? Which is official way to automate it?

Comment 8 Fedora End Of Life 2018-05-03 08:05:55 UTC
This message is a reminder that Fedora 26 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 26. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '26'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 26 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 9 Miroslav Suchý 2018-05-10 11:29:30 UTC
Fixed in https://github.com/rpm-software-management/mock/pull/177

Comment 10 Fedora Update System 2018-05-10 12:14:54 UTC
mock-1.4.10-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-28fdd00a4b

Comment 11 Fedora Update System 2018-05-10 12:15:07 UTC
mock-1.4.10-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-8c3673366b

Comment 12 Fedora Update System 2018-05-10 12:15:19 UTC
mock-1.4.10-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-1a033ecee8

Comment 13 Fedora Update System 2018-05-10 20:01:39 UTC
mock-1.4.10-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-8c3673366b

Comment 14 Fedora Update System 2018-05-11 01:34:49 UTC
mock-1.4.10-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-28fdd00a4b

Comment 15 Fedora Update System 2018-05-11 02:00:19 UTC
mock-1.4.10-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-1a033ecee8

Comment 16 Fedora Update System 2018-05-13 20:00:05 UTC
mock-1.4.10-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2018-05-19 21:34:41 UTC
mock-1.4.10-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 18 Fedora Update System 2018-05-26 22:40:50 UTC
mock-1.4.10-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.