Description of problem: w3imgdisplay-based image preview not working Version-Release number of selected component (if applicable): 1.6.1-4.fc21 How reproducible: Always Steps to Reproduce: 1. Install w3m-img and enable preview_images in ranger's rc.conf 2. Launch ranger and browse to a image file Actual results: Nothing shows up in preview column. A 'file not found' error raises at the status line. Expected results: A image in the preview column Additional info: The fix seems simple, ranger looks for w3imgdisplay at /usr/lib/w3m/ but in Fedora it resides in /usr/libexec/w3m/ The file is /usr/lib/python2.7/site-packages/ranger/ext/img_display.py line 16
This message is a reminder that Fedora 21 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 21. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '21'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 21 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 21 changed to end-of-life (EOL) status on 2015-12-01. Fedora 21 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.
The problem persists in Fedora 23.
The bug is a combination of the moved location of w3mimgdisplay on Fedora and an omission within the packaged version of ranger - there are two calls to the w3mimgdisplay binary, of which only one respects the W3MIMGDISPLAY_PATH environment variable documented in the ranger manpage. The bug is resolved in the current (git) version of ranger, as the code has been changed to properly rely on the environment variable in both calls. A workaround is to alter the value of the "W3MIMGDISPLAY_PATH" variable within /usr/lib/python2.7/site-packages/ranger/ext/img_display.py to correctly point to the libexec location. Alternatively a symlink could be created at /usr/lib/w3m/w3mimgdisplay that points to /usr/libexec/w3m/w3mimgdisplay. If/when a newer version of ranger is packaged, the only modification necessary for ranger to work with Fedora's changed location of w3mimgdisplay would be setting the environment variable as described above.
ranger-1.6.1-7.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3b9d4bbf0d
ranger-1.6.1-7.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-71a5a26daf
jrobeson mentioned this on IRC, so I've backported the patch from the Rawhide package to the F22 and F23 builds, please let me know if the updates work for you :) It looks to me like with the latest upstream commits this should all 'just work' with the next ranger release and the patch can be dropped from Rawhide whenever the next release comes out. I didn't want to update F22 and F23 to 1.7 because the change of the default editor from nano to vim looks like a 'behaviour change' of the kind the Fedora updates policy discourages.
ranger-1.6.1-7.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-71a5a26daf
ranger-1.6.1-7.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-3b9d4bbf0d
ranger-1.6.1-7.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
ranger-1.6.1-7.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.