Bug 1218090 (seld/phar-utils) - Review Request: php-seld-phar-utils - PHAR file format utilities
Summary: Review Request: php-seld-phar-utils - PHAR file format utilities
Keywords:
Status: CLOSED ERRATA
Alias: seld/phar-utils
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Shawn Iwinski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-05-04 08:26 UTC by Remi Collet
Modified: 2015-05-29 21:49 UTC (History)
2 users (show)

Fixed In Version: php-seld-phar-utils-1.0.0-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-05-26 03:16:03 UTC
shawn: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
phpcompatinfo.log (2.18 KB, text/plain)
2015-05-10 03:22 UTC, Shawn Iwinski
no flags Details
fedora-review.txt (6.55 KB, text/plain)
2015-05-10 03:22 UTC, Shawn Iwinski
no flags Details

Description Remi Collet 2015-05-04 08:26:14 UTC
Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/aa573a708ab4796c80ed115cc3e1a536534dda0d/php/php-seld-phar-utils/php-seld-phar-utils.spec
SRPM URL: http://rpms.famillecollet.com/SRPMS/php-seld-phar-utils-1.0.0-1.remi.src.rpm
Description: 
PHAR file format utilities, for when PHP phars you up.

Fedora Account System Username: remi

--
Dependency of composer

Comment 1 Shawn Iwinski 2015-05-10 03:22:12 UTC
Created attachment 1023910 [details]
phpcompatinfo.log

phpCompatInfo version 3.7.3

Comment 2 Shawn Iwinski 2015-05-10 03:22:45 UTC
Created attachment 1023911 [details]
fedora-review.txt

Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1218090
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 3 Shawn Iwinski 2015-05-10 03:23:16 UTC
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)

As usual, remove EPEL5 bits after initial import.



Since no %check, "BuildRequires:  php(language) >= 5.3" is not really necessary unless you just want to prevent even building the RPM on systems without PHP >= 5.3.



No blockers.



===== APPROVED =====

Comment 4 Remi Collet 2015-05-11 07:10:11 UTC
Thanks for the review.

New Package SCM Request
=======================
Package Name: php-seld-phar-utils
Short Description: PHAR file format utilities
Upstream URL: https://github.com/Seldaek/phar-utils
Owners: remi
Branches:f21 f22 epel7 
InitialCC:

Comment 5 Gwyn Ciesla 2015-05-11 12:36:00 UTC
Git done (by process-git-requests).

Comment 6 Remi Collet 2015-05-11 13:26:02 UTC
Can you please check, the package doesn't appears in pkgdb and 

$ fedpkg clone php-seld-phar-utils 
Clonage dans 'php-seld-phar-utils'...
FATAL: R any php-seld-phar-utils remi DENIED by fallthru

Comment 7 Gwyn Ciesla 2015-05-11 18:09:29 UTC
Git done (by process-git-requests).

Comment 8 Fedora Update System 2015-05-14 07:01:48 UTC
php-seld-phar-utils-1.0.0-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/php-seld-phar-utils-1.0.0-1.fc22

Comment 9 Fedora Update System 2015-05-14 07:02:58 UTC
php-seld-phar-utils-1.0.0-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/php-seld-phar-utils-1.0.0-1.fc21

Comment 10 Fedora Update System 2015-05-14 07:04:08 UTC
php-seld-phar-utils-1.0.0-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/php-seld-phar-utils-1.0.0-1.el7

Comment 11 Fedora Update System 2015-05-14 20:08:45 UTC
php-seld-phar-utils-1.0.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository.

Comment 12 Fedora Update System 2015-05-26 03:16:03 UTC
php-seld-phar-utils-1.0.0-1.fc22 has been pushed to the Fedora 22 stable repository.

Comment 13 Fedora Update System 2015-05-26 03:19:54 UTC
php-seld-phar-utils-1.0.0-1.fc21 has been pushed to the Fedora 21 stable repository.

Comment 14 Fedora Update System 2015-05-29 21:49:05 UTC
php-seld-phar-utils-1.0.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository.


Note You need to log in before you can comment on or make changes to this bug.