Bug 1218159 - Review Request: python-closure-linter - Style checker for JavaScript
Summary: Review Request: python-closure-linter - Style checker for JavaScript
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Miro Hrončok
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-05-04 10:26 UTC by Julien Enselme
Modified: 2016-07-04 11:03 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-07-04 11:03:06 UTC
Type: ---
Embargoed:
mhroncok: fedora-review?


Attachments (Terms of Use)

Description Julien Enselme 2015-05-04 10:26:12 UTC
Spec URL: http://jenselme.perso.centrale-marseille.fr/visible/SPECS/python-closure_linter.spec
SRPM URL: http://jenselme.perso.centrale-marseille.fr/visible/SRPMS/python-closure_linter-2.3.13-1.fc21.src.rpm
Description:
Style checker for JavaScript

Fedora Account System Username: jujens

Comment 2 Miro Hrončok 2015-05-31 17:58:12 UTC
No Python 3 support?

Comment 3 Julien Enselme 2015-05-31 18:15:45 UTC
(In reply to Miro Hrončok from comment #2)
> No Python 3 support?

Not that I am aware of. There nothing in pypi or the setup.py that indicates that this program is compatible with python 3.

Comment 4 Miro Hrončok 2015-05-31 19:35:35 UTC
Apparently, it is indeed not Python 3 compatible. OK, I'll take the review.

Comment 5 Miro Hrončok 2015-05-31 19:36:04 UTC
I forgot to link this: https://code.google.com/p/closure-linter/issues/detail?id=81

Comment 6 Miro Hrončok 2015-05-31 19:37:19 UTC
I see LICENSE file in the tarball, but no %license in the package.

Comment 7 Miro Hrončok 2015-05-31 19:41:20 UTC
> Requires:         python

Feels useless, as this package should automatically require /usr/bin/python and python(abi) = 2.7

Any chance for longer description?

Comment 8 Julien Enselme 2015-06-01 06:50:35 UTC
> I see LICENSE file in the tarball, but no %license in the package.

The LICENSE was not present in the fist tarball I used but it is in the tarball from pypi. Added.

> Feels useless, as this package should automatically require /usr/bin/python

Indeed, require removed.

> Any chance for longer description?

Use a longer description.

Comment 9 Miro Hrončok 2016-07-04 10:43:37 UTC
Where are we with this? Closing?

Comment 10 Julien Enselme 2016-07-04 11:03:06 UTC
> Closing?

I don't need this any more. So yes, I'll close this.


Note You need to log in before you can comment on or make changes to this bug.